Remove the error translation for ACL checks for attribute writes

Author: andy31415

src/app/codegen-data-model/CodegenDataModel_Write.cpp

@@ -59,11 +59,6 @@ std::optional<CHIP_ERROR> TryWriteViaAccessInterface(const ConcreteAttributePath
 
     CHIP_ERROR err = aai->Write(path, decoder);
 
-    // explict translate UnsupportedRead to Access denied. This is to allow callers to determine a
-    // translation for this: usually wildcard subscriptions MAY just ignore these where as direct reads
-    // MUST translate them to UnsupportedAccess
-    ReturnErrorCodeIf(err == CHIP_IM_GLOBAL_STATUS(UnsupportedWrite), CHIP_ERROR_ACCESS_DENIED);
-
     if (err != CHIP_NO_ERROR)
     {
         return std::make_optional(err);
@@ -74,6 +69,7 @@ std::optional<CHIP_ERROR> TryWriteViaAccessInterface(const ConcreteAttributePath
     //   - if no encode, say that processing must continue
     return decoder.TriedDecode() ? std::make_optional(CHIP_NO_ERROR) : std::nullopt;
 }
+
 /// Metadata of what a ember/pascal short string means (prepended by a u8 length)
 struct ShortPascalString
 {

src/app/data-model-interface/DataModel.h

@@ -58,7 +58,7 @@ class DataModel : public DataModelMetadataTree
     /// TEMPORARY/TRANSITIONAL requirement for transitioning from ember-specific code
     ///   ReadAttribute is REQUIRED to perform:
     ///     - ACL validation (see notes on OperationFlags::kInternal)
-    ///     - Validation of readability/writability
+    ///     - Validation of readability/writability (also controlled by OperationFlags::kInternal)
     ///     - use request.path.mExpanded to skip encoding replies for data according
     ///       to 8.4.3.2 of the spec:
     ///         > If the path indicates attribute data that is not readable, then the path SHALL
@@ -84,8 +84,10 @@ class DataModel : public DataModelMetadataTree
     /// When this is invoked, caller is expected to have already done some validations:
     ///    - cluster `data version` has been checked for the incoming request if applicable
     ///
-    /// When `request.writeFlags.Has(WriteFlags::kForceInternal)` the request is from an internal app update
-    /// and SHOULD bypass some internal checks (like timed enforcement, potentially read-only restrictions)
+    /// TEMPORARY/TRANSITIONAL requirement for transitioning from ember-specific code
+    ///   WriteAttribute is REQUIRED to perform:
+    ///     - ACL validation (see notes on OperationFlags::kInternal)
+    ///     - Validation of readability/writability (also controlled by OperationFlags::kInternal)
     ///
     /// Return codes
     ///   CHIP_IM_GLOBAL_STATUS(code):