@@ -266,10 +266,9 @@ jobs:
266
266
run : |
267
267
git grep -n 'NSLog(' -- src/darwin/Framework/CHIP && exit 1 || exit 0
268
268
269
- # git grep exits with 0 if it finds a match, but we want
270
- # to fail (exit nonzero) on match. And we want to exclude this file,
271
- # to avoid our grep regexp matching itself, as well as excluding the files
272
- # that implement the type-safe accessors
269
+ # This check ensures that there are no `ember` nor `emAf` symbols being used
270
+ # We want to start removing exclusions as soon as they aren't required anymore
271
+ # To remove or add exclusions, simply add the directory as an argument with the `--skip-dir` flag
273
272
- name :
274
273
Check for use of 'emberAf' or 'emAf' symbols
275
274
if : always()
@@ -284,9 +283,11 @@ jobs:
284
283
--skip-dir src/data-model-providers \
285
284
--skip-dir scripts/
286
285
287
- # This check ensures that there are no `ember` nor `emAf` symbols being used
288
- # We want to start removing exclusions as soon as they aren't required anymore
289
- # To remove or add exclusions, simply add the directory as an argument with the `--skip-dir` flag
286
+ # git grep exits with 0 if it finds a match, but we want
287
+ # to fail (exit nonzero) on match. And we want to exclude this file,
288
+ # to avoid our grep regexp matching itself, as well as excluding the files
289
+ # that implement the type-safe accessors, attribute writing from the wire, and some
290
+ # Pigweed RPC code that seems hard to update.
290
291
- name :
291
292
Check for use of 'emberAfReadAttribute' instead of the
292
293
type-safe getters
0 commit comments