Skip to content

Commit 8ae2f6a

Browse files
committed
Apply code review suggestions
1 parent a94cb7c commit 8ae2f6a

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/app/data-model/Decode.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@ CHIP_ERROR Decode(TLV::TLVReader & reader, X & x)
114114
return x.Decode(reader);
115115
}
116116

117+
117118
/*
118119
* @brief
119120
*
@@ -127,8 +128,7 @@ CHIP_ERROR Decode(TLV::TLVReader & reader, X & x)
127128
template <typename X,
128129
typename std::enable_if_t<
129130
std::is_class<X>::value &&
130-
std::is_same<decltype(std::declval<X>().Decode(std::declval<TLV::TLVReader &>(), std::declval<FabricIndex>())),
131-
CHIP_ERROR>::value,
131+
std::is_same<decltype(std::declval<X>().Decode(std::declval<TLV::TLVReader &>(), std::declval<FabricIndex>())), CHIP_ERROR>::value,
132132
X> * = nullptr>
133133
CHIP_ERROR Decode(TLV::TLVReader & reader, X & x, FabricIndex aAccessingFabricIndex)
134134
{

src/app/zap-templates/templates/app/im-cluster-command-handler.zapt

+4
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,11 @@ Protocols::InteractionModel::Status DispatchServerCommand(CommandHandler * apCom
3737
{{/first}}
3838
case Commands::{{asUpperCamelCase commandName}}::Id: {
3939
Commands::{{asUpperCamelCase commandName}}::DecodableType commandData;
40+
{{#if isFabricScoped~}}
4041
TLVError = DataModel::Decode(aDataTlv, commandData, apCommandObj->GetAccessingFabricIndex());
42+
{{else}}
43+
TLVError = DataModel::Decode(aDataTlv, commandData);
44+
{{/if}}
4145
if (TLVError == CHIP_NO_ERROR)
4246
{
4347
wasHandled = emberAf{{asUpperCamelCase parent.clusterName}}Cluster{{asUpperCamelCase commandName}}Callback(apCommandObj, aCommandPath, commandData);

0 commit comments

Comments
 (0)