Skip to content

Commit 8b8b7ef

Browse files
committed
Added few comments
1 parent d1ac307 commit 8b8b7ef

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

src/credentials/attestation_verifier/DefaultDeviceAttestationVerifier.cpp

+13
Original file line numberDiff line numberDiff line change
@@ -613,6 +613,19 @@ CHIP_ERROR DefaultDACVerifier::VerifyNodeOperationalCSRInformation(const ByteSpa
613613
return CHIP_NO_ERROR;
614614
}
615615

616+
617+
// This method parses the below JSON Scheme
618+
// [
619+
// {
620+
// "type": "revocation_set",
621+
// "issuer_subject_key_id": "63540E47F64B1C38D13884A462D16C195D8FFB3C",
622+
// "issuer_name": "MD0xJTAjBgNVBAMMHE1hdHRlciBEZXYgUEFJIDB4RkZGMSBubyBQSUQxFDASBgorBgEEAYKifAIBDARGRkYx",
623+
// "revoked_serial_numbers": [
624+
// "69CDF10DE9E54ED1"
625+
// ]
626+
// }
627+
// ]
628+
//
616629
bool DefaultDACVerifier::IsEntryExistsInRevocationSet(const CharSpan & akidHexStr, const CharSpan & issuerNameBase64Str,
617630
const CharSpan & serialNumberHexStr)
618631
{

src/credentials/attestation_verifier/DefaultDeviceAttestationVerifier.h

+1
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ class DefaultDACVerifier : public DeviceAttestationVerifier
7878
Callback::Callback<OnAttestationInformationVerification> * onCompletion) override;
7979

8080
// Set the path to the device attestation revocation set JSON file.
81+
// revocation set can be generated using credentials/generate-revocation-set.py script
8182
void SetDeviceAttestationRevocationSetPath(const char * path) { mDeviceAttestationRevocationSetPath = path; }
8283

8384
CsaCdKeysTrustStore * GetCertificationDeclarationTrustStore() override { return &mCdKeysTrustStore; }

0 commit comments

Comments
 (0)