Update per review comments

Author: yufengwangca

examples/fabric-admin/device_manager/DeviceManager.cpp

@@ -115,14 +115,14 @@ void DeviceManager::RemoveSyncedDevice(NodeId nodeId)
                     ChipLogValueX64(device->GetNodeId()), device->GetEndpointId());
 }
 
-void DeviceManager::OpenDeviceCommissioningWindow(NodeId nodeId, uint32_t commissioningTimeout, uint32_t iterations,
+void DeviceManager::OpenDeviceCommissioningWindow(NodeId nodeId, uint32_t commissioningTimeoutSec, uint32_t iterations,
                                                   uint16_t discriminator, const ByteSpan & salt, const ByteSpan & verifier)
 {
     ChipLogProgress(NotSpecified, "Opening commissioning window for Node ID: " ChipLogFormatX64, ChipLogValueX64(nodeId));
 
     // Open the commissioning window of a device within its own fabric.
-    CHIP_ERROR err = PairingManager::Instance().OpenCommissioningWindow(nodeId, kRootEndpointId, commissioningTimeout, iterations,
-                                                                        discriminator, salt, verifier);
+    CHIP_ERROR err = PairingManager::Instance().OpenCommissioningWindow(nodeId, kRootEndpointId, commissioningTimeoutSec,
+                                                                        iterations, discriminator, salt, verifier);
     if (err != CHIP_NO_ERROR)
     {
         ChipLogError(NotSpecified, "Failed to open commissioning window: %s", ErrorStr(err));

examples/fabric-admin/device_manager/DeviceManager.h

@@ -94,7 +94,7 @@ class DeviceManager : public PairingDelegate
      * This function initiates the process to open the commissioning window for a device identified by the given node ID.
      *
      * @param nodeId               The ID of the node that should open the commissioning window.
-     * @param commissioningTimeout The time in seconds before the commissioning window closes. This value determines
+     * @param commissioningTimeoutSec The time in seconds before the commissioning window closes. This value determines
      *                             how long the commissioning window remains open for incoming connections.
      * @param iterations           The number of PBKDF (Password-Based Key Derivation Function) iterations to use
      *                             for deriving the PAKE (Password Authenticated Key Exchange) verifier.
@@ -104,7 +104,7 @@ class DeviceManager : public PairingDelegate
      * @param verifier             The PAKE verifier used to authenticate the commissioning process.
      *
      */
-    void OpenDeviceCommissioningWindow(chip::NodeId nodeId, uint32_t commissioningTimeout, uint32_t iterations,
+    void OpenDeviceCommissioningWindow(chip::NodeId nodeId, uint32_t commissioningTimeoutSec, uint32_t iterations,
                                        uint16_t discriminator, const chip::ByteSpan & salt, const chip::ByteSpan & verifier);
 
     /**

examples/fabric-admin/device_manager/PairingManager.cpp

@@ -35,7 +35,7 @@ void PairingManager::Init(Controller::DeviceCommissioner * commissioner)
     mCommissioner = commissioner;
 }
 
-CHIP_ERROR PairingManager::OpenCommissioningWindow(NodeId nodeId, EndpointId endpointId, uint16_t commissioningTimeout,
+CHIP_ERROR PairingManager::OpenCommissioningWindow(NodeId nodeId, EndpointId endpointId, uint16_t commissioningTimeoutSec,
                                                    uint32_t iterations, uint16_t discriminator, const ByteSpan & salt,
                                                    const ByteSpan & verifier)
 {
@@ -55,13 +55,13 @@ CHIP_ERROR PairingManager::OpenCommissioningWindow(NodeId nodeId, EndpointId end
     auto params                        = Platform::MakeUnique<CommissioningWindowParams>();
     params->nodeId                     = nodeId;
     params->endpointId                 = endpointId;
-    params->commissioningWindowTimeout = commissioningTimeout;
+    params->commissioningWindowTimeout = commissioningTimeoutSec;
     params->iteration                  = iterations;
     params->discriminator              = discriminator;
 
     if (!salt.empty())
     {
-        if (salt.size() > Crypto::kSpake2p_Max_PBKDF_Salt_Length)
+        if (salt.size() > sizeof(params->saltBuffer))
         {
             ChipLogError(NotSpecified, "Salt size exceeds buffer capacity");
             return CHIP_ERROR_BUFFER_TOO_SMALL;
@@ -73,7 +73,7 @@ CHIP_ERROR PairingManager::OpenCommissioningWindow(NodeId nodeId, EndpointId end
 
     if (!verifier.empty())
     {
-        if (verifier.size() > Crypto::kSpake2p_VerifierSerialized_Length)
+        if (verifier.size() > sizeof(params->verifierBuffer))
         {
             ChipLogError(NotSpecified, "Verifier size exceeds buffer capacity");
             return CHIP_ERROR_BUFFER_TOO_SMALL;

examples/fabric-admin/device_manager/PairingManager.h

@@ -67,7 +67,7 @@ class PairingManager
      *
      * @param nodeId The target node ID for commissioning.
      * @param endpointId The target endpoint ID for commissioning.
-     * @param commissioningTimeout Timeout for the commissioning window in seconds.
+     * @param commissioningTimeoutSec Timeout for the commissioning window in seconds.
      * @param iterations Iterations for PBKDF calculations.
      * @param discriminator Discriminator for commissioning.
      * @param salt Optional salt for verifier-based commissioning.