add test

Author: yunhanw-google

src/app/ReadClient.cpp

@@ -494,7 +494,6 @@ void ReadClient::OnActiveModeNotification()
     }
 
     TriggerResubscribeIfScheduled("check-in message");
-    return;
 }
 
 void ReadClient::OnPeerTypeChange(PeerType aType)

src/controller/tests/data_model/TestRead.cpp

@@ -4626,4 +4626,53 @@ System::Clock::Timeout TestRead::ComputeSubscriptionTimeout(System::Clock::Secon
     return publisherTransmissionTimeout + aMaxInterval + System::Clock::Milliseconds32(1000);
 }
 
+TEST_F(TestRead, TestSubscribeAttributeErrorWithResubWhenCheckIn)
+{
+    auto sessionHandle      = GetSessionBobToAlice();
+
+    {
+        TestResubscriptionCallback callback;
+        ReadClient readClient(InteractionModelEngine::GetInstance(), &GetExchangeManager(), callback,
+                              ReadClient::InteractionType::Subscribe);
+
+        callback.SetReadClient(&readClient);
+
+        ReadPrepareParams readPrepareParams(GetSessionBobToAlice());
+
+        // Read full wildcard paths, repeat twice to ensure chunking.
+        AttributePathParams attributePathParams[1];
+        readPrepareParams.mpAttributePathParamsList    = attributePathParams;
+        readPrepareParams.mAttributePathParamsListSize = MATTER_ARRAY_SIZE(attributePathParams);
+        attributePathParams[0].mEndpointId             = kTestEndpointId;
+        attributePathParams[0].mClusterId              = Clusters::UnitTesting::Id;
+        attributePathParams[0].mAttributeId            = Clusters::UnitTesting::Attributes::Boolean::Id;
+        readPrepareParams.mIsPeerLIT                   = true;
+        constexpr uint16_t maxIntervalCeilingSeconds = 1;
+
+        readPrepareParams.mMaxIntervalCeilingSeconds = maxIntervalCeilingSeconds;
+
+        EXPECT_EQ(callback.mOnResubscriptionsAttempted, 0);
+
+        auto err = readClient.SendAutoResubscribeRequest(std::move(readPrepareParams));
+        EXPECT_EQ(err, CHIP_NO_ERROR);
+        {
+            ScopedChange directive(gReadResponseDirective, ReadResponseDirective::kSendDataError);
+            DrainAndServiceIO();
+            EXPECT_EQ(callback.mOnResubscriptionsAttempted, 1);
+            EXPECT_EQ(callback.mOnSubscriptionEstablishedCount, 0);
+        }
+
+        {
+            ScopedChange directive(gReadResponseDirective, ReadResponseDirective::kSendDataResponse);
+            InteractionModelEngine::GetInstance()->OnActiveModeNotification(
+            ScopedNodeId(readClient.GetPeerNodeId(), readClient.GetFabricIndex()));
+            DrainAndServiceIO();
+            EXPECT_EQ(callback.mOnSubscriptionEstablishedCount, 1);
+        }
+
+        EXPECT_EQ(callback.mOnError, 0);
+        EXPECT_EQ(callback.mOnDone, 0);
+    }
+}
+
 } // namespace