Resolve PR comments for dishwasher

Author: bakreanuj

examples/chef/common/chef-dishwasher-alarm-delegate-impl.cpp

@@ -1,6 +1,6 @@
 /*
  *
- *    Copyright (c) 2023 Project CHIP Authors
+ *    Copyright (c) 2024 Project CHIP Authors
  *    All rights reserved.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");

examples/chef/common/chef-dishwasher-mode-delegate-impl.cpp

@@ -1,6 +1,6 @@
 /*
  *
- *    Copyright (c) 2023 Project CHIP Authors
+ *    Copyright (c) 2024 Project CHIP Authors
  *    All rights reserved.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
@@ -107,7 +107,7 @@ chip::Protocols::InteractionModel::Status chefDishwasherModeWriteCallback(chip::
         ret       = gDishwasherModeInstance->UpdateCurrentMode(m);
         if (chip::Protocols::InteractionModel::Status::Success != ret)
         {
-            ChipLogError(DeviceLayer, "Invalid Attribute Update status: %d", static_cast<int>(ret));
+            ChipLogError(DeviceLayer, "Invalid Attribute Write to CurrentMode : %d", static_cast<int>(ret));
         }
     }
     break;
@@ -124,7 +124,7 @@ chip::Protocols::InteractionModel::Status chefDishwasherModeReadCallback(chip::E
                                                                          const EmberAfAttributeMetadata * attributeMetadata,
                                                                          uint8_t * buffer, uint16_t maxReadLength)
 {
-    VerifyOrReturnValue(maxReadLength > 0, chip::Protocols::InteractionModel::Status::ResourceExhausted);
+    VerifyOrReturnValue(maxReadLength == 1 , chip::Protocols::InteractionModel::Status::ResourceExhausted);
     buffer[0] = gDishwasherModeInstance->GetCurrentMode();
 
     chip::Protocols::InteractionModel::Status ret = chip::Protocols::InteractionModel::Status::Success;

examples/chef/common/chef-dishwasher-mode-delegate-impl.h

@@ -1,6 +1,6 @@
 /*
  *
- *    Copyright (c) 2023 Project CHIP Authors
+ *    Copyright (c) 2024 Project CHIP Authors
  *    All rights reserved.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
@@ -87,4 +87,4 @@ chip::Protocols::InteractionModel::Status chefDishwasherModeWriteCallback(chip::
 chip::Protocols::InteractionModel::Status chefDishwasherModeReadCallback(chip::EndpointId endpoint, chip::ClusterId clusterId,
                                                                          const EmberAfAttributeMetadata * attributeMetadata,
                                                                          uint8_t * buffer, uint16_t maxReadLength);
-#endif
+#endif // MATTER_DM_PLUGIN_DISHWASHER_MODE_SERVER

examples/chef/common/chef-operational-state-delegate-impl.cpp

@@ -1,5 +1,5 @@
 /*
- *    Copyright (c) 2023 Project CHIP Authors
+ *    Copyright (c) 2024 Project CHIP Authors
  *    All rights reserved.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");
@@ -238,6 +238,7 @@ chip::Protocols::InteractionModel::Status chefOperationalStateWriteCallback(chip
         {
             gOperationalStateDelegate->mCountDownTime.SetNonNull(
                 static_cast<uint32_t>(gOperationalStateDelegate->kExampleCountDown));
+            (void) DeviceLayer::SystemLayer().StartTimer(System::Clock::Seconds16(1), onOperationalStateTimerTick, gOperationalStateDelegate);
         }
 
         if (CHIP_NO_ERROR == err)
@@ -302,4 +303,4 @@ void emberAfOperationalStateClusterInitCallback(chip::EndpointId endpointId)
     gOperationalStateInstance->Init();
 }
 
-#endif
+#endif  // MATTER_DM_PLUGIN_OPERATIONAL_STATE_SERVER

examples/chef/common/chef-operational-state-delegate-impl.h

@@ -1,6 +1,6 @@
 /*
  *
- *    Copyright (c) 2023 Project CHIP Authors
+ *    Copyright (c) 2024 Project CHIP Authors
  *    All rights reserved.
  *
  *    Licensed under the Apache License, Version 2.0 (the "License");

examples/chef/common/stubs.cpp

@@ -32,11 +32,11 @@
 
 #ifdef MATTER_DM_PLUGIN_DISHWASHER_MODE_SERVER
 #include "chef-dishwasher-mode-delegate-impl.h"
-#endif
+#endif  // MATTER_DM_PLUGIN_DISHWASHER_MODE_SERVER
 
 #ifdef MATTER_DM_PLUGIN_OPERATIONAL_STATE_SERVER
 #include "chef-operational-state-delegate-impl.h"
-#endif
+#endif  // MATTER_DM_PLUGIN_OPERATIONAL_STATE_SERVER
 
 using chip::app::DataModel::Nullable;
 
@@ -96,11 +96,11 @@ Protocols::InteractionModel::Status emberAfExternalAttributeReadCallback(Endpoin
 #ifdef MATTER_DM_PLUGIN_DISHWASHER_MODE_SERVER
     case chip::app::Clusters::DishwasherMode::Id:
         return chefDishwasherModeReadCallback(endpoint, clusterId, attributeMetadata, buffer, maxReadLength);
-#endif
+#endif  // MATTER_DM_PLUGIN_DISHWASHER_MODE_SERVER
 #ifdef MATTER_DM_PLUGIN_OPERATIONAL_STATE_SERVER
     case chip::app::Clusters::OperationalState::Id:
         return chefOperationalStateReadCallback(endpoint, clusterId, attributeMetadata, buffer, maxReadLength);
-#endif
+#endif  // MATTER_DM_PLUGIN_OPERATIONAL_STATE_SERVER
     default:
         break;
     }
@@ -169,11 +169,11 @@ Protocols::InteractionModel::Status emberAfExternalAttributeWriteCallback(Endpoi
 #ifdef MATTER_DM_PLUGIN_DISHWASHER_MODE_SERVER
     case chip::app::Clusters::DishwasherMode::Id:
         return chefDishwasherModeWriteCallback(endpoint, clusterId, attributeMetadata, buffer);
-#endif
+#endif  // MATTER_DM_PLUGIN_DISHWASHER_MODE_SERVER
 #ifdef MATTER_DM_PLUGIN_OPERATIONAL_STATE_SERVER
     case chip::app::Clusters::OperationalState::Id:
         return chefOperationalStateWriteCallback(endpoint, clusterId, attributeMetadata, buffer);
-#endif
+#endif  // MATTER_DM_PLUGIN_OPERATIONAL_STATE_SERVER
     default:
         break;
     }