Skip to content

Commit 9277121

Browse files
YAML script issue fix Dec 12 (#30951)
* Fixes issue: 77, 78, 79 TC-BINFO-2.1 TC-BRBINFO-2.1 TC-SC-5.1 TC-SC-5.2 * Modified OO-1.1 as per testplan ClusterRevision value to 5. * Modified BINFO-2.1 PICS * Disable the BINFO-2.1 tests in chip-repl * Fixes issue 80 and tolerance issue in CC-3.2 script. * Fixes issue 82 Modifed tests TC-CNET-4.5 TC-CNET-4.11
1 parent 1f9685f commit 9277121

File tree

13 files changed

+203
-55
lines changed

13 files changed

+203
-55
lines changed

scripts/tests/chiptest/__init__.py

+1
Original file line numberDiff line numberDiff line change
@@ -199,6 +199,7 @@ def _GetChipReplUnsupportedTests() -> Set[str]:
199199
"Test_TC_ACL_2_5.yaml", # chip-repl does not support LastReceivedEventNumber : https://github.com/project-chip/connectedhomeip/issues/28884
200200
"Test_TC_ACL_2_6.yaml", # chip-repl does not support LastReceivedEventNumber : https://github.com/project-chip/connectedhomeip/issues/28884
201201
"Test_TC_RVCCLEANM_3_3.yaml", # chip-repl does not support EqualityCommands pseudo-cluster
202+
"Test_TC_BINFO_2_1.yaml", # chip-repl does not support EqualityCommands pseudo-cluster
202203
}
203204

204205

src/app/tests/suites/certification/PICS.yaml

+6
Original file line numberDiff line numberDiff line change
@@ -2006,6 +2006,12 @@ PICS:
20062006
- label: "Does the DUT(server) support the ProductAppearance attribute?"
20072007
id: BINFO.S.A0014
20082008

2009+
- label: "Does the DUT(server) support the SpecificationVersion attribute?"
2010+
id: BINFO.S.A0015
2011+
2012+
- label: "Does the DUT(server) support the MaxPathsPerInvoke attribute?"
2013+
id: BINFO.S.A0016
2014+
20092015
#####
20102016
- label: "Does the DUT(server) support the NOC list attribute?"
20112017
id: OPCREDS.S.A0000

src/app/tests/suites/certification/Test_TC_BINFO_2_1.yaml

+84-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
14-
# Auto-generated scripts for harness use only, please review before automation. The endpoints and cluster names are currently set to default
1514

1615
name: 11.2.1. [TC-BINFO-2.1] Attributes [DUT-Server]
1716

@@ -720,3 +719,87 @@ tests:
720719
attribute: "ProductAppearance"
721720
response:
722721
value: ProductAppearancevalue
722+
723+
- label: "Step 62: TH reads SpecificationVersion from the DUT."
724+
PICS: BINFO.S.A0015
725+
command: "readAttribute"
726+
attribute: "SpecificationVersion"
727+
response:
728+
saveAs: SpecificationVersionValue
729+
730+
- label:
731+
"Step 62: If the SpecificationVersion value is absent or zero this
732+
step cannot be verified, move on to the next step"
733+
PICS: BINFO.S.A0015
734+
cluster: "EqualityCommands"
735+
command: "UnsignedNumberEquals"
736+
arguments:
737+
values:
738+
- name: "Value1"
739+
value: SpecificationVersionValue
740+
- name: "Value2"
741+
value: null
742+
response:
743+
- values:
744+
- name: "Equals"
745+
saveAs: IsExpectedValue
746+
747+
- label:
748+
"Step 62: SpecificationVersion value should in the inclusive range of
749+
(0 to 4294967295) and the initial 7 bits are set to zero."
750+
runIf: "!IsExpectedValue"
751+
PICS: BINFO.S.A0015
752+
command: "readAttribute"
753+
attribute: "SpecificationVersion"
754+
response:
755+
value: SpecificationVersionValue
756+
constraints:
757+
minValue: 0
758+
maxValue: 4294967295
759+
hasMasksClear: [0x1, 0x2, 0x4, 0x8, 0x10, 0x20, 0x40]
760+
761+
- label:
762+
"Step 63: TH sends Write request message to DUT to change the value of
763+
SpecificationVersion to '0x0103AAF1'."
764+
PICS: BINFO.S.A0015
765+
command: "writeAttribute"
766+
attribute: "SpecificationVersion"
767+
arguments:
768+
value: "0x0103AAF1"
769+
response:
770+
error: UNSUPPORTED_WRITE
771+
772+
- label: "Step 64: TH reads SpecificationVersion attribute from DUT"
773+
PICS: BINFO.S.A0015
774+
command: "readAttribute"
775+
attribute: "SpecificationVersion"
776+
response:
777+
value: SpecificationVersionValue
778+
779+
- label: "Step 65: TH reads MaxPathsPerInvoke from the DUT."
780+
PICS: BINFO.S.A0016
781+
command: "readAttribute"
782+
attribute: "MaxPathsPerInvoke"
783+
response:
784+
saveAs: MaxPathsPerInvokeValue
785+
constraints:
786+
minValue: 1
787+
maxValue: 65535
788+
789+
- label:
790+
"Step 66: TH sends Write request message to DUT to change
791+
MaxPathsPerInvoke to a different value."
792+
PICS: BINFO.S.A0016
793+
command: "writeAttribute"
794+
attribute: "MaxPathsPerInvoke"
795+
arguments:
796+
value: 12345
797+
response:
798+
error: UNSUPPORTED_WRITE
799+
800+
- label: "Step 67: TH reads MaxPathsPerInvoke attribute from DUT"
801+
PICS: BINFO.S.A0016
802+
command: "readAttribute"
803+
attribute: "MaxPathsPerInvoke"
804+
response:
805+
value: MaxPathsPerInvokeValue

src/app/tests/suites/certification/Test_TC_BRBINFO_2_1.yaml

+32
Original file line numberDiff line numberDiff line change
@@ -619,3 +619,35 @@ tests:
619619
attribute: "ProductAppearance"
620620
response:
621621
value: ProductAppearancevalue
622+
623+
- label:
624+
"Step 62: TH reads attribute ID 0x0015 from the DUT (matches in ID to
625+
CapabilityMinima in the parent cluster, but is absent on the
626+
BridgedDeviceBasicInformation cluster)."
627+
PICS: BRBINFO.S
628+
cluster: "AnyCommands"
629+
command: "ReadById"
630+
arguments:
631+
values:
632+
- name: "ClusterId"
633+
value: BRBINFO.ClusterId
634+
- name: "AttributeId"
635+
value: 0x0015
636+
response:
637+
error: UNSUPPORTED_ATTRIBUTE
638+
639+
- label:
640+
"Step 63: TH reads attribute ID 0x0016 from the DUT (matches in ID to
641+
CapabilityMinima in the parent cluster, but is absent on the
642+
BridgedDeviceBasicInformation cluster)."
643+
PICS: BRBINFO.S
644+
cluster: "AnyCommands"
645+
command: "ReadById"
646+
arguments:
647+
values:
648+
- name: "ClusterId"
649+
value: BRBINFO.ClusterId
650+
- name: "AttributeId"
651+
value: 0x0016
652+
response:
653+
error: UNSUPPORTED_ATTRIBUTE

src/app/tests/suites/certification/Test_TC_CC_3_2.yaml

+10-6
Original file line numberDiff line numberDiff line change
@@ -128,14 +128,16 @@ tests:
128128
- name: "ms"
129129
value: 10000
130130

131+
#Tolerance to be computed from the range
132+
#Start value 200, expected value 45, 200 - 45 = 155, 155 % 15 = 23 , So 45+/-23
131133
- label: "Step 2d: TH reads CurrentHue attribute from DUT"
132134
PICS: CC.S.F00 && CC.S.A0000
133135
command: "readAttribute"
134136
attribute: "CurrentHue"
135137
response:
136138
constraints:
137-
minValue: 38
138-
maxValue: 52
139+
minValue: 22
140+
maxValue: 68
139141

140142
- label: "Wait 10s"
141143
PICS: CC.S.F00
@@ -162,14 +164,16 @@ tests:
162164
- name: "OptionsOverride"
163165
value: 0
164166

167+
#Tolerance to be computed from the range
168+
#Start value 200, expected value 95, 200 - 95 = 155, 105 % 15 = 16 , So 95+/-16
165169
- label: "Step 2f: TH reads CurrentHue attribute from DUT"
166170
PICS: CC.S.F00 && CC.S.A0000
167171
command: "readAttribute"
168172
attribute: "CurrentHue"
169173
response:
170174
constraints:
171-
minValue: 80
172-
maxValue: 110
175+
minValue: 79
176+
maxValue: 111
173177

174178
- label: "Wait 2s"
175179
PICS: CC.S.F00
@@ -186,8 +190,8 @@ tests:
186190
attribute: "CurrentHue"
187191
response:
188192
constraints:
189-
minValue: 80
190-
maxValue: 110
193+
minValue: 79
194+
maxValue: 111
191195

192196
- label:
193197
"Step 3a: TH sends MoveToHue command to DUT with Hue=60,

src/app/tests/suites/certification/Test_TC_CC_3_3.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ tests:
150150

151151
#Multiple range not supported in YAML: https://github.com/project-chip/connectedhomeip/issues/23197
152152
- label: "Step 2e: TH reads CurrentHue attribute from DUT"
153-
PICS: CC.S.F00 && CC.S.A0000 PICS_SKIP_SAMPLE_APP
153+
PICS: CC.S.F00 && CC.S.A0000 && PICS_SKIP_SAMPLE_APP
154154
verification: |
155155
./chip-tool colorcontrol read current-hue 1 1
156156

src/app/tests/suites/certification/Test_TC_CNET_4_11.yaml

+2-2
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ tests:
151151
value: PIXIT.CNET.WIFI_2ND_ACCESSPOINT_SSID
152152
- name: "Credentials"
153153
value: PIXIT.CNET.WIFI_2ND_ACCESSPOINT_CREDENTIALS
154-
- name: "breadcrumb"
154+
- name: "Breadcrumb"
155155
value: 1
156156
response:
157157
values:
@@ -332,7 +332,7 @@ tests:
332332
value: PIXIT.CNET.WIFI_2ND_ACCESSPOINT_SSID
333333
- name: "Credentials"
334334
value: PIXIT.CNET.WIFI_2ND_ACCESSPOINT_CREDENTIALS
335-
- name: "breadcrumb"
335+
- name: "Breadcrumb"
336336
value: 1
337337
response:
338338
values:

src/app/tests/suites/certification/Test_TC_CNET_4_5.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ tests:
7979
value: PIXIT.CNET.WIFI_1ST_ACCESSPOINT_SSID
8080
- name: "Credentials"
8181
value: PIXIT.CNET.WIFI_1ST_ACCESSPOINT_CREDENTIALS
82-
- name: "breadcrumb"
82+
- name: "Breadcrumb"
8383
value: 1
8484
response:
8585
error: FAILSAFE_REQUIRED

src/app/tests/suites/certification/Test_TC_OO_1_1.yaml

+1-2
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,9 @@ tests:
3737
command: "readAttribute"
3838
attribute: "ClusterRevision"
3939
response:
40+
value: 5
4041
constraints:
4142
type: int16u
42-
minValue: 5
43-
maxValue: 6
4443

4544
- label: "Step 3a: TH reads from the DUT the FeatureMap attribute."
4645
command: "readAttribute"

0 commit comments

Comments
 (0)