Skip to content

Commit 95e801d

Browse files
committed
Address review comments
1 parent a60344e commit 95e801d

File tree

1 file changed

+5
-0
lines changed
  • examples/fabric-bridge-app/linux

1 file changed

+5
-0
lines changed

examples/fabric-bridge-app/linux/main.cpp

+5
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,8 @@ void AdministratorCommissioningCommandHandler::InvokeCommand(HandlerContext & ha
130130

131131
#if defined(PW_RPC_FABRIC_BRIDGE_SERVICE) && PW_RPC_FABRIC_BRIDGE_SERVICE
132132
Device * device = DeviceMgr().GetDevice(endpointId);
133+
134+
// TODO: issues:#33784, need to make OpenCommissioningWindow synchronous
133135
if (device != nullptr && OpenCommissioningWindow(device->GetNodeId()) == CHIP_NO_ERROR)
134136
{
135137
ChipLogProgress(NotSpecified, "Commissioning window is now open");
@@ -139,6 +141,9 @@ void AdministratorCommissioningCommandHandler::InvokeCommand(HandlerContext & ha
139141
status = Status::Failure;
140142
ChipLogProgress(NotSpecified, "Commissioning window is failed to open");
141143
}
144+
#else
145+
status = Status::Failure;
146+
ChipLogProgress(NotSpecified, "Commissioning window failed to open: PW_RPC_FABRIC_BRIDGE_SERVICE not defined");
142147
#endif // defined(PW_RPC_FABRIC_BRIDGE_SERVICE) && PW_RPC_FABRIC_BRIDGE_SERVICE
143148

144149
handlerContext.mCommandHandler.AddStatus(handlerContext.mRequestPath, status);

0 commit comments

Comments
 (0)