Fix clang-tidy error in PersistedCounter.h

adigie · adigie · commit 97b2ad194846 · 2025-03-03T20:35:56.000+01:00
Explicitly handle `CHIP_NO_ERROR` case in
`PersistedCounter::ReadStartValue` as clang-tidy claims that we're
returning without writing to `aStartValue`.

Signed-off-by: Adrian Gielniewski &lt;adrian.gielniewski@nordicsemi.no&gt;
diff --git a/src/lib/support/PersistedCounter.h b/src/lib/support/PersistedCounter.h
@@ -238,6 +238,11 @@ class PersistedCounter : public MonotonicallyIncreasingCounter<T>
             // Suppress the error.
             err = CHIP_NO_ERROR;
         }
+        else if (err == CHIP_NO_ERROR)
+        {
+            // Don't return on CHIP_NO_ERROR: clang-tidy claims that we're returning
+            // without writing to 'aStartValue' in else branch
+        }
         else
         {
             // TODO: Figure out how to avoid a bootloop here.  Maybe we should just

Original file line number	Diff line number	Diff line change
`@@ -238,6 +238,11 @@ class PersistedCounter : public MonotonicallyIncreasingCounter<T>`
`238`	`238`	`// Suppress the error.`
`239`	`239`	`err = CHIP_NO_ERROR;`
`240`	`240`	`}`
	`241`	`+ else if (err == CHIP_NO_ERROR)`
	`242`	`+ {`
	`243`	`+ // Don't return on CHIP_NO_ERROR: clang-tidy claims that we're returning`
	`244`	`+ // without writing to 'aStartValue' in else branch`
	`245`	`+ }`
`241`	`246`	`else`
`242`	`247`	`{`
`243`	`248`	`// TODO: Figure out how to avoid a bootloop here. Maybe we should just`