Skip to content

Commit 9b48991

Browse files
committed
Address new review comments
1 parent f43e968 commit 9b48991

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

examples/fabric-admin/commands/fabric-sync/FabricSyncCommand.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ void FabricSyncDeviceCommand::OnCommissioningWindowOpened(NodeId deviceId, CHIP_
5959
if (error == CHIP_NO_ERROR)
6060
{
6161
char command[kMaxCommandSize];
62-
NodeId nodeId = 2; // TODO: need to switch to dynamically assigned ID
62+
NodeId nodeId = 2; // TODO: (Issue #33947) need to switch to dynamically assigned ID
6363
snprintf(command, sizeof(command), "pairing code %ld %s", nodeId, payloadBuffer);
6464

6565
PairingCommand * pairingCommand = static_cast<PairingCommand *>(CommandMgr().GetCommandByName("pairing", "code"));
@@ -101,7 +101,7 @@ void FabricSyncDeviceCommand::OnCommissioningComplete(chip::NodeId deviceId, CHI
101101

102102
if (err == CHIP_NO_ERROR)
103103
{
104-
// TODO: AddSyncedDevice
104+
// TODO: (Issue #33947) Add Synced Device to device manager
105105
}
106106
else
107107
{
@@ -113,7 +113,7 @@ void FabricSyncDeviceCommand::OnCommissioningComplete(chip::NodeId deviceId, CHI
113113
CHIP_ERROR FabricSyncDeviceCommand::RunCommand(EndpointId remoteId)
114114
{
115115
char command[kMaxCommandSize];
116-
NodeId bridgeNodeId = 1; // TODO: need to switch to configured ID
116+
NodeId bridgeNodeId = 1; // TODO: (Issue #33947) need to switch to configured ID
117117
snprintf(command, sizeof(command), "pairing open-commissioning-window %ld %d %d %d %d %d", bridgeNodeId, remoteId,
118118
kEnhancedCommissioningMethod, kWindowTimeout, kIteration, kDiscriminator);
119119

0 commit comments

Comments
 (0)