Skip to content

Commit a04f478

Browse files
Fix NetworkCommissioning Cluster issues (#32156)
* Fix NetworkCommissioning Cluster issues This PR addresses several NetworkCommissioning issues which are all inter-related: - Attributes are never reported on change. - ScanNetworks used to modify attributes that should not be modified - LastNetworkStatus was not set where required - Thread network scanning did not report error on SSID field provided - All ConstraintErrors actually were reported as InvalidCommand - Lacking results of directed scanning did not report NetworkNotFound - Fixes #32024 - Fixes #32022 - Fixes #32021 - Fixes #32019 - Fixes #32018 - Fixes #31870 Testing done: - TC-CNET-4.4 pass on ESP32 and Linux - Commissioning works on ESP32 and Linux - Manual testing of all attribute changes validated with chip-repl - Automated test beyond TC-CNET-4.4 coming as a follow-up * Restyled by clang-format * Fix a Release call missing * Fix one Release too many * Apply review comments * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
1 parent de5c6d5 commit a04f478

File tree

7 files changed

+492
-55
lines changed

7 files changed

+492
-55
lines changed

examples/energy-management-app/energy-management-common/energy-management-app.matter

+1
Original file line numberDiff line numberDiff line change
@@ -1770,6 +1770,7 @@ endpoint 0 {
17701770
ram attribute lastNetworkingStatus;
17711771
ram attribute lastNetworkID;
17721772
ram attribute lastConnectErrorValue;
1773+
callback attribute supportedWiFiBands;
17731774
callback attribute generatedCommandList;
17741775
callback attribute acceptedCommandList;
17751776
callback attribute eventList;

examples/energy-management-app/energy-management-common/energy-management-app.zap

+16
Original file line numberDiff line numberDiff line change
@@ -1452,6 +1452,22 @@
14521452
"maxInterval": 65534,
14531453
"reportableChange": 0
14541454
},
1455+
{
1456+
"name": "SupportedWiFiBands",
1457+
"code": 8,
1458+
"mfgCode": null,
1459+
"side": "server",
1460+
"type": "array",
1461+
"included": 1,
1462+
"storageOption": "External",
1463+
"singleton": 0,
1464+
"bounded": 0,
1465+
"defaultValue": null,
1466+
"reportable": 1,
1467+
"minInterval": 1,
1468+
"maxInterval": 65534,
1469+
"reportableChange": 0
1470+
},
14551471
{
14561472
"name": "GeneratedCommandList",
14571473
"code": 65528,

0 commit comments

Comments
 (0)