Skip to content

Commit a2d9b97

Browse files
committedFeb 5, 2024
Address review comments
1 parent 86528ab commit a2d9b97

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed
 

‎src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ CHIP_ERROR GeneralDiagosticsAttrAccess::Read(const ConcreteReadAttributePath & a
221221
uint32_t features = 0;
222222

223223
#if CHIP_CONFIG_MAX_PATHS_PER_INVOKE > 1
224-
features |= chip::to_underlying(Clusters::GeneralDiagnostics::Feature::kDataModelTest);
224+
features |= to_underlying(Clusters::GeneralDiagnostics::Feature::kDataModelTest);
225225
#endif // CHIP_CONFIG_MAX_PATHS_PER_INVOKE > 1
226226

227227
return aEncoder.Encode(features);
@@ -455,7 +455,7 @@ bool emberAfGeneralDiagnosticsClusterPayloadTestRequestCallback(CommandHandler *
455455
// Max allowed is 2048.
456456
if (commandData.count > 2048)
457457
{
458-
commandObj->AddStatus(commandPath, Status::InvalidCommand);
458+
commandObj->AddStatus(commandPath, Status::ConstraintError);
459459
return true;
460460
}
461461

‎src/python_testing/TC_TestEventTrigger.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,8 @@ async def test_multiple_command_request_feature_present_if_needed(self):
146146
if has_data_model_test_feature:
147147
# Test count too large (above max 2048)
148148
with asserts.assert_raises_regex(InteractionModelError,
149-
"InvalidCommand",
150-
"PayloadTestRequest with request too large (> 2048) must return InvalidCommand"):
149+
"ConstraintError",
150+
"PayloadTestRequest with request too large (> 2048) must return ConstraintError"):
151151
await dev_ctrl.SendCommand(
152152
self.dut_node_id,
153153
endpoint=0,

0 commit comments

Comments
 (0)