Skip to content

Commit a531374

Browse files
committed
resolved comments
1 parent 11989d5 commit a531374

File tree

5 files changed

+164
-182
lines changed

5 files changed

+164
-182
lines changed

examples/air-quality-sensor-app/silabs/include/AirQualityConfig.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
#define VERY_POOR_THRESHOLD 250
3434

3535
// <o EXTREMELY_POOR_THRESHOLD> Extremely Poor Threshold Value
36-
// <i> Default: 2147483647
36+
// <i> Default: 300
3737
#define EXTREMELY_POOR_THRESHOLD 300
3838

3939
// <<< end of configuration section >>>

examples/air-quality-sensor-app/silabs/include/AirQualitySensorUI.h

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#include "dmd.h"
2323
#include "glib.h"
2424
#include "lcd.h"
25-
#include <CommonIcons.h>
2625

2726
class AirQualitySensorUI
2827
{

examples/air-quality-sensor-app/silabs/src/SensorManager.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ CHIP_ERROR SensorManager::Init()
102102

103103
PlatformMgr().LockChipStack();
104104
ChipLogDetail(AppServer, "Int instnace");
105-
AirQualitySensorManager::InitInstance(1);
106-
ChipLogDetail(AppServer, "Int instnace success");
105+
AirQualitySensorManager::InitInstance();
107106
PlatformMgr().UnlockChipStack();
107+
ChipLogDetail(AppServer, "Int instnace success");
108108
// Create cmsisos sw timer for air quality sensor timer.
109109
mSensorTimer = osTimerNew(SensorTimerEventHandler, osTimerPeriodic, nullptr, nullptr);
110110
if (mSensorTimer == NULL)
@@ -167,9 +167,9 @@ void SensorManager::SensorTimerEventHandler(void * arg)
167167

168168
PlatformMgr().LockChipStack();
169169
AirQualitySensorManager::GetInstance()->OnAirQualityChangeHandler(classifyAirQuality(air_quality));
170-
171-
AppTask::GetAppTask().UpdateAirQualitySensorUI();
172170
PlatformMgr().UnlockChipStack();
171+
172+
AppTask::GetAppTask().UpdateAirQualitySensorUI();
173173

174174
ChipLogDetail(AppServer, "RAW AirQuality value: %ld and corresponding Enum value : %d", air_quality,
175175
chip::to_underlying(AirQualitySensorManager::GetInstance()->GetAirQuality()));

0 commit comments

Comments
 (0)