Address review comments

Author: yufengwangca

src/app/zap-templates/zcl/data-model/chip/commissioner-control-cluster.xml

@@ -31,7 +31,10 @@ limitations under the License.
     <server init="false" tick="false">true</server>
     <description>Supports the ability for clients to request the commissioning of themselves or other nodes onto a fabric which the cluster server can commission onto.</description>
 
-    <attribute side="server" code="0x0000" define="SUPPORTED_DEVICE_CATEGORIES" type="SupportedDeviceCategoryBitmap" default="0" writable="false" optional="false">SupportedDeviceCategories</attribute>
+    <!-- cluster revision -->
+    <globalAttribute side="either" code="0xFFFD" value="1"/>
+
+    <attribute side="server" code="0x0000" define="SUPPORTED_DEVICE_CATEGORIES" type="SupportedDeviceCategoryBitmap" default="0" writable="true" optional="false">SupportedDeviceCategories</attribute>
 
     <command source="client" code="0x00" name="RequestCommissioningApproval" optional="false">
       <description>This command is sent by a client to request approval for a future CommissionNode call.</description>

src/controller/data_model/controller-clusters.matter

@@ -9136,7 +9136,7 @@ provisional cluster ContentAppObserver = 1296 {
 
 /** Supports the ability for clients to request the commissioning of themselves or other nodes onto a fabric which the cluster server can commission onto. */
 cluster CommissionerControl = 1873 {
-  revision 1; // NOTE: Default/not specifically set
+  revision 1;
 
   bitmap SupportedDeviceCategoryBitmap : bitmap32 {
     kFabricSynchronization = 0x1;
@@ -9148,7 +9148,7 @@ cluster CommissionerControl = 1873 {
     enum8 statusCode = 2;
   }
 
-  readonly attribute SupportedDeviceCategoryBitmap supportedDeviceCategories = 0;
+  attribute SupportedDeviceCategoryBitmap supportedDeviceCategories = 0;
   readonly attribute command_id generatedCommandList[] = 65528;
   readonly attribute command_id acceptedCommandList[] = 65529;
   readonly attribute event_id eventList[] = 65530;

src/controller/java/generated/java/chip/devicecontroller/ChipClusters.java

@@ -59903,6 +59903,15 @@ public void onSuccess(byte[] tlv) {
         }, SUPPORTED_DEVICE_CATEGORIES_ATTRIBUTE_ID, true);
     }
 
+    public void writeSupportedDeviceCategoriesAttribute(DefaultClusterCallback callback, Long value) {
+      writeSupportedDeviceCategoriesAttribute(callback, value, 0);
+    }
+
+    public void writeSupportedDeviceCategoriesAttribute(DefaultClusterCallback callback, Long value, int timedWriteTimeoutMs) {
+      BaseTLVType tlvValue = new UIntType(value);
+      writeAttribute(new WriteAttributesCallbackImpl(callback), SUPPORTED_DEVICE_CATEGORIES_ATTRIBUTE_ID, tlvValue, timedWriteTimeoutMs);
+    }
+
     public void subscribeSupportedDeviceCategoriesAttribute(
         LongAttributeCallback callback, int minInterval, int maxInterval) {
       ChipAttributePath path = ChipAttributePath.newInstance(endpointId, clusterId, SUPPORTED_DEVICE_CATEGORIES_ATTRIBUTE_ID);

src/controller/java/generated/java/chip/devicecontroller/ClusterWriteMapping.java

@@ -3717,6 +3717,28 @@ public Map<String, Map<String, InteractionInfo>> getWriteAttributeMap() {
     Map<String, InteractionInfo> writeContentAppObserverInteractionInfo = new LinkedHashMap<>();
     writeAttributeMap.put("contentAppObserver", writeContentAppObserverInteractionInfo);
     Map<String, InteractionInfo> writeCommissionerControlInteractionInfo = new LinkedHashMap<>();
+    Map<String, CommandParameterInfo> writeCommissionerControlSupportedDeviceCategoriesCommandParams = new LinkedHashMap<String, CommandParameterInfo>();
+    CommandParameterInfo commissionerControlsupportedDeviceCategoriesCommandParameterInfo =
+        new CommandParameterInfo(
+            "value", 
+            Long.class, 
+            Long.class 
+        );
+    writeCommissionerControlSupportedDeviceCategoriesCommandParams.put(
+        "value",
+        commissionerControlsupportedDeviceCategoriesCommandParameterInfo
+    );
+    InteractionInfo writeCommissionerControlSupportedDeviceCategoriesAttributeInteractionInfo = new InteractionInfo(
+      (cluster, callback, commandArguments) -> {
+        ((ChipClusters.CommissionerControlCluster) cluster).writeSupportedDeviceCategoriesAttribute(
+          (DefaultClusterCallback) callback,
+          (Long) commandArguments.get("value")
+        );
+      },
+      () -> new ClusterInfoMapping.DelegatedDefaultClusterCallback(),
+      writeCommissionerControlSupportedDeviceCategoriesCommandParams
+    );
+    writeCommissionerControlInteractionInfo.put("writeSupportedDeviceCategoriesAttribute", writeCommissionerControlSupportedDeviceCategoriesAttributeInteractionInfo);
     writeAttributeMap.put("commissionerControl", writeCommissionerControlInteractionInfo);
     Map<String, InteractionInfo> writeElectricalMeasurementInteractionInfo = new LinkedHashMap<>();
     Map<String, CommandParameterInfo> writeElectricalMeasurementAverageRmsVoltageMeasurementPeriodCommandParams = new LinkedHashMap<String, CommandParameterInfo>();

src/controller/java/generated/java/matter/controller/cluster/clusters/CommissionerControlCluster.kt

@@ -31,6 +31,9 @@ import matter.controller.SubscribeRequest
 import matter.controller.SubscriptionState
 import matter.controller.UIntSubscriptionState
 import matter.controller.UShortSubscriptionState
+import matter.controller.WriteRequest
+import matter.controller.WriteRequests
+import matter.controller.WriteResponse
 import matter.controller.cluster.structs.*
 import matter.controller.model.AttributePath
 import matter.controller.model.CommandPath
@@ -267,6 +270,49 @@ class CommissionerControlCluster(
     return decodedValue
   }
 
+  suspend fun writeSupportedDeviceCategoriesAttribute(
+    value: UInt,
+    timedWriteTimeout: Duration? = null,
+  ) {
+    val ATTRIBUTE_ID: UInt = 0u
+
+    val tlvWriter = TlvWriter()
+    tlvWriter.put(AnonymousTag, value)
+
+    val writeRequests: WriteRequests =
+      WriteRequests(
+        requests =
+          listOf(
+            WriteRequest(
+              attributePath =
+                AttributePath(endpointId, clusterId = CLUSTER_ID, attributeId = ATTRIBUTE_ID),
+              tlvPayload = tlvWriter.getEncoded(),
+            )
+          ),
+        timedRequest = timedWriteTimeout,
+      )
+
+    val response: WriteResponse = controller.write(writeRequests)
+
+    when (response) {
+      is WriteResponse.Success -> {
+        logger.log(Level.FINE, "Write command succeeded")
+      }
+      is WriteResponse.PartialWriteFailure -> {
+        val aggregatedErrorMessage =
+          response.failures.joinToString("\n") { failure ->
+            "Error at ${failure.attributePath}: ${failure.ex.message}"
+          }
+
+        response.failures.forEach { failure ->
+          logger.log(Level.WARNING, "Error at ${failure.attributePath}: ${failure.ex.message}")
+        }
+
+        throw IllegalStateException("Write command failed with errors: \n$aggregatedErrorMessage")
+      }
+    }
+  }
+
   suspend fun subscribeSupportedDeviceCategoriesAttribute(
     minInterval: Int,
     maxInterval: Int,