Updates as per feedback

Author: su-shanka

examples/chip-tool/commands/common/RemoteDataModelLogger.cpp

@@ -209,7 +209,7 @@ CHIP_ERROR LogDiscoveredNodeData(const chip::Dnssd::CommissionNodeData & nodeDat
     VerifyOrReturnError(gDelegate != nullptr, CHIP_NO_ERROR);
 
     auto & commissionData = nodeData;
-    auto & resolutionData = (chip::Dnssd::CommonResolutionData &) commissionData;
+    auto & resolutionData = commissionData;
 
     if (!chip::CanCastTo<uint8_t>(resolutionData.numIPs))
     {

examples/chip-tool/commands/pairing/PairingCommand.cpp

@@ -484,7 +484,7 @@ void PairingCommand::OnDiscoveredDevice(const chip::Dnssd::CommissionNodeData &
     // Ignore nodes with closed commissioning window
     VerifyOrReturn(nodeData.commissioningMode != 0);
 
-    auto & resolutionData = (chip::Dnssd::CommonResolutionData &) nodeData;
+    auto & resolutionData = nodeData;
 
     const uint16_t port = resolutionData.port;
     char buf[chip::Inet::IPAddress::kMaxStringLength];

src/controller/SetUpCodePairer.cpp

@@ -387,7 +387,7 @@ void SetUpCodePairer::NotifyCommissionableDeviceDiscovered(const Dnssd::Discover
 
     ChipLogProgress(Controller, "Discovered device to be commissioned over DNS-SD");
 
-    NotifyCommissionableDeviceDiscovered((Dnssd::CommonResolutionData &) nodeData.Get<Dnssd::CommissionNodeData>());
+    NotifyCommissionableDeviceDiscovered(nodeData.Get<Dnssd::CommissionNodeData>());
 }
 
 void SetUpCodePairer::NotifyCommissionableDeviceDiscovered(const Dnssd::CommonResolutionData & resolutionData)

src/darwin/Framework/CHIP/MTRCommissionableBrowser.mm

@@ -180,7 +180,7 @@ void OnNodeDiscovered(const DiscoveredNodeData & nodeData) override
         result.discriminator = @(commissionData.longDiscriminator);
         result.commissioningMode = commissionData.commissioningMode != 0;
 
-        auto & resolutionData = commissionData;
+        const CommonResolutionData & resolutionData = commissionData;
         auto * interfaces = result.interfaces;
         interfaces[@(resolutionData.interfaceId.GetPlatformInterface())].resolutionData = chip::MakeOptional(resolutionData);
 

src/lib/dnssd/Types.h

@@ -225,7 +225,6 @@ struct CommissionNodeData : public CommonResolutionData
 
     void Reset()
     {
-        CommonResolutionData::Reset();
         // Let constructor clear things as default
         this->~CommissionNodeData();
         new (this) CommissionNodeData();
@@ -235,7 +234,7 @@ struct CommissionNodeData : public CommonResolutionData
 
     void LogDetail() const
     {
-        ChipLogDetail(Discovery, "Discovered commissionable/commissioners node:");
+        ChipLogDetail(Discovery, "Discovered commissionable/commissioner node:");
         CommonResolutionData::LogDetail();
 
         if (rotatingIdLen > 0)