Log cluster/command names in MTRBaseDevice invoke. (#37090)

bzbarsky-apple · web-flow · commit ac7f062369d1 · 2025-01-16T22:25:35.000Z
We were doing this in MTRDevice already, but not in MTRBaseDevice.
diff --git a/src/darwin/Framework/CHIP/MTRBaseDevice.mm b/src/darwin/Framework/CHIP/MTRBaseDevice.mm
@@ -1445,7 +1445,10 @@ - (void)_invokeCommandWithEndpointID:(NSNumber *)endpointID
     }
 
     if (logCall) {
-        MTR_LOG("%@ invoke %@ 0x%llx 0x%llx: %@", self, endpointID, clusterID.unsignedLongLongValue, commandID.unsignedLongLongValue, commandFields);
+        MTR_LOG("%@ invoke %@ 0x%llx (%@) 0x%llx (%@): %@", self, endpointID,
+            clusterID.unsignedLongLongValue, MTRClusterNameForID(static_cast<MTRClusterIDType>(clusterID.unsignedLongLongValue)),
+            commandID.unsignedLongLongValue, MTRRequestCommandNameForID(static_cast<MTRClusterIDType>(clusterID.unsignedLongLongValue), static_cast<MTRCommandIDType>(commandID.unsignedLongLongValue)),
+            commandFields);
     }
 
     auto * bridge = new MTRDataValueDictionaryCallbackBridge(queue, completion,

Original file line number	Diff line number	Diff line change
`@@ -1445,7 +1445,10 @@ - (void)_invokeCommandWithEndpointID:(NSNumber *)endpointID`
`1445`	`1445`	`}`
`1446`	`1446`
`1447`	`1447`	`if (logCall) {`
`1448`		`- MTR_LOG("%@ invoke %@ 0x%llx 0x%llx: %@", self, endpointID, clusterID.unsignedLongLongValue, commandID.unsignedLongLongValue, commandFields);`
	`1448`	`+ MTR_LOG("%@ invoke %@ 0x%llx (%@) 0x%llx (%@): %@", self, endpointID,`
	`1449`	`+ clusterID.unsignedLongLongValue, MTRClusterNameForID(static_cast<MTRClusterIDType>(clusterID.unsignedLongLongValue)),`
	`1450`	`+ commandID.unsignedLongLongValue, MTRRequestCommandNameForID(static_cast<MTRClusterIDType>(clusterID.unsignedLongLongValue), static_cast<MTRCommandIDType>(commandID.unsignedLongLongValue)),`
	`1451`	`+ commandFields);`
`1449`	`1452`	`}`
`1450`	`1453`
`1451`	`1454`	`auto * bridge = new MTRDataValueDictionaryCallbackBridge(queue, completion,`