[Amazon] StopConnect for UDC in Android tv-casting-app

Updated JNI and Android tv-casting-app to use native layer
ConnectionState instead of a pendingPasscode customer check.

Changes
* Expose native layer ConnectionState to Android tv-casting-app
* Update Android tv-casting-app to use ConnectionState to determine if we
  should call stopConnect()
* Only call stopConnect() on navigate back from
  ConnectionExampleFragmnet

Test
1. Manually verified UDC attempt is successful both Android iOS for following
   1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
   2. Navigate back to discovery page
   3. Start new UDC attempt (both commissionee & commissioner generated passcode)

2. Manually verified UDC attempt is successful both Android iOS for following. UDC will finish in the background.
   1. Attempt UDC attempt (both commissionee & commissioner generated passcode)
   2. Confirm passcode on TV app or casting app depending on who
      generated passcode
   3. Navigate back before commission fnishes.

3. Manual regression test following
   * UDC attempt happy path (no navigate back) for both commissinee &
     commissioner generated passcode

Author: yuenton-amazon

examples/tv-casting-app/android/App/app/src/main/java/com/matter/casting/ConnectionExampleFragment.java

@@ -263,12 +263,11 @@ public void handle(CommissionerDeclaration cd) {
   }
 
   @Override
-  public void onDestroy() {
-    super.onDestroy();
-
-    // Only stop connection if we are pending passcode confirmation
-    // We cannot stop connection once continueConnecting() is called
-    if (targetCastingPlayer.isPendingPasscodeFromUser()) {
+  public void onStop() {
+    super.onStop();
+    // Only stop connection if we are still connecting to the device
+    if (targetCastingPlayer.getConnectionState() == CastingPlayer.ConnectionState.CONNECTING) {
+      // NOTE, once stopConnecting() is called, the targetCastingPlayer's native object is freed
       MatterError err = targetCastingPlayer.stopConnecting();
       if (err.hasError()) {
         Log.e(
@@ -352,18 +351,12 @@ public void onClick(DialogInterface dialog, int which) {
                         connectionFragmentStatusTextView.setText(
                             "Casting Player CONTINUE CONNECTING failed due to: "
                                 + finalErr
-                                + "\n\n");
+                                + ". Route back to disconnect & try again. \n\n");
                       });
               Log.e(
                   TAG,
-                  "displayPasscodeInputDialog() continueConnecting() failed, calling stopConnecting() due to: "
+                  "displayPasscodeInputDialog() continueConnecting() failed due to: "
                       + err);
-              // Since continueConnecting() failed, Attempt to cancel the connection attempt with
-              // the CastingPlayer/Commissioner.
-              err = targetCastingPlayer.stopConnecting();
-              if (err.hasError()) {
-                Log.e(TAG, "displayPasscodeInputDialog() stopConnecting() failed due to: " + err);
-              }
             }
           }
         });
@@ -375,20 +368,9 @@ public void onClick(DialogInterface dialog, int which) {
           public void onClick(DialogInterface dialog, int which) {
             Log.i(
                 TAG,
-                "displayPasscodeInputDialog() user cancelled the CastingPlayer/Commissioner-Generated Passcode input dialog. Calling stopConnecting()");
+                "displayPasscodeInputDialog() user cancelled the CastingPlayer/Commissioner-Generated Passcode input dialog");
             connectionFragmentStatusTextView.setText(
-                "Connection attempt with Casting Player cancelled by the Casting Client/Commissionee user. \n\nRoute back to exit. \n\n");
-            MatterError err = targetCastingPlayer.stopConnecting();
-            if (err.hasError()) {
-              MatterError finalErr = err;
-              getActivity()
-                  .runOnUiThread(
-                      () -> {
-                        connectionFragmentStatusTextView.setText(
-                            "Casting Player CANCEL failed due to: " + finalErr + "\n\n");
-                      });
-              Log.e(TAG, "displayPasscodeInputDialog() stopConnecting() failed due to: " + err);
-            }
+                "Connection attempt with Casting Player cancelled by the Casting Client/Commissionee user. \n\nRoute back to disconnect & exit. \n\n");
             dialog.cancel();
           }
         });

examples/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/CastingPlayer.java

@@ -29,6 +29,13 @@
  * about the service discovered/resolved.
  */
 public interface CastingPlayer {
+
+  public enum ConnectionState {
+    NOT_CONNECTED,
+    CONNECTING,
+    CONNECTED,
+  }
+
   boolean isConnected();
 
   String getDeviceId();
@@ -157,5 +164,7 @@ MatterError verifyOrEstablishConnection(
    * @return true if this CastingPlayer is still pending pass code from user and therefore is not
    *     ready
    */
-  boolean isPendingPasscodeFromUser();
+  ConnectionState getConnectionState();
+
+  String getConnectionStateNative();
 }

examples/tv-casting-app/android/App/app/src/main/jni/com/matter/casting/core/MatterCastingPlayer.java

@@ -32,6 +32,7 @@
  */
 public class MatterCastingPlayer implements CastingPlayer {
   private static final String TAG = MatterCastingPlayer.class.getSimpleName();
+
   /**
    * Time (in sec) to keep the commissioning window open, if commissioning is required. Must be >= 3
    * minutes.
@@ -269,5 +270,9 @@ public MatterError continueConnecting() {
   public native void disconnect();
 
   @Override
-  public native boolean isPendingPasscodeFromUser();
+  public ConnectionState getConnectionState() {
+      return ConnectionState.valueOf(getConnectionStateNative());
+  }
+
+  public native String getConnectionStateNative();
 }

examples/tv-casting-app/android/App/app/src/main/jni/cpp/core/MatterCastingPlayer-JNI.cpp

@@ -165,16 +165,30 @@ JNI_METHOD(void, disconnect)
     castingPlayer->Disconnect();
 }
 
-JNI_METHOD(bool, isPendingPasscodeFromUser)
+JNI_METHOD(jstring, getConnectionStateNative)
 (JNIEnv * env, jobject thiz)
 {
     chip::DeviceLayer::StackLock lock;
-    ChipLogProgress(AppServer, "MatterCastingPlayer-JNI::isPendingPasscodeFromUser()");
+    ChipLogProgress(AppServer, "MatterCastingPlayer-JNI::getConnectionState()");
 
     CastingPlayer * castingPlayer = support::convertCastingPlayerFromJavaToCpp(thiz);
-    VerifyOrReturnValue(castingPlayer != nullptr, support::convertMatterErrorFromCppToJava(CHIP_ERROR_INVALID_ARGUMENT));
+    VerifyOrReturnValue(castingPlayer != nullptr, env->NewStringUTF("Cast Player is nullptr"));
 
-    return castingPlayer->IsPendingPasscodeFromUser();
+    matter::casting::core::ConnectionState state = castingPlayer->GetConnectionState();
+    switch (state)
+    {
+    case matter::casting::core::ConnectionState::CASTING_PLAYER_NOT_CONNECTED:
+        return env->NewStringUTF("NOT_CONNECTED");
+    case matter::casting::core::ConnectionState::CASTING_PLAYER_CONNECTING:
+        return env->NewStringUTF("CONNECTING");
+    case matter::casting::core::ConnectionState::CASTING_PLAYER_CONNECTED:
+        return env->NewStringUTF("CONNECTED");
+    default: {
+        char error_str[50];
+        snprintf(error_str, sizeof(error_str), "Unsupported Connection State: %d", state);
+        return env->NewStringUTF(error_str);
+    }
+    }
 }
 
 JNI_METHOD(jobject, getEndpoints)

examples/tv-casting-app/tv-casting-common/core/CastingPlayer.h

@@ -142,14 +142,6 @@ class CastingPlayer : public std::enable_shared_from_this<CastingPlayer>
      */
     bool IsConnected() const { return mConnectionState == CASTING_PLAYER_CONNECTED; }
 
-    /**
-     * @return true if this CastingPlayer is still pending pass code from user and therefore is not ready
-     */
-    bool IsPendingPasscodeFromUser() const
-    {
-        return mConnectionState == CASTING_PLAYER_CONNECTING && !mIdOptions.mCommissionerPasscodeReady;
-    }
-
     /**
      * @brief Verifies that a connection exists with this CastingPlayer, or triggers a new commissioning session request. If the
      * CastingApp does not have the nodeId and fabricIndex of this CastingPlayer cached on disk, this will execute the User Directed