Skip to content

Commit aec50d4

Browse files
Stop talking about "pairing" in logs. (#33233)
"Pairing" means "PASE establishment" sometimes, "commissioning" sometimes. We should not use the term, and just be clearer about which process we mean so people reading logs don't get confused.
1 parent 3c9f101 commit aec50d4

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/controller/SetUpCodePairer.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ void SetUpCodePairer::OnPairingComplete(CHIP_ERROR error)
533533

534534
if (CHIP_NO_ERROR == error)
535535
{
536-
ChipLogProgress(Controller, "Pairing with commissionee successful, stopping discovery");
536+
ChipLogProgress(Controller, "PASE session established with commissionee. Stopping discovery.");
537537
ResetDiscoveryState();
538538
mRemoteId = kUndefinedNodeId;
539539
if (pairingDelegate != nullptr)

src/darwin/Framework/CHIP/MTRDeviceControllerDelegateBridge.mm

+5-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,11 @@
9393

9494
void MTRDeviceControllerDelegateBridge::OnPairingComplete(CHIP_ERROR error)
9595
{
96-
MTR_LOG_DEFAULT("DeviceControllerDelegate Pairing complete. Status %s", chip::ErrorStr(error));
96+
if (error == CHIP_NO_ERROR) {
97+
MTR_LOG_DEFAULT("MTRDeviceControllerDelegate PASE session establishment succeeded.");
98+
} else {
99+
MTR_LOG_ERROR("MTRDeviceControllerDelegate PASE session establishment failed: %" CHIP_ERROR_FORMAT, error.Format());
100+
}
97101
MATTER_LOG_METRIC_END(kMetricSetupPASESession, error);
98102

99103
id<MTRDeviceControllerDelegate> strongDelegate = mDelegate;

0 commit comments

Comments
 (0)