Skip to content

Commit b391317

Browse files
austina-csaaustina-csa
authored
Merge branch 'project-chip:master' into issue_226_temp_2
2 parents 4bf2d59 + d47c423 commit b391317

File tree

17 files changed

+275
-135
lines changed

17 files changed

+275
-135
lines changed

‎examples/all-clusters-app/infineon/psoc6/README.md

+6-4
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,11 @@ will then join the network.
3030

3131
## Building
3232

33-
- [Modustoolbox Software](https://www.cypress.com/products/modustoolbox)
33+
- Download and install
34+
[Modustoolbox Software v3.2](https://www.infineon.com/modustoolbox)
3435

35-
Refer to `integrations/docker/images/chip-build-infineon/Dockerfile` or
36-
`scripts/examples/gn_psoc6_example.sh` for downloading the Software and
36+
Refer to `integrations/docker/images/stage-2/chip-build-infineon/Dockerfile`
37+
or `scripts/examples/gn_psoc6_example.sh` for downloading the Software and
3738
related tools.
3839

3940
- Install some additional tools (likely already present for Matter
@@ -62,11 +63,12 @@ will then join the network.
6263
6364
- Put CY8CKIT-062S2-43012 board on KitProg3 CMSIS-DAP Mode by pressing the
6465
`MODE SELECT` button. `KITPROG3 STATUS` LED is ON confirms board is in
65-
proper mode.
66+
proper mode. (Modustoolbox Software needs to be installed)
6667
6768
- On the command line:
6869
6970
$ cd ~/connectedhomeip
71+
$ export CY_TOOLS_PATHS=<Modustoolbox install location>/tools_3.2
7072
$ python3 out/infineon-psoc6-all-clusters/chip-psoc6-clusters-example.flash.py
7173
7274
## Commissioning and cluster control

‎examples/all-clusters-minimal-app/infineon/psoc6/README.md

+6-4
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,11 @@ will then join the network.
3030

3131
## Building
3232

33-
- [Modustoolbox Software](https://www.cypress.com/products/modustoolbox)
33+
- Download and install
34+
[Modustoolbox Software v3.2](https://www.infineon.com/modustoolbox)
3435

35-
Refer to `integrations/docker/images/chip-build-infineon/Dockerfile` or
36-
`scripts/examples/gn_psoc6_example.sh` for downloading the Software and
36+
Refer to `integrations/docker/images/stage-2/chip-build-infineon/Dockerfile`
37+
or `scripts/examples/gn_psoc6_example.sh` for downloading the Software and
3738
related tools.
3839

3940
- Install some additional tools (likely already present for Matter
@@ -62,11 +63,12 @@ will then join the network.
6263
6364
- Put CY8CKIT-062S2-43012 board on KitProg3 CMSIS-DAP Mode by pressing the
6465
`MODE SELECT` button. `KITPROG3 STATUS` LED is ON confirms board is in
65-
proper mode.
66+
proper mode. (Modustoolbox Software needs to be installed)
6667
6768
- On the command line:
6869
6970
$ cd ~/connectedhomeip
71+
$ export CY_TOOLS_PATHS=<Modustoolbox install location>/tools_3.2
7072
$ python3 out/infineon-psoc6-all-clusters-minimal/chip-psoc6-clusters-minimal-example.flash.py
7173
7274
## Commissioning and cluster control

‎examples/fabric-bridge-app/fabric-bridge-common/BUILD.gn

+15-1
Original file line numberDiff line numberDiff line change
@@ -19,20 +19,34 @@ config("config") {
1919
include_dirs = [ "include" ]
2020
}
2121

22-
chip_data_model("fabric-bridge-common") {
22+
chip_data_model("fabric-bridge-common-zap") {
2323
zap_file = "fabric-bridge-app.zap"
2424
is_server = true
2525
cflags = [ "-DDYNAMIC_ENDPOINT_COUNT=16" ]
2626
}
2727

28+
# This includes all the clusters that only exist on the dynamic endpoint.
29+
source_set("fabric-bridge-common") {
30+
public_configs = [ ":config" ]
31+
32+
sources = [
33+
"${chip_root}/src/app/clusters/ecosystem-information-server/ecosystem-information-server.cpp",
34+
"${chip_root}/src/app/clusters/ecosystem-information-server/ecosystem-information-server.h",
35+
]
36+
37+
public_deps = [ ":fabric-bridge-common-zap" ]
38+
}
39+
2840
source_set("fabric-bridge-lib") {
2941
public_configs = [ ":config" ]
3042

3143
sources = [
3244
"include/BridgedDevice.h",
45+
"include/BridgedDeviceBasicInformationImpl.h",
3346
"include/BridgedDeviceManager.h",
3447
"include/CHIPProjectAppConfig.h",
3548
"src/BridgedDevice.cpp",
49+
"src/BridgedDeviceBasicInformationImpl.cpp",
3650
"src/BridgedDeviceManager.cpp",
3751
"src/ZCLCallbacks.cpp",
3852
]

‎examples/fabric-bridge-app/fabric-bridge-common/include/BridgedDeviceBasicInformationImpl.h

+32
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
/*
2+
* Copyright (c) 2024 Project CHIP Authors
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
#pragma once
17+
18+
#include <app-common/zap-generated/ids/Clusters.h>
19+
#include <app/AttributeAccessInterface.h>
20+
21+
class BridgedDeviceBasicInformationImpl : public chip::app::AttributeAccessInterface
22+
{
23+
public:
24+
BridgedDeviceBasicInformationImpl() :
25+
chip::app::AttributeAccessInterface(chip::NullOptional /* endpointId */,
26+
chip::app::Clusters::BridgedDeviceBasicInformation::Id)
27+
{}
28+
29+
// AttributeAccessInterface implementation
30+
CHIP_ERROR Read(const chip::app::ConcreteReadAttributePath & path, chip::app::AttributeValueEncoder & encoder) override;
31+
CHIP_ERROR Write(const chip::app::ConcreteDataAttributePath & path, chip::app::AttributeValueDecoder & decoder) override;
32+
};

‎examples/fabric-bridge-app/fabric-bridge-common/src/BridgedDeviceBasicInformationImpl.cpp

+78
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
1+
/*
2+
* Copyright (c) 2024 Project CHIP Authors
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License");
5+
* you may not use this file except in compliance with the License.
6+
* You may obtain a copy of the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS,
12+
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13+
* See the License for the specific language governing permissions and
14+
* limitations under the License.
15+
*/
16+
#include "BridgedDeviceBasicInformationImpl.h"
17+
18+
#include "BridgedDeviceManager.h"
19+
20+
#include <app-common/zap-generated/cluster-objects.h>
21+
#include <app-common/zap-generated/ids/Attributes.h>
22+
#include <app-common/zap-generated/ids/Clusters.h>
23+
24+
#include <app/AttributeAccessInterfaceRegistry.h>
25+
26+
static constexpr unsigned kBridgedDeviceBasicInformationClusterRevision = 4;
27+
static constexpr unsigned kBridgedDeviceBasicInformationFeatureMap = 0;
28+
29+
using namespace ::chip;
30+
using namespace ::chip::app;
31+
using namespace ::chip::app::Clusters;
32+
33+
CHIP_ERROR BridgedDeviceBasicInformationImpl::Read(const ConcreteReadAttributePath & path, AttributeValueEncoder & encoder)
34+
{
35+
// Registration is done for the bridged device basic information only
36+
VerifyOrDie(path.mClusterId == app::Clusters::BridgedDeviceBasicInformation::Id);
37+
38+
BridgedDevice * dev = BridgeDeviceMgr().GetDevice(path.mEndpointId);
39+
VerifyOrReturnError(dev != nullptr, CHIP_ERROR_NOT_FOUND);
40+
41+
switch (path.mAttributeId)
42+
{
43+
case BasicInformation::Attributes::Reachable::Id:
44+
encoder.Encode(dev->IsReachable());
45+
break;
46+
case BasicInformation::Attributes::NodeLabel::Id:
47+
encoder.Encode(CharSpan::fromCharString(dev->GetName()));
48+
break;
49+
case BasicInformation::Attributes::ClusterRevision::Id:
50+
encoder.Encode(kBridgedDeviceBasicInformationClusterRevision);
51+
break;
52+
case BasicInformation::Attributes::FeatureMap::Id:
53+
encoder.Encode(kBridgedDeviceBasicInformationFeatureMap);
54+
break;
55+
default:
56+
return CHIP_ERROR_INVALID_ARGUMENT;
57+
}
58+
return CHIP_NO_ERROR;
59+
}
60+
61+
CHIP_ERROR BridgedDeviceBasicInformationImpl::Write(const ConcreteDataAttributePath & path, AttributeValueDecoder & decoder)
62+
{
63+
VerifyOrDie(path.mClusterId == app::Clusters::BridgedDeviceBasicInformation::Id);
64+
65+
BridgedDevice * dev = BridgeDeviceMgr().GetDevice(path.mEndpointId);
66+
VerifyOrReturnError(dev != nullptr, CHIP_ERROR_NOT_FOUND);
67+
68+
if (!dev->IsReachable())
69+
{
70+
return CHIP_ERROR_NOT_CONNECTED;
71+
}
72+
73+
ChipLogProgress(NotSpecified, "Bridged device basic information attempt to write attribute: ep=%d", path.mAttributeId);
74+
75+
// nothing writable right now ...
76+
77+
return CHIP_ERROR_INVALID_ARGUMENT;
78+
}

‎examples/fabric-bridge-app/fabric-bridge-common/src/BridgedDeviceManager.cpp

+44-14
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,13 @@ using namespace chip::app::Clusters;
4545

4646
namespace {
4747

48-
constexpr uint8_t kMaxRetries = 10;
49-
constexpr int kNodeLabelSize = 32;
48+
constexpr uint8_t kMaxRetries = 10;
49+
constexpr int kNodeLabelSize = 32;
50+
constexpr int kUniqueIdSize = 32;
51+
constexpr int kVendorNameSize = 32;
52+
constexpr int kProductNameSize = 32;
53+
constexpr int kHardwareVersionSize = 32;
54+
constexpr int kSoftwareVersionSize = 32;
5055

5156
// Current ZCL implementation of Struct uses a max-size array of 254 bytes
5257
constexpr int kDescriptorAttributeArraySize = 254;
@@ -76,27 +81,51 @@ constexpr int kDescriptorAttributeArraySize = 254;
7681
// - Bridged Device Basic Information
7782
// - Administrator Commissioning
7883

84+
// clang-format off
7985
// Declare Descriptor cluster attributes
8086
DECLARE_DYNAMIC_ATTRIBUTE_LIST_BEGIN(descriptorAttrs)
81-
DECLARE_DYNAMIC_ATTRIBUTE(Descriptor::Attributes::DeviceTypeList::Id, ARRAY, kDescriptorAttributeArraySize, 0), /* device list */
82-
DECLARE_DYNAMIC_ATTRIBUTE(Descriptor::Attributes::ServerList::Id, ARRAY, kDescriptorAttributeArraySize, 0), /* server list */
83-
DECLARE_DYNAMIC_ATTRIBUTE(Descriptor::Attributes::ClientList::Id, ARRAY, kDescriptorAttributeArraySize, 0), /* client list */
84-
DECLARE_DYNAMIC_ATTRIBUTE(Descriptor::Attributes::PartsList::Id, ARRAY, kDescriptorAttributeArraySize, 0), /* parts list */
85-
DECLARE_DYNAMIC_ATTRIBUTE_LIST_END();
87+
DECLARE_DYNAMIC_ATTRIBUTE(Descriptor::Attributes::DeviceTypeList::Id, ARRAY, kDescriptorAttributeArraySize, 0), /* device list */
88+
DECLARE_DYNAMIC_ATTRIBUTE(Descriptor::Attributes::ServerList::Id, ARRAY, kDescriptorAttributeArraySize, 0), /* server list */
89+
DECLARE_DYNAMIC_ATTRIBUTE(Descriptor::Attributes::ClientList::Id, ARRAY, kDescriptorAttributeArraySize, 0), /* client list */
90+
DECLARE_DYNAMIC_ATTRIBUTE(Descriptor::Attributes::PartsList::Id, ARRAY, kDescriptorAttributeArraySize, 0), /* parts list */
91+
DECLARE_DYNAMIC_ATTRIBUTE_LIST_END();
8692

8793
// Declare Bridged Device Basic Information cluster attributes
8894
DECLARE_DYNAMIC_ATTRIBUTE_LIST_BEGIN(bridgedDeviceBasicAttrs)
89-
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::NodeLabel::Id, CHAR_STRING, kNodeLabelSize, 0), /* NodeLabel */
90-
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::Reachable::Id, BOOLEAN, 1, 0), /* Reachable */
91-
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::FeatureMap::Id, BITMAP32, 4, 0), /* feature map */
95+
// The attributes below are MANDATORY in the Bridged Device Information Cluster
96+
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::Reachable::Id, BOOLEAN, 1, 0),
97+
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::UniqueID::Id, CHAR_STRING, kUniqueIdSize, 0),
98+
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::FeatureMap::Id, BITMAP32, 4, 0),
99+
100+
// The attributes below are OPTIONAL in the bridged device, however they are MANDATORY in the BasicInformation cluster
101+
// so they can always be provided if desired
102+
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::VendorName::Id, CHAR_STRING, kVendorNameSize, 0),
103+
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::VendorID::Id, INT16U, 2, 0),
104+
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::ProductName::Id, CHAR_STRING, kProductNameSize, 0),
105+
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::ProductID::Id, INT16U, 2, 0),
106+
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::NodeLabel::Id, CHAR_STRING, kNodeLabelSize, 0),
107+
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::HardwareVersion::Id, INT16U, 2, 0),
108+
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::HardwareVersionString::Id, CHAR_STRING,
109+
kHardwareVersionSize, 0),
110+
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::SoftwareVersion::Id, INT32U, 4, 0),
111+
DECLARE_DYNAMIC_ATTRIBUTE(BridgedDeviceBasicInformation::Attributes::SoftwareVersionString::Id, CHAR_STRING,
112+
kSoftwareVersionSize, 0),
113+
DECLARE_DYNAMIC_ATTRIBUTE_LIST_END();
114+
115+
// Declare Ecosystem Information cluster attributes
116+
DECLARE_DYNAMIC_ATTRIBUTE_LIST_BEGIN(ecosystemInformationBasicAttrs)
117+
DECLARE_DYNAMIC_ATTRIBUTE(EcosystemInformation::Attributes::RemovedOn::Id, EPOCH_US, kNodeLabelSize, ATTRIBUTE_MASK_NULLABLE),
118+
DECLARE_DYNAMIC_ATTRIBUTE(EcosystemInformation::Attributes::DeviceDirectory::Id, ARRAY, kDescriptorAttributeArraySize, 0),
119+
DECLARE_DYNAMIC_ATTRIBUTE(EcosystemInformation::Attributes::LocationDirectory::Id, ARRAY, kDescriptorAttributeArraySize, 0),
92120
DECLARE_DYNAMIC_ATTRIBUTE_LIST_END();
93121

94122
// Declare Administrator Commissioning cluster attributes
95123
DECLARE_DYNAMIC_ATTRIBUTE_LIST_BEGIN(AdministratorCommissioningAttrs)
96-
DECLARE_DYNAMIC_ATTRIBUTE(AdministratorCommissioning::Attributes::WindowStatus::Id, ENUM8, 1, 0), /* NodeLabel */
97-
DECLARE_DYNAMIC_ATTRIBUTE(AdministratorCommissioning::Attributes::AdminFabricIndex::Id, FABRIC_IDX, 1, 0), /* Reachable */
98-
DECLARE_DYNAMIC_ATTRIBUTE(AdministratorCommissioning::Attributes::AdminVendorId::Id, VENDOR_ID, 2, 0), /* Reachable */
99-
DECLARE_DYNAMIC_ATTRIBUTE_LIST_END();
124+
DECLARE_DYNAMIC_ATTRIBUTE(AdministratorCommissioning::Attributes::WindowStatus::Id, ENUM8, 1, 0),
125+
DECLARE_DYNAMIC_ATTRIBUTE(AdministratorCommissioning::Attributes::AdminFabricIndex::Id, FABRIC_IDX, 1, 0),
126+
DECLARE_DYNAMIC_ATTRIBUTE(AdministratorCommissioning::Attributes::AdminVendorId::Id, VENDOR_ID, 2, 0),
127+
DECLARE_DYNAMIC_ATTRIBUTE_LIST_END();
128+
// clang-format on
100129

101130
constexpr CommandId administratorCommissioningCommands[] = {
102131
app::Clusters::AdministratorCommissioning::Commands::OpenCommissioningWindow::Id,
@@ -109,6 +138,7 @@ constexpr CommandId administratorCommissioningCommands[] = {
109138
DECLARE_DYNAMIC_CLUSTER_LIST_BEGIN(bridgedNodeClusters)
110139
DECLARE_DYNAMIC_CLUSTER(Descriptor::Id, descriptorAttrs, ZAP_CLUSTER_MASK(SERVER), nullptr, nullptr),
111140
DECLARE_DYNAMIC_CLUSTER(BridgedDeviceBasicInformation::Id, bridgedDeviceBasicAttrs, ZAP_CLUSTER_MASK(SERVER), nullptr, nullptr),
141+
DECLARE_DYNAMIC_CLUSTER(EcosystemInformation::Id, ecosystemInformationBasicAttrs, ZAP_CLUSTER_MASK(SERVER), nullptr, nullptr),
112142
DECLARE_DYNAMIC_CLUSTER(AdministratorCommissioning::Id, AdministratorCommissioningAttrs, ZAP_CLUSTER_MASK(SERVER),
113143
administratorCommissioningCommands, nullptr) DECLARE_DYNAMIC_CLUSTER_LIST_END;
114144

‎examples/fabric-bridge-app/fabric-bridge-common/src/ZCLCallbacks.cpp

+1-63
Original file line numberDiff line numberDiff line change
@@ -25,88 +25,26 @@
2525
using namespace ::chip;
2626
using namespace ::chip::app::Clusters;
2727

28-
#define ZCL_DESCRIPTOR_CLUSTER_REVISION (1u)
2928
#define ZCL_ADMINISTRATOR_COMMISSIONING_CLUSTER_REVISION (1u)
30-
#define ZCL_BRIDGED_DEVICE_BASIC_INFORMATION_CLUSTER_REVISION (2u)
31-
#define ZCL_BRIDGED_DEVICE_BASIC_INFORMATION_FEATURE_MAP (0u)
3229

3330
// External attribute read callback function
3431
Protocols::InteractionModel::Status emberAfExternalAttributeReadCallback(EndpointId endpoint, ClusterId clusterId,
3532
const EmberAfAttributeMetadata * attributeMetadata,
3633
uint8_t * buffer, uint16_t maxReadLength)
3734
{
38-
AttributeId attributeId = attributeMetadata->attributeId;
39-
40-
BridgedDevice * dev = BridgeDeviceMgr().GetDevice(endpoint);
41-
if (dev == nullptr)
42-
{
43-
return Protocols::InteractionModel::Status::Failure;
44-
}
45-
46-
if (clusterId == BridgedDeviceBasicInformation::Id)
47-
{
48-
using namespace BridgedDeviceBasicInformation::Attributes;
49-
ChipLogProgress(NotSpecified, "HandleReadBridgedDeviceBasicAttribute: attrId=%d, maxReadLength=%d", attributeId,
50-
maxReadLength);
51-
52-
if ((attributeId == Reachable::Id) && (maxReadLength == 1))
53-
{
54-
*buffer = dev->IsReachable() ? 1 : 0;
55-
}
56-
else if ((attributeId == NodeLabel::Id) && (maxReadLength == 32))
57-
{
58-
MutableByteSpan zclNameSpan(buffer, maxReadLength);
59-
MakeZclCharString(zclNameSpan, dev->GetName());
60-
}
61-
else if ((attributeId == ClusterRevision::Id) && (maxReadLength == 2))
62-
{
63-
uint16_t rev = ZCL_BRIDGED_DEVICE_BASIC_INFORMATION_CLUSTER_REVISION;
64-
memcpy(buffer, &rev, sizeof(rev));
65-
}
66-
else if ((attributeId == FeatureMap::Id) && (maxReadLength == 4))
67-
{
68-
uint32_t featureMap = ZCL_BRIDGED_DEVICE_BASIC_INFORMATION_FEATURE_MAP;
69-
memcpy(buffer, &featureMap, sizeof(featureMap));
70-
}
71-
else
72-
{
73-
return Protocols::InteractionModel::Status::Failure;
74-
}
75-
return Protocols::InteractionModel::Status::Success;
76-
}
77-
7835
if (clusterId == AdministratorCommissioning::Id)
7936
{
8037
// TODO(#34791) This is a workaround to prevent crash. CADMIN is still reading incorrect
8138
// Attribute values on dynamic endpoint as it only reads the root node and not the actual bridge
8239
// device we are representing here, when addressing the issue over there we can more easily
8340
// resolve this workaround.
84-
if ((attributeId == AdministratorCommissioning::Attributes::ClusterRevision::Id) && (maxReadLength == 2))
41+
if ((attributeMetadata->attributeId == AdministratorCommissioning::Attributes::ClusterRevision::Id) && (maxReadLength == 2))
8542
{
8643
uint16_t rev = ZCL_ADMINISTRATOR_COMMISSIONING_CLUSTER_REVISION;
8744
memcpy(buffer, &rev, sizeof(rev));
8845
return Protocols::InteractionModel::Status::Success;
8946
}
90-
return Protocols::InteractionModel::Status::Failure;
9147
}
9248

9349
return Protocols::InteractionModel::Status::Failure;
9450
}
95-
96-
// External attribute write callback function
97-
Protocols::InteractionModel::Status emberAfExternalAttributeWriteCallback(EndpointId endpoint, ClusterId clusterId,
98-
const EmberAfAttributeMetadata * attributeMetadata,
99-
uint8_t * buffer)
100-
{
101-
uint16_t endpointIndex = emberAfGetDynamicIndexFromEndpoint(endpoint);
102-
Protocols::InteractionModel::Status ret = Protocols::InteractionModel::Status::Failure;
103-
104-
BridgedDevice * dev = BridgeDeviceMgr().GetDevice(endpointIndex);
105-
if (dev != nullptr && dev->IsReachable())
106-
{
107-
ChipLogProgress(NotSpecified, "emberAfExternalAttributeWriteCallback: ep=%d, clusterId=%d", endpoint, clusterId);
108-
ret = Protocols::InteractionModel::Status::Success;
109-
}
110-
111-
return ret;
112-
}

0 commit comments

Comments
 (0)