Skip to content

Commit b5dfe72

Browse files
authored
RVC: Fix conformance (#30600)
- admin commissioning doesn't have the BCW feature, but had the command on - turned off command - Identify cluster revision is now 4. It already included the v4 attribute, it was just the revision that was incorrect.
1 parent ac1536d commit b5dfe72

File tree

2 files changed

+2
-16
lines changed

2 files changed

+2
-16
lines changed

examples/rvc-app/rvc-common/rvc-app.matter

+1-7
Original file line numberDiff line numberDiff line change
@@ -664,12 +664,7 @@ server cluster AdministratorCommissioning = 60 {
664664
octet_string<32> salt = 4;
665665
}
666666

667-
request struct OpenBasicCommissioningWindowRequest {
668-
int16u commissioningTimeout = 0;
669-
}
670-
671667
timed command access(invoke: administer) OpenCommissioningWindow(OpenCommissioningWindowRequest): DefaultSuccess = 0;
672-
timed command access(invoke: administer) OpenBasicCommissioningWindow(OpenBasicCommissioningWindowRequest): DefaultSuccess = 1;
673668
timed command access(invoke: administer) RevokeCommissioning(): DefaultSuccess = 2;
674669
}
675670

@@ -1162,7 +1157,6 @@ endpoint 0 {
11621157
ram attribute clusterRevision default = 0x0001;
11631158

11641159
handle command OpenCommissioningWindow;
1165-
handle command OpenBasicCommissioningWindow;
11661160
handle command RevokeCommissioning;
11671161
}
11681162

@@ -1218,7 +1212,7 @@ endpoint 1 {
12181212
callback attribute eventList;
12191213
callback attribute attributeList default = 0;
12201214
ram attribute featureMap default = 0;
1221-
ram attribute clusterRevision default = 2;
1215+
ram attribute clusterRevision default = 4;
12221216

12231217
handle command Identify;
12241218
handle command TriggerEffect;

examples/rvc-app/rvc-common/rvc-app.zap

+1-9
Original file line numberDiff line numberDiff line change
@@ -1426,14 +1426,6 @@
14261426
"isIncoming": 1,
14271427
"isEnabled": 1
14281428
},
1429-
{
1430-
"name": "OpenBasicCommissioningWindow",
1431-
"code": 1,
1432-
"mfgCode": null,
1433-
"source": "client",
1434-
"isIncoming": 1,
1435-
"isEnabled": 1
1436-
},
14371429
{
14381430
"name": "RevokeCommissioning",
14391431
"code": 2,
@@ -2095,7 +2087,7 @@
20952087
"storageOption": "RAM",
20962088
"singleton": 0,
20972089
"bounded": 0,
2098-
"defaultValue": "2",
2090+
"defaultValue": "4",
20992091
"reportable": 1,
21002092
"minInterval": 1,
21012093
"maxInterval": 65534,

0 commit comments

Comments
 (0)