Don't stringify PeerAddress in SendPreparedMessage if not logging it. (#32821)

bzbarsky-apple · web-flow · commit b79831ed9324 · 2024-04-02T22:06:20.000Z
diff --git a/src/transport/SessionManager.cpp b/src/transport/SessionManager.cpp
@@ -448,10 +448,10 @@ CHIP_ERROR SessionManager::SendPreparedMessage(const SessionHandle & sessionHand
     {
         CHIP_ERROR err = mTransportMgr->SendMessage(*destination, std::move(msgBuf));
 #if CHIP_ERROR_LOGGING
-        char addressStr[Transport::PeerAddress::kMaxToStringSize] = { 0 };
-        destination->ToString(addressStr);
         if (err != CHIP_NO_ERROR)
         {
+            char addressStr[Transport::PeerAddress::kMaxToStringSize] = { 0 };
+            destination->ToString(addressStr);
             ChipLogError(Inet, "SendMessage() to %s failed: %" CHIP_ERROR_FORMAT, addressStr, err.Format());
         }
 #endif // CHIP_ERROR_LOGGING

Original file line number	Diff line number	Diff line change
`@@ -448,10 +448,10 @@ CHIP_ERROR SessionManager::SendPreparedMessage(const SessionHandle & sessionHand`
`448`	`448`	`{`
`449`	`449`	`CHIP_ERROR err = mTransportMgr->SendMessage(*destination, std::move(msgBuf));`
`450`	`450`	`#if CHIP_ERROR_LOGGING`
`451`		`- char addressStr[Transport::PeerAddress::kMaxToStringSize] = { 0 };`
`452`		`- destination->ToString(addressStr);`
`453`	`451`	`if (err != CHIP_NO_ERROR)`
`454`	`452`	`{`
	`453`	`+ char addressStr[Transport::PeerAddress::kMaxToStringSize] = { 0 };`
	`454`	`+ destination->ToString(addressStr);`
`455`	`455`	`ChipLogError(Inet, "SendMessage() to %s failed: %" CHIP_ERROR_FORMAT, addressStr, err.Format());`
`456`	`456`	`}`
`457`	`457`	`#endif // CHIP_ERROR_LOGGING`