Stop holding a reference into a temporary. (#24373)

bzbarsky-apple · web-flow · commit bd94d060c365 · 2023-01-12T09:07:10.000-05:00
This was drive-by fixed on tip by #23827 but we should fix on 1.0 too. Fixes #24367
diff --git a/src/controller/AutoCommissioner.cpp b/src/controller/AutoCommissioner.cpp
@@ -100,7 +100,7 @@ CHIP_ERROR AutoCommissioner::SetCommissioningParameters(const CommissioningParam
 
     if (params.GetCountryCode().HasValue())
     {
-        auto & code = params.GetCountryCode().Value();
+        auto code = params.GetCountryCode().Value();
         MutableCharSpan copiedCode(mCountryCode);
         if (CopyCharSpanToMutableCharSpan(code, copiedCode) == CHIP_NO_ERROR)
         {

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ CHIP_ERROR AutoCommissioner::SetCommissioningParameters(const CommissioningParam`
`100`	`100`
`101`	`101`	`if (params.GetCountryCode().HasValue())`
`102`	`102`	`{`
`103`		`- auto & code = params.GetCountryCode().Value();`
	`103`	`+ auto code = params.GetCountryCode().Value();`
`104`	`104`	`MutableCharSpan copiedCode(mCountryCode);`
`105`	`105`	`if (CopyCharSpanToMutableCharSpan(code, copiedCode) == CHIP_NO_ERROR)`
`106`	`106`	`{`