[Linux] Add test logic to verify commissioning between Linux tv-casting-app and Linux tv-app. (#33301)

Author: shaoltan-amazon

scripts/tests/run_tv_casting_test.py

@@ -20,7 +20,7 @@
 import sys
 import tempfile
 import time
-from typing import List, Optional, TextIO, Tuple
+from typing import List, Optional, TextIO, Tuple, Union
 
 import click
 
@@ -30,6 +30,9 @@
 # The maximum amount of time to wait for the Linux tv-app to start before timeout.
 TV_APP_MAX_START_WAIT_SEC = 2
 
+# The maximum amount of time to commission the Linux tv-casting-app and the tv-app before timeout.
+COMMISSIONING_STAGE_MAX_WAIT_SEC = 10
+
 # File names of logs for the Linux tv-casting-app and the Linux tv-app.
 LINUX_TV_APP_LOGS = 'Linux-tv-app-logs.txt'
 LINUX_TV_CASTING_APP_LOGS = 'Linux-tv-casting-app-logs.txt'
@@ -47,13 +50,14 @@ class ProcessManager:
     This class provides a context manager for safely starting and stopping a subprocess.
     """
 
-    def __init__(self, command: List[str], stdout, stderr):
+    def __init__(self, command: List[str], stdin, stdout, stderr):
         self.command = command
+        self.stdin = stdin
         self.stdout = stdout
         self.stderr = stderr
 
     def __enter__(self):
-        self.process = subprocess.Popen(self.command, stdout=self.stdout, stderr=self.stderr, text=True)
+        self.process = subprocess.Popen(self.command, stdin=self.stdin, stdout=self.stdout, stderr=self.stderr, text=True)
         return self.process
 
     def __exit__(self, exception_type, exception_value, traceback):
@@ -71,9 +75,9 @@ def dump_temporary_logs_to_console(log_file_path: str):
             print(line.rstrip())
 
 
-def handle_discovery_failure(log_file_paths: List[str]):
-    """Log 'Discovery failed!' as error, dump log files to console, exit on error."""
-    logging.error('Discovery failed!')
+def handle_casting_failure(casting_state: str, log_file_paths: List[str]):
+    """Log '{casting_state} failed!' as error, dump log files to console, exit on error."""
+    logging.error(casting_state + ' failed!')
 
     for log_file_path in log_file_paths:
         try:
@@ -84,30 +88,34 @@ def handle_discovery_failure(log_file_paths: List[str]):
     sys.exit(1)
 
 
-def extract_value_from_string(line: str) -> int:
-    """Extract and return integer value from given output string.
+def extract_value_from_string(line: str) -> str:
+    """Extract and return value from given input string.
 
     The string is expected to be in the following format as it is received
     from the Linux tv-casting-app output:
     \x1b[0;34m[1713741926895] [7276:9521344] [DIS] Vendor ID: 65521\x1b[0m
     The integer value to be extracted here is 65521.
+    Or:
+    \x1b[0;34m[1714583616179] [7029:2386956] [SVR] 	device Name: Test TV casting app\x1b[0m
+    The substring to be extracted here is 'Test TV casting app'.
     """
     value = line.split(':')[-1].strip().replace('\x1b[0m', '')
-    value = int(value)
 
     return value
 
 
-def validate_value(expected_value: int, log_paths: List[str], line: str, value_name: str) -> Optional[str]:
-    """Validate a value in a string against an expected value."""
+def validate_value(casting_state: str, expected_value: Union[str, int], log_paths: List[str], line: str, value_name: str) -> Optional[str]:
+    """Validate a value in a string against an expected value during a given casting state."""
     value = extract_value_from_string(line)
 
+    if isinstance(expected_value, int):
+        value = int(value)
+
     if value != expected_value:
         logging.error(f'{value_name} does not match the expected value!')
         logging.error(f'Expected {value_name}: {expected_value}')
         logging.error(line.rstrip('\n'))
-        handle_discovery_failure(log_paths)
-        return None
+        handle_casting_failure(casting_state, log_paths)
 
     # Return the line containing the valid value.
     return line.rstrip('\n')
@@ -120,7 +128,7 @@ def start_up_tv_app_success(tv_app_process: subprocess.Popen, linux_tv_app_log_f
     while True:
         # Check if the time elapsed since the start wait time exceeds the maximum allowed startup time for the TV app.
         if time.time() - start_wait_time > TV_APP_MAX_START_WAIT_SEC:
-            logging.error("The Linux tv-app process did not start successfully within the timeout.")
+            logging.error('The Linux tv-app process did not start successfully within the timeout.')
             return False
 
         tv_app_output_line = tv_app_process.stdout.readline()
@@ -134,7 +142,172 @@ def start_up_tv_app_success(tv_app_process: subprocess.Popen, linux_tv_app_log_f
             return True
 
 
-def parse_output_for_valid_commissioner(tv_casting_app_info: Tuple[subprocess.Popen, TextIO], log_paths: List[str]):
+def initiate_cast_request_success(tv_casting_app_info: Tuple[subprocess.Popen, TextIO], valid_discovered_commissioner_number: str) -> bool:
+    """Initiate commissioning between Linux tv-casting-app and tv-app by sending `cast request {valid_discovered_commissioner_number}` via Linux tv-casting-app process."""
+    tv_casting_app_process, linux_tv_casting_app_log_file = tv_casting_app_info
+
+    start_wait_time = time.time()
+
+    while True:
+        # Check if we exceeded the maximum wait time for initiating 'cast request' from the Linux tv-casting-app to the Linux tv-app.
+        if time.time() - start_wait_time > COMMISSIONING_STAGE_MAX_WAIT_SEC:
+            logging.error('The command `cast request ' + valid_discovered_commissioner_number +
+                          '` was not issued to the Linux tv-casting-app process within the timeout.')
+            return False
+
+        tv_casting_app_output_line = tv_casting_app_process.stdout.readline()
+        if tv_casting_app_output_line:
+            linux_tv_casting_app_log_file.write(tv_casting_app_output_line)
+            linux_tv_casting_app_log_file.flush()
+
+            if 'cast request 0' in tv_casting_app_output_line:
+                tv_casting_app_process.stdin.write('cast request ' + valid_discovered_commissioner_number + '\n')
+                tv_casting_app_process.stdin.flush()
+                # Move to the next line otherwise we will keep entering this code block
+                next_line = tv_casting_app_process.stdout.readline()
+                linux_tv_casting_app_log_file.write(next_line)
+                linux_tv_casting_app_log_file.flush()
+                logging.info('Sent `' + next_line.rstrip('\n') + '` to the Linux tv-casting-app process.')
+                return True
+
+
+def extract_device_info_from_tv_casting_app(tv_casting_app_info: Tuple[subprocess.Popen, TextIO]) -> Tuple[Optional[str], Optional[int], Optional[int]]:
+    """Extract device information from the 'Identification Declaration' block in the Linux tv-casting-app output."""
+    tv_casting_app_process, linux_tv_casting_app_log_file = tv_casting_app_info
+
+    device_name = None
+    vendor_id = None
+    product_id = None
+
+    for line in tv_casting_app_process.stdout:
+        linux_tv_casting_app_log_file.write(line)
+        linux_tv_casting_app_log_file.flush()
+
+        if 'device Name' in line:
+            device_name = extract_value_from_string(line)
+        elif 'vendor id' in line:
+            vendor_id = extract_value_from_string(line)
+            vendor_id = int(vendor_id)
+        elif 'product id' in line:
+            product_id = extract_value_from_string(line)
+            product_id = int(product_id)
+
+        if device_name and vendor_id and product_id:
+            break
+
+    return device_name, vendor_id, product_id
+
+
+def validate_identification_declaration_message_on_tv_app(tv_app_info: Tuple[subprocess.Popen, TextIO], expected_device_name: str, expected_vendor_id: int, expected_product_id: int, log_paths: List[str]) -> bool:
+    """Validate device information from the 'Identification Declaration' block from the Linux tv-app output against the expected values."""
+    tv_app_process, linux_tv_app_log_file = tv_app_info
+
+    parsing_identification_block = False
+    start_wait_time = time.time()
+
+    while True:
+        # Check if we exceeded the maximum wait time for validating the device information from the Linux tv-app to the corresponding values from the Linux tv-app.
+        if time.time() - start_wait_time > COMMISSIONING_STAGE_MAX_WAIT_SEC:
+            logging.erro('The device information from the Linux tv-app output was not validated against the corresponding values from the Linux tv-casting-app output within the timeout.')
+            return False
+
+        tv_app_line = tv_app_process.stdout.readline()
+
+        if tv_app_line:
+            linux_tv_app_log_file.write(tv_app_line)
+            linux_tv_app_log_file.flush()
+
+            if 'Identification Declaration Start' in tv_app_line:
+                logging.info('"Identification Declaration" block from the Linux tv-app output:')
+                logging.info(tv_app_line.rstrip('\n'))
+                parsing_identification_block = True
+            elif parsing_identification_block:
+                logging.info(tv_app_line.rstrip('\n'))
+                if 'device Name' in tv_app_line:
+                    validate_value('Commissioning', expected_device_name, log_paths, tv_app_line, 'device Name')
+                elif 'vendor id' in tv_app_line:
+                    validate_value('Commissioning', expected_vendor_id, log_paths, tv_app_line, 'vendor id')
+                elif 'product id' in tv_app_line:
+                    validate_value('Commissioning', expected_product_id, log_paths, tv_app_line, 'product id')
+                elif 'Identification Declaration End' in tv_app_line:
+                    parsing_identification_block = False
+                    return True
+
+
+def validate_tv_casting_request_approval(tv_app_info: Tuple[subprocess.Popen, TextIO], log_paths: List[str]) -> bool:
+    """Validate that the TV casting request from the Linux tv-casting-app to the Linux tv-app is approved by sending `controller ux ok` via Linux tv-app process."""
+    tv_app_process, linux_tv_app_log_file = tv_app_info
+
+    start_wait_time = time.time()
+
+    while True:
+        # Check if we exceeded the maximum wait time for sending 'controller ux ok' from the Linux tv-app to the Linux tv-casting-app.
+        if time.time() - start_wait_time > COMMISSIONING_STAGE_MAX_WAIT_SEC:
+            logging.error('The cast request from the Linux tv-casting-app to the Linux tv-app was not approved within the timeout.')
+            return False
+
+        tv_app_line = tv_app_process.stdout.readline()
+
+        if tv_app_line:
+            linux_tv_app_log_file.write(tv_app_line)
+            linux_tv_app_log_file.flush()
+
+            if 'PROMPT USER: Test TV casting app is requesting permission to cast to this TV, approve?' in tv_app_line:
+                logging.info(tv_app_line.rstrip('\n'))
+            elif 'Via Shell Enter: controller ux ok|cancel' in tv_app_line:
+                logging.info(tv_app_line.rstrip('\n'))
+
+                tv_app_process.stdin.write('controller ux ok\n')
+                tv_app_process.stdin.flush()
+
+                tv_app_line = tv_app_process.stdout.readline()
+                linux_tv_app_log_file.write(tv_app_line)
+                linux_tv_app_log_file.flush()
+
+                logging.info('Sent `' + tv_app_line.rstrip('\n') + '` to the Linux tv-app process.')
+                return True
+
+
+def validate_commissioning_success(tv_casting_app_info: Tuple[subprocess.Popen, TextIO], tv_app_info: Tuple[subprocess.Popen, TextIO], log_paths: List[str]) -> bool:
+    """Parse output of Linux tv-casting-app and Linux tv-app output for strings indicating commissioning status."""
+    tv_casting_app_process, linux_tv_casting_app_log_file = tv_casting_app_info
+    tv_app_process, linux_tv_app_log_file = tv_app_info
+
+    start_wait_time = time.time()
+
+    while True:
+        # Check if we exceeded the maximum wait time for validating commissioning success between the Linux tv-casting-app and the Linux tv-app.
+        if time.time() - start_wait_time > COMMISSIONING_STAGE_MAX_WAIT_SEC:
+            logging.error(
+                'The commissioning between the Linux tv-casting-app process and the Linux tv-app process did not complete successfully within the timeout.')
+            return False
+
+        tv_casting_line = tv_casting_app_process.stdout.readline()
+        tv_app_line = tv_app_process.stdout.readline()
+
+        if tv_casting_line:
+            linux_tv_casting_app_log_file.write(tv_casting_line)
+            linux_tv_casting_app_log_file.flush()
+
+            if 'Commissioning completed successfully' in tv_casting_line:
+                logging.info('Commissioning success noted on the Linux tv-casting-app output:')
+                logging.info(tv_casting_line.rstrip('\n'))
+            elif 'Commissioning failed' in tv_casting_line:
+                logging.error('Commissioning failed noted on the Linux tv-casting-app output:')
+                logging.error(tv_casting_line.rstrip('\n'))
+                return False
+
+        if tv_app_line:
+            linux_tv_app_log_file.write(tv_app_line)
+            linux_tv_app_log_file.flush()
+
+            if 'PROMPT USER: commissioning success' in tv_app_line:
+                logging.info('Commissioning success noted on the Linux tv-app output:')
+                logging.info(tv_app_line.rstrip('\n'))
+                return True
+
+
+def test_discovery_fn(tv_casting_app_info: Tuple[subprocess.Popen, TextIO], log_paths: List[str]) -> Optional[str]:
     """Parse the output of the Linux tv-casting-app to find a valid commissioner."""
     tv_casting_app_process, linux_tv_casting_app_log_file = tv_casting_app_info
 
@@ -151,21 +324,21 @@ def parse_output_for_valid_commissioner(tv_casting_app_info: Tuple[subprocess.Po
         # Fail fast if "No commissioner discovered" string found.
         if "No commissioner discovered" in line:
             logging.error(line.rstrip('\n'))
-            handle_discovery_failure(log_paths)
+            handle_casting_failure('Discovery', log_paths)
 
         elif "Discovered Commissioner" in line:
             valid_discovered_commissioner = line.rstrip('\n')
 
         elif valid_discovered_commissioner:
             # Continue parsing the output for the information of interest under 'Discovered Commissioner'
             if 'Vendor ID:' in line:
-                valid_vendor_id = validate_value(VENDOR_ID, log_paths, line, 'Vendor ID')
+                valid_vendor_id = validate_value('Discovery', VENDOR_ID, log_paths, line, 'Vendor ID')
 
             elif 'Product ID:' in line:
-                valid_product_id = validate_value(PRODUCT_ID, log_paths, line, 'Product ID')
+                valid_product_id = validate_value('Discovery', PRODUCT_ID, log_paths, line, 'Product ID')
 
             elif 'Device Type:' in line:
-                valid_device_type = validate_value(DEVICE_TYPE_CASTING_VIDEO_PLAYER, log_paths, line, 'Device Type')
+                valid_device_type = validate_value('Discovery', DEVICE_TYPE_CASTING_VIDEO_PLAYER, log_paths, line, 'Device Type')
 
         # A valid commissioner has VENDOR_ID, PRODUCT_ID, and DEVICE TYPE in its list of entries.
         if valid_vendor_id and valid_product_id and valid_device_type:
@@ -177,12 +350,33 @@ def parse_output_for_valid_commissioner(tv_casting_app_info: Tuple[subprocess.Po
             logging.info('Discovery success!')
             break
 
+    return valid_discovered_commissioner
+
+
+def test_commissioning_fn(valid_discovered_commissioner_number, tv_casting_app_info: Tuple[subprocess.Popen, TextIO], tv_app_info: Tuple[subprocess.Popen, TextIO], log_paths: List[str]):
+    """Test commissioning between Linux tv-casting-app and Linux tv-app."""
+
+    if not initiate_cast_request_success(tv_casting_app_info, valid_discovered_commissioner_number):
+        handle_casting_failure('Commissioning', log_paths)
+
+    # Extract the values from the 'Identification Declaration' block in the tv-casting-app output that we want to validate against.
+    expected_device_name, expected_vendor_id, expected_product_id = extract_device_info_from_tv_casting_app(tv_casting_app_info)
+
+    if not validate_identification_declaration_message_on_tv_app(tv_app_info, expected_device_name, expected_vendor_id, expected_product_id, log_paths):
+        handle_casting_failure('Commissioning', log_paths)
+
+    if not validate_tv_casting_request_approval(tv_app_info, log_paths):
+        handle_casting_failure('Commissioning', log_paths)
+
+    if not validate_commissioning_success(tv_casting_app_info, tv_app_info, log_paths):
+        handle_casting_failure('Commissioning', log_paths)
+
 
 @click.command()
 @click.option('--tv-app-rel-path', type=str, default='out/tv-app/chip-tv-app', help='Path to the Linux tv-app executable.')
 @click.option('--tv-casting-app-rel-path', type=str, default='out/tv-casting-app/chip-tv-casting-app', help='Path to the Linux tv-casting-app executable.')
-def test_discovery_fn(tv_app_rel_path, tv_casting_app_rel_path):
-    """Test if the Linux tv-casting-app is able to discover the Linux tv-app.
+def test_casting_fn(tv_app_rel_path, tv_casting_app_rel_path):
+    """Test if the Linux tv-casting-app is able to discover and commission the Linux tv-app as part of casting.
 
     Default paths for the executables are provided but can be overridden via command line arguments.
     For example: python3 run_tv_casting_test.py --tv-app-rel-path=path/to/tv-app
@@ -203,23 +397,34 @@ def test_discovery_fn(tv_app_rel_path, tv_casting_app_rel_path):
 
             tv_app_abs_path = os.path.abspath(tv_app_rel_path)
             # Run the Linux tv-app subprocess.
-            with ProcessManager(disable_stdout_buffering_cmd + [tv_app_abs_path], stdout=subprocess.PIPE, stderr=subprocess.PIPE) as tv_app_process:
+            with ProcessManager(disable_stdout_buffering_cmd + [tv_app_abs_path], stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE) as tv_app_process:
 
                 if not start_up_tv_app_success(tv_app_process, linux_tv_app_log_file):
-                    handle_discovery_failure([linux_tv_app_log_path])
+                    handle_casting_failure('Discovery', [linux_tv_app_log_path])
 
                 tv_casting_app_abs_path = os.path.abspath(tv_casting_app_rel_path)
                 # Run the Linux tv-casting-app subprocess.
-                with ProcessManager(disable_stdout_buffering_cmd + [tv_casting_app_abs_path], stdout=subprocess.PIPE, stderr=subprocess.PIPE) as tv_casting_app_process:
+                with ProcessManager(disable_stdout_buffering_cmd + [tv_casting_app_abs_path], stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE) as tv_casting_app_process:
                     log_paths = [linux_tv_app_log_path, linux_tv_casting_app_log_path]
                     tv_casting_app_info = (tv_casting_app_process, linux_tv_casting_app_log_file)
-                    parse_output_for_valid_commissioner(tv_casting_app_info, log_paths)
+                    tv_app_info = (tv_app_process, linux_tv_app_log_file)
+                    valid_discovered_commissioner = test_discovery_fn(tv_casting_app_info, log_paths)
+
+                    if not valid_discovered_commissioner:
+                        handle_casting_failure('Discovery', log_paths)
+
+                    # We need the valid discovered commissioner number to continue with commissioning.
+                    # Example string: \x1b[0;32m[1714582264602] [77989:2286038] [SVR] Discovered Commissioner #0\x1b[0m
+                    #                 The value '0' will be extracted from the string.
+                    valid_discovered_commissioner_number = valid_discovered_commissioner.split('#')[-1].replace('\x1b[0m', '')
+
+                    test_commissioning_fn(valid_discovered_commissioner_number, tv_casting_app_info, tv_app_info, log_paths)
 
 
 if __name__ == '__main__':
 
     # Start with a clean slate by removing any previously cached entries.
     os.system('rm -f /tmp/chip_*')
 
-    # Test discovery between the Linux tv-casting-app and the tv-app.
-    test_discovery_fn()
+    # Test casting (discovery and commissioning) between the Linux tv-casting-app and the tv-app.
+    test_casting_fn()