Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit c024959

Browse files
committedFeb 27, 2025
addressing PR comments
1 parent b18e61a commit c024959

File tree

4 files changed

+15
-18
lines changed

4 files changed

+15
-18
lines changed
 

‎examples/closure-app/closure-common/closure-control/include/ClosureControlDelegate.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ namespace app {
2929
namespace Clusters {
3030
namespace ClosureControl {
3131

32-
// This is an application level delegate to handle operational state commands according to the specific business logic.
32+
// This is an application level delegate to handle Closure Control commands according to the specific business logic.
3333
class ClosureControlDelegate : public ClosureControl::Delegate
3434
{
3535
public:

‎examples/closure-app/closure-common/common/include/ClosureAppCommonMain.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#include <lib/core/DataModelTypes.h>
2323

2424
// This app is configured by default with EP1 for ClosureBase with only one endpoint
25-
// enabled for now. it cna be expanded to multiple endpoints
25+
// enabled for now. it can be expanded to multiple endpoints
2626
chip::EndpointId GetClosureDeviceEndpointId();
2727

2828
void ClosureApplicationInit();

‎examples/closure-app/silabs/BUILD.gn

-3
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,6 @@ if (wifi_soc) {
102102
"${examples_plat_dir}",
103103
"${chip_root}/src/lib",
104104
"${examples_common_plat_dir}",
105-
"${chip_root}/examples/closure-app/closure-common/common/include",
106-
"${chip_root}/examples/closure-app/closure-common/closure-control/include",
107105
]
108106

109107
if (use_wf200) {
@@ -190,7 +188,6 @@ silabs_executable("closure-app") {
190188
"${chip_root}/examples/common/pigweed:button_service.nanopb_rpc",
191189
"${chip_root}/examples/common/pigweed:descriptor_service.nanopb_rpc",
192190
"${chip_root}/examples/common/pigweed:device_service.nanopb_rpc",
193-
"${chip_root}/examples/common/pigweed:lighting_service.nanopb_rpc",
194191
"${chip_root}/examples/common/pigweed:ot_cli_service.nanopb_rpc",
195192
"${chip_root}/examples/common/pigweed:thread_service.nanopb_rpc",
196193
]

‎examples/closure-app/silabs/README.md

+13-13
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@ An example showing the use of CHIP on the Silicon Labs SiWx917
44

55
<hr>
66

7-
- [Matter SiWx917 Closure Example](#matter-siwx917-closure-example)
8-
- [Introduction](#introduction)
9-
- [Building](#building)
10-
- [Flashing the Application](#flashing-the-application)
11-
- [Running the Complete Example](#running-the-complete-example)
12-
- [Group Communication (Multicast)](#group-communication-multicast)
13-
- [Building options](#building-options)
14-
- [Disabling logging](#disabling-logging)
15-
- [Debug build / release build](#debug-build--release-build)
16-
- [KVS maximum entry count](#kvs-maximum-entry-count)
7+
- [Matter SiWx917 Closure Example](#matter-siwx917-closure-example)
8+
- [Introduction](#introduction)
9+
- [Building](#building)
10+
- [Flashing the Application](#flashing-the-application)
11+
- [Running the Complete Example](#running-the-complete-example)
12+
- [Group Communication (Multicast)](#group-communication-multicast)
13+
- [Building options](#building-options)
14+
- [Disabling logging](#disabling-logging)
15+
- [Debug build / release build](#debug-build--release-build)
16+
- [KVS maximum entry count](#kvs-maximum-entry-count)
1717

1818
<hr>
1919

@@ -177,7 +177,7 @@ passed to the build scripts.
177177

178178
`kvs_max_entries`
179179

180-
Set the maximum Kvs entries that can be stored in NVM (Default 75)
181-
Thresholds: 30 <= kvs_max_entries <= 255
180+
Set the maximum Kvs entries that can be stored in NVM (Default 255)
181+
Thresholds: 30 <= kvs_max_entries <= 511
182182

183-
$ ./scripts/examples/gn_silabs_example.sh ./examples/closure-app/silabs ./out/closure-app BRD4338A kvs_max_entries=50
183+
$ ./scripts/examples/gn_silabs_example.sh ./examples/closure-app/silabs ./out/closure-app BRD4338A kvs_max_entries=355

0 commit comments

Comments
 (0)
Please sign in to comment.