Skip to content

Commit c13aca1

Browse files
committed
Address further review comments from JamesH
1 parent 44c333f commit c13aca1

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

examples/all-clusters-app/all-clusters-common/include/WhmManufacturer.h

-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ class WhmManufacturer
120120

121121
private:
122122
WaterHeaterManagementInstance * mWhmInstance;
123-
bool mBoostActive;
124123
};
125124

126125
/** @brief Helper function to return the singleton WhmManufacturer instance

examples/all-clusters-app/all-clusters-common/src/WhmManufacturer.cpp

+2-12
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ CHIP_ERROR WhmManufacturer::Init()
4343
return CHIP_ERROR_UNINITIALIZED;
4444
}
4545

46-
mBoostActive = false;
47-
4846
dg->SetHeaterTypes(BitMask<WaterHeaterTypeBitmap>(WaterHeaterTypeBitmap::kImmersionElement1));
4947
dg->SetHeatDemand(BitMask<WaterHeaterDemandBitmap>(WaterHeaterDemandBitmap::kImmersionElement1));
5048
dg->SetEstimatedHeatRequired(10000);
@@ -109,13 +107,10 @@ Status WhmManufacturer::TurnHeatingOn(bool emergencyBoost)
109107

110108
WaterHeaterManagementDelegate * dg = GetWhmDelegate();
111109

112-
if (dg->GetBoostState() == BoostStateEnum::kActive)
113-
{
114-
mBoostActive = true;
115-
}
116-
117110
if (emergencyBoost)
118111
{
112+
// emergencyBoost that the consumer wants the water to be heated as quickly as practicable.
113+
// Thus, cause multiple heat sources to be activated
119114
dg->SetHeatDemand(BitMask<WaterHeaterDemandBitmap>(WaterHeaterDemandBitmap::kImmersionElement1,
120115
WaterHeaterDemandBitmap::kImmersionElement2));
121116
}
@@ -133,11 +128,6 @@ Status WhmManufacturer::TurnHeatingOff()
133128

134129
ChipLogProgress(AppServer, "WhmManufacturer::TurnHeatingOff");
135130

136-
if (mBoostActive)
137-
{
138-
mBoostActive = false;
139-
}
140-
141131
WaterHeaterManagementDelegate * dg = GetWhmDelegate();
142132

143133
dg->SetHeatDemand(BitMask<WaterHeaterDemandBitmap>(0));

0 commit comments

Comments
 (0)