devcontainers: Reduce maintenance workload, optimize docker build (#37997)

* devcontainers: Reduce maintenance workload, optimize docker build

- optimize $AMEBA_PATH ownership and mode adjustment
- drop duplicated $ANDROID_HOME path
- autodetect current version number in build.sh removing the need for explicit bumps

Signed-off-by: Maciej Grela <m.grela@samsung.com>

* Restyled by shfmt

* trigger rebuild, darwin job failure

Signed-off-by: Maciej Grela <m.grela@samsung.com>

* devcontainer: Do not rely on git rev-parse for CHIP_ROOT detection

Signed-off-by: Maciej Grela <m.grela@samsung.com>

---------

Signed-off-by: Maciej Grela <m.grela@samsung.com>
Co-authored-by: Restyled.io <commits@restyled.io>

Author: enkiusz

.devcontainer/Dockerfile

@@ -56,23 +56,18 @@ RUN curl https://raw.githubusercontent.com/restyled-io/restyler/master/bin/resty
 
 RUN mkdir -p /opt/android/sdk \
     && chown -R $USERNAME:$USERNAME \
-    /opt/android/sdk `# NXP uses a patch_sdk script to change SDK files` \
     $ANDROID_HOME \
     $IDF_TOOLS_PATH \
-    && find $AMEBA_PATH -name "inc_lp" -print0 | xargs -0 chown -R $USERNAME:$USERNAME \
-    && find $AMEBA_PATH -name "inc_hp" -print0 | xargs -0 chown -R $USERNAME:$USERNAME \
-    && find $AMEBA_PATH -name "project_lp" -print0 | xargs -0 chown -R $USERNAME:$USERNAME \
-    && find $AMEBA_PATH -name "project_hp" -print0 | xargs -0 chown -R $USERNAME:$USERNAME \
-    && chmod -R +x \
-    $ANDROID_HOME/cmdline-tools/10.0/bin `# sdkmanager for accepting licenses`\
+    && find $AMEBA_PATH \
+    -name "inc_lp" -print0      -or \
+    -name "inc_hp" -print0      -or \
+    -name "project_lp" -print0  -or \
+    -name "project_hp" -print0 \
+    | xargs -0 -I {} sh -c 'chown -R $USERNAME:$USERNAME {}; chmod -R +w {}' \
+    && find $ANDROID_HOME/cmdline-tools/ -type d -name bin | xargs chmod -R +x `# sdkmanager for accepting licenses` \
     && chmod -R +w \
     $IDF_TOOLS_PATH \
-    && find $AMEBA_PATH -name "inc_lp" -print0 | xargs -0 chmod -R +w \
-    && find $AMEBA_PATH -name "inc_hp" -print0 | xargs -0 chmod -R +w \
-    && find $AMEBA_PATH -name "project_lp" -print0 | xargs -0 chmod -R +w \
-    && find $AMEBA_PATH -name "project_hp" -print0 | xargs -0 chmod -R +w \
-    # Safe directory is preferred over chown.
-    && git config --global --add safe.directory "*" \
+    && git config --global --add safe.directory "*" `# Safe directory is preferred over chown.` \
     && :
 
 # Fix Tizen SDK paths for new user

.devcontainer/build.sh

@@ -18,7 +18,7 @@
 
 HERE="$(dirname "$0")"
 CHIP_ROOT="$(realpath "$HERE"/..)"
-BUILD_VERSION="latest"
+BUILD_VERSION=$(sed 's/ .*//' "$CHIP_ROOT/integrations/docker/images/base/chip-build/version")
 IMAGE_TAG="matter-dev-environment:local"
 USER_UID=$UID
 
@@ -32,7 +32,7 @@ Options:
     -h,--help        Show this help
     -t,--tag         Image tag - default is matter-dev-environment:local
     -u,--uid         User UIDa - default is the current user ID
-    -v,--version     Build version - default is the latest
+    -v,--version     Build version - default is the version of the base chip-build docker image
 EOF
 }
 

.devcontainer/devcontainer.json

@@ -20,7 +20,7 @@
             "type": "bind"
         }
     ],
-    "initializeCommand": "bash .devcontainer/build.sh --tag matter-dev-environment:local --version 97",
+    "initializeCommand": "bash .devcontainer/build.sh",
     "image": "matter-dev-environment:local",
     "remoteUser": "vscode",
     "containerEnv": {