Skip to content

Commit cb1fdfc

Browse files
committed
fix code review comment: rework reading attribute using read_single_attribute_check_success()
1 parent 71708d1 commit cb1fdfc

File tree

1 file changed

+16
-19
lines changed

1 file changed

+16
-19
lines changed

src/python_testing/TC_TCTL_2_3.py

+16-19
Original file line numberDiff line numberDiff line change
@@ -63,32 +63,29 @@ async def test_TC_TCTL_2_3(self):
6363
# Step 2: Read SelectedTemperatureLevel attribute
6464
self.step(2)
6565
if self.check_pics("TCTL.S.A0004"): # SelectedTemperatureLevel attribute
66-
selected_temp = await self.default_controller.ReadAttribute(
67-
nodeid=self.dut_node_id,
68-
attributes=[(1, Clusters.TemperatureControl.Attributes.SelectedTemperatureLevel)]
66+
selected_temp = await self.read_single_attribute_check_success(
67+
cluster=Clusters.Objects.TemperatureControl,
68+
attribute=Clusters.TemperatureControl.Attributes.SelectedTemperatureLevel
6969
)
70-
temp_level = selected_temp[1][Clusters.TemperatureControl][Clusters.TemperatureControl.Attributes.SelectedTemperatureLevel]
71-
asserts.assert_true(0 <= temp_level <= 31,
72-
f"SelectedTemperatureLevel {temp_level} is out of range [0-31]")
70+
asserts.assert_true(0 <= selected_temp <= 31,
71+
f"SelectedTemperatureLevel {selected_temp} is out of range [0-31]")
7372

7473
# Step 3: Read SupportedTemperatureLevels attribute
7574
self.step(3)
7675
if self.check_pics("TCTL.S.A0005"): # SupportedTemperatureLevels attribute
77-
supported_temps = await self.default_controller.ReadAttribute(
78-
nodeid=self.dut_node_id,
79-
attributes=[(1, Clusters.TemperatureControl.Attributes.SupportedTemperatureLevels)]
76+
supported_temps = await self.read_single_attribute_check_success(
77+
cluster=Clusters.Objects.TemperatureControl,
78+
attribute=Clusters.TemperatureControl.Attributes.SupportedTemperatureLevels
8079
)
80+
asserts.assert_true(isinstance(supported_temps, list),
81+
"SupportedTemperatureLevels should be a list")
82+
asserts.assert_true(len(supported_temps) <= 32,
83+
f"SupportedTemperatureLevels list length {len(supported_temps)} exceeds maximum of 32")
8184

82-
temp_levels = supported_temps[1][Clusters.TemperatureControl][Clusters.TemperatureControl.Attributes.SupportedTemperatureLevels]
83-
asserts.assert_true(isinstance(temp_levels, list),
84-
"SupportedTemperatureLevels should be a list")
85-
asserts.assert_true(len(temp_levels) <= 32,
86-
f"SupportedTemperatureLevels list length {len(temp_levels)} exceeds maximum of 32")
87-
88-
# Verify string lengths
89-
for level in temp_levels:
90-
asserts.assert_true(isinstance(level, str),
91-
f"Temperature level {level} is not a string")
85+
# Verify string lengths
86+
for level in supported_temps:
87+
asserts.assert_true(isinstance(level, str),
88+
f"Temperature level {level} is not a string")
9289
asserts.assert_true(len(level) <= 16,
9390
f"Temperature level string '{level}' exceeds maximum length of 16")
9491

0 commit comments

Comments
 (0)