Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit cc231d0

Browse files
authoredJul 8, 2024··
Merge branch 'master' into idm-4.2-troubleshoot
2 parents 42085e9 + 8786012 commit cc231d0

File tree

191 files changed

+3618
-8817
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

191 files changed

+3618
-8817
lines changed
 

‎.github/workflows/build.yaml

+6-1
Original file line numberDiff line numberDiff line change
@@ -204,11 +204,13 @@ jobs:
204204
run: |
205205
./scripts/run_in_build_env.sh "./scripts/run_codegen_targets.sh out/sanitizers"
206206
- name: Clang-tidy validation
207+
# NOTE: clang-tidy crashes on CodegenDataModel_Write due to Nullable/std::optional check.
208+
# See https://github.com/llvm/llvm-project/issues/97426
207209
run: |
208210
./scripts/run_in_build_env.sh \
209211
"./scripts/run-clang-tidy-on-compile-commands.py \
210212
--compile-database out/sanitizers/compile_commands.json \
211-
--file-exclude-regex '/(repo|zzz_generated|lwip/standalone)/|-ReadImpl|-InvokeSubscribeImpl' \
213+
--file-exclude-regex '/(repo|zzz_generated|lwip/standalone)/|-ReadImpl|-InvokeSubscribeImpl|CodegenDataModel_Write' \
212214
check \
213215
"
214216
- name: Clean output
@@ -422,10 +424,13 @@ jobs:
422424
run: |
423425
./scripts/run_in_build_env.sh "./scripts/run_codegen_targets.sh out/default"
424426
- name: Clang-tidy validation
427+
# NOTE: clang-tidy crashes on CodegenDataModel_Write due to Nullable/std::optional check.
428+
# See https://github.com/llvm/llvm-project/issues/97426
425429
run: |
426430
./scripts/run_in_build_env.sh \
427431
"./scripts/run-clang-tidy-on-compile-commands.py \
428432
--compile-database out/default/compile_commands.json \
433+
--file-exclude-regex '/(repo|zzz_generated|lwip/standalone)/|CodegenDataModel_Write' \
429434
check \
430435
"
431436
- name: Uploading diagnostic logs

‎.github/workflows/lint.yml

+11-1
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,17 @@ jobs:
288288
type-safe setters
289289
if: always()
290290
run: |
291-
git grep -I -n 'emberAfWriteAttribute' -- './*' ':(exclude).github/workflows/lint.yml' ':(exclude)zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp' ':(exclude)src/app/zap-templates/templates/app/attributes/Accessors-src.zapt' ':(exclude)src/app/util/attribute-table.cpp' ':(exclude)examples/common/pigweed/rpc_services/Attributes.h' ':(exclude)src/app/util/attribute-table.h' ':(exclude)src/app/util/ember-compatibility-functions.cpp' && exit 1 || exit 0
291+
git grep -I -n 'emberAfWriteAttribute' -- './*' \
292+
':(exclude).github/workflows/lint.yml' \
293+
':(exclude)examples/common/pigweed/rpc_services/Attributes.h' \
294+
':(exclude)src/app/codegen-data-model/CodegenDataModel_Write.cpp' \
295+
':(exclude)src/app/codegen-data-model/tests/EmberReadWriteOverride.cpp' \
296+
':(exclude)src/app/util/attribute-table.cpp' \
297+
':(exclude)src/app/util/attribute-table.h' \
298+
':(exclude)src/app/util/ember-compatibility-functions.cpp' \
299+
':(exclude)src/app/zap-templates/templates/app/attributes/Accessors-src.zapt' \
300+
':(exclude)zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp' \
301+
&& exit 1 || exit 0
292302
293303
# Run ruff python linter
294304
- name: Check for errors using ruff Python linter

0 commit comments

Comments
 (0)
Please sign in to comment.