Skip to content

Commit d91fa6f

Browse files
authoredJan 10, 2025
Spell judgement as judgment to make en-US spell checker happy without a wordlist (#37029)
1 parent c39088c commit d91fa6f

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed
 

‎.github/.wordlist.txt

-1
Original file line numberDiff line numberDiff line change
@@ -757,7 +757,6 @@ js
757757
json
758758
JTAG
759759
Jupyter
760-
judgement
761760
jupyterlab
762761
KA
763762
kAdminister

‎CONTRIBUTING.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -198,13 +198,13 @@ to open the pull request for details or open additional issue in GitHub)
198198
Ensure that there is sufficient detail in issue summaries to make the content of
199199
the PR clear:
200200

201-
- a `TLDR` of the change content. This is a judgement call on details,
201+
- a `TLDR` of the change content. This is a judgment call on details,
202202
generally you should include a what was changed and why. The change is
203203
trivial/short, this can be very short (i.e. "fixed typos" is perfectly
204204
acceptable, however if changing 100-1000s of line, the areas of changes
205205
should be explained)
206206
- If a crash/error is fixed, explain the root cause and if the fix is not
207-
obvious (again, judgement call), explain why the given approach was taken.
207+
obvious (again, judgment call), explain why the given approach was taken.
208208
- Help the reviewer out with any notable information (specific platform
209209
issues, extra thoughts or requests for feedback or gotchas on tricky code,
210210
followup work or PR dependencies)
@@ -230,7 +230,7 @@ out of convenience.
230230
updated to cover functionality" or "existing tests already cover this" (make
231231
sure they do. Integration tests often only cover happy paths).
232232

233-
Add any notes on not covered things. It is a judgement call on how much can
233+
Add any notes on not covered things. It is a judgment call on how much can
234234
be covered as 100% sounds great however not always possible.
235235

236236
- Manual testing

‎src/app/clusters/time-synchronization-server/time-synchronization-server.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -909,7 +909,7 @@ TimeState TimeSynchronizationServer::UpdateDSTOffsetState()
909909
int32_t previousOffset = dstList[activeDstIndex].offset;
910910
dstList[activeDstIndex].offset = 0; // not using dst and last DST item in the list is not active yet
911911
// TODO: This enum mixes state and transitions in a way that's very confusing. This should return either an active, an
912-
// inactive or an invalid and the caller should make the judgement about whether that has changed OR this function should
912+
// inactive or an invalid and the caller should make the judgment about whether that has changed OR this function should
913913
// just return a bool indicating whether a change happened
914914
return previousOffset == 0 ? TimeState::kStopped : TimeState::kChanged;
915915
}

0 commit comments

Comments
 (0)