Replace expect with assert for nullptr check

Author: jlatusek

src/credentials/tests/TestCommissionerDUTVectors.cpp

@@ -57,7 +57,7 @@ struct TestCommissionerDUTVectors : public ::testing::Test
 TEST_F(TestCommissionerDUTVectors, TestCommissionerDUTVectors)
 {
     DeviceAttestationVerifier * example_dac_verifier = GetDefaultDACVerifier(GetTestAttestationTrustStore());
-    EXPECT_NE(example_dac_verifier, nullptr);
+    ASSERT_NE(example_dac_verifier, nullptr);
 
     std::string dirPath("../../../../../credentials/development/commissioner_dut/");
     DIR * dir = opendir(dirPath.c_str());

src/credentials/tests/TestDeviceAttestationConstruction.cpp

@@ -604,7 +604,7 @@ TEST_F(TestDeviceAttestationConstruction, TestNocsrElements_Construction)
         TLV::EstimateStructOverhead(sizeof(kExampleCsr), sizeof(kNocsrNonce), sizeof(kVendorReserved1), sizeof(kVendorReserved3));
 
     nocsrElements.Alloc(nocsrElementsLen);
-    EXPECT_NE(nocsrElements.Get(), nullptr);
+    ASSERT_NE(nocsrElements.Get(), nullptr);
 
     MutableByteSpan nocsrElementsSpan(nocsrElements.Get(), nocsrElementsLen);
 

src/credentials/tests/TestFabricTable.cpp

@@ -2636,7 +2636,7 @@ TEST_F(TestFabricTable, TestEphemeralKeys)
         uint8_t message[] = { 'm', 's', 'g' };
 
         Crypto::P256Keypair * ephemeralKeypair = fabricTable.AllocateEphemeralKeypairForCASE();
-        EXPECT_NE(ephemeralKeypair, nullptr);
+        ASSERT_NE(ephemeralKeypair, nullptr);
         EXPECT_EQ(ephemeralKeypair->Initialize(Crypto::ECPKeyTarget::ECDSA), CHIP_NO_ERROR);
 
         EXPECT_EQ(ephemeralKeypair->ECDSA_sign_msg(message, sizeof(message), sig), CHIP_NO_ERROR);
@@ -2663,7 +2663,7 @@ TEST_F(TestFabricTable, TestEphemeralKeys)
         uint8_t message[] = { 'm', 's', 'g' };
 
         Crypto::P256Keypair * ephemeralKeypair = fabricTable.AllocateEphemeralKeypairForCASE();
-        EXPECT_NE(ephemeralKeypair, nullptr);
+        ASSERT_NE(ephemeralKeypair, nullptr);
         EXPECT_EQ(ephemeralKeypair->Initialize(Crypto::ECPKeyTarget::ECDSA), CHIP_NO_ERROR);
 
         EXPECT_EQ(ephemeralKeypair->ECDSA_sign_msg(message, sizeof(message), sig), CHIP_NO_ERROR);

src/credentials/tests/TestGroupDataProvider.cpp

@@ -1170,7 +1170,7 @@ TEST_F(TestGroupDataProvider, TestGroupDecryption)
 
     // Get the key context
     Crypto::SymmetricKeyContext * key_context = provider->GetKeyContext(kFabric2, kGroup2);
-    EXPECT_NE(nullptr, key_context);
+    ASSERT_NE(nullptr, key_context);
     uint16_t session_id = key_context->GetKeyHash();
 
     // Encrypt the message
@@ -1199,7 +1199,7 @@ TEST_F(TestGroupDataProvider, TestGroupDecryption)
     {
         std::pair<FabricIndex, GroupId> found(session.fabric_index, session.group_id);
         EXPECT_GT(expected.count(found), 0u);
-        EXPECT_NE(session.keyContext, nullptr);
+        ASSERT_NE(session.keyContext, nullptr);
         // Assert aboves doesn't actually exit, we call continue so that we can call it->Release() outside of
         // loop.
         if (session.keyContext == nullptr)