Updating logs in darwin framework to enable more by default (#33537)

woody-apple · restyled-commits · web-flow · commit dd55376a5943 · 2024-05-21T19:10:34.000-07:00
* Updating logs

* Restyled by clang-format

* Updating logs

* Updating logs

* Restyled by clang-format

---------

Co-authored-by: Restyled.io &lt;commits@restyled.io&gt;
diff --git a/src/darwin/Framework/CHIP/MTRCertificates.mm b/src/darwin/Framework/CHIP/MTRCertificates.mm
@@ -250,7 +250,7 @@ + (MTRCertificateTLVBytes _Nullable)convertX509Certificate:(MTRCertificateDERByt
         return nil;
     }
 
-    MTR_LOG_INFO("convertX509Certificate: Success");
+    MTR_LOG_DEBUG("convertX509Certificate: Success");
 
     return AsData(chipCertBytes);
 }
diff --git a/src/darwin/Framework/CHIP/MTRDevice.mm b/src/darwin/Framework/CHIP/MTRDevice.mm
@@ -442,7 +442,7 @@ - (instancetype)initWithNodeID:(NSNumber *)nodeID controller:(MTRDeviceControlle
         }
         _clusterDataToPersist = nil;
         _persistedClusters = [NSMutableSet set];
-        MTR_LOG_INFO("%@ init with hex nodeID 0x%016llX", self, _nodeID.unsignedLongLongValue);
+        MTR_LOG_DEBUG("%@ init with hex nodeID 0x%016llX", self, _nodeID.unsignedLongLongValue);
     }
     return self;
 }
@@ -1125,7 +1125,7 @@ - (void)_handleResubscriptionNeededWithDelay:(NSNumber *)resubscriptionDelayMs
             [self _triggerResubscribeWithReason:"ResubscriptionNeeded timer fired" nodeLikelyReachable:NO];
         } errorHandler:^(NSError * _Nonnull error) {
             // If controller is not running, clear work item from the subscription queue
-            MTR_LOG_INFO("%@ could not dispatch to matter queue for resubscription - error %@", self, error);
+            MTR_LOG_ERROR("%@ could not dispatch to matter queue for resubscription - error %@", self, error);
             std::lock_guard lock(self->_lock);
             [self _clearSubscriptionPoolWork];
         }];
@@ -1554,7 +1554,7 @@ - (nullable MTRDeviceClusterData *)_clusterDataForPath:(MTRClusterPath *)cluster
         dataVersions[path] = [self _clusterDataForPath:path].dataVersion;
     }
 
-    MTR_LOG_INFO("%@ _getCachedDataVersions dataVersions count: %lu", self, static_cast<unsigned long>(dataVersions.count));
+    MTR_LOG_DEBUG("%@ _getCachedDataVersions dataVersions count: %lu", self, static_cast<unsigned long>(dataVersions.count));
 
     return dataVersions;
 }
@@ -1644,7 +1644,7 @@ - (void)_setupConnectivityMonitoring
         // Get the required info before setting up the connectivity monitor
         NSNumber * compressedFabricID = [self->_deviceController syncGetCompressedFabricID];
         if (!compressedFabricID) {
-            MTR_LOG_INFO("%@ could not get compressed fabricID", self);
+            MTR_LOG_ERROR("%@ could not get compressed fabricID", self);
             return;
         }
 
@@ -1748,7 +1748,7 @@ - (void)_setupSubscription
                            });
                        },
                        ^(NSError * error, NSNumber * resubscriptionDelayMs) {
-                           MTR_LOG_DEFAULT("%@ got resubscription error %@ delay %@", self, error, resubscriptionDelayMs);
+                           MTR_LOG_ERROR("%@ got resubscription error %@ delay %@", self, error, resubscriptionDelayMs);
                            dispatch_async(self.queue, ^{
                                // OnResubscriptionNeeded
                                [self _handleResubscriptionNeededWithDelay:resubscriptionDelayMs];
@@ -2759,7 +2759,7 @@ - (NSArray *)_getAttributesToReportWithReportedValues:(NSArray<NSDictionary<NSSt
         if (attributeError) {
             shouldReportAttribute = YES;
             previousValue = [self _cachedAttributeValueForPath:attributePath];
-            MTR_LOG_INFO("%@ report %@ error %@ purge expected value %@ read cache %@", self, attributePath, attributeError,
+            MTR_LOG_ERROR("%@ report %@ error %@ purge expected value %@ read cache %@", self, attributePath, attributeError,
                 _expectedValueCache[attributePath], previousValue);
             _expectedValueCache[attributePath] = nil;
             // TODO: Is this clearing business really what we want?
@@ -2911,7 +2911,7 @@ - (void)_setLastInitialSubscribeLatency:(id)latency
 
 - (void)setPersistedDeviceData:(NSDictionary<NSString *, id> *)data
 {
-    MTR_LOG_INFO("%@ setPersistedDeviceData: %@", self, data);
+    MTR_LOG_DEBUG("%@ setPersistedDeviceData: %@", self, data);
 
     std::lock_guard lock(_lock);
 
diff --git a/src/darwin/Framework/CHIP/MTRDeviceController.h b/src/darwin/Framework/CHIP/MTRDeviceController.h
@@ -54,7 +54,7 @@ MTR_AVAILABLE(ios(16.1), macos(13.0), watchos(9.1), tvos(16.1))
  *    if it has not already been started.
  * 2) Return nil or a running controller.
  *
- * Once this returns non-nil, it's the caller's resposibility to call shutdown
+ * Once this returns non-nil, it's the caller's responsibility to call shutdown
  * on the controller to avoid leaking it.
  */
 - (nullable instancetype)initWithParameters:(MTRDeviceControllerAbstractParameters *)parameters
diff --git a/src/darwin/Framework/CHIP/MTRDeviceControllerDataStore.mm b/src/darwin/Framework/CHIP/MTRDeviceControllerDataStore.mm
@@ -597,7 +597,7 @@ - (void)_pruneEmptyStoredClusterDataBranches
                 }
                 if (!success) {
                     storeFailures++;
-                    MTR_LOG_INFO("Store failed in _pruneEmptyStoredClusterDataBranches for clusterIndex (%lu) @ node 0x%016llX endpoint %u", static_cast<unsigned long>(clusterIndexCopy.count), nodeID.unsignedLongLongValue, endpointID.unsignedShortValue);
+                    MTR_LOG_ERROR("Store failed in _pruneEmptyStoredClusterDataBranches for clusterIndex (%lu) @ node 0x%016llX endpoint %u", static_cast<unsigned long>(clusterIndexCopy.count), nodeID.unsignedLongLongValue, endpointID.unsignedShortValue);
                 }
             }
         }
@@ -612,7 +612,7 @@ - (void)_pruneEmptyStoredClusterDataBranches
             }
             if (!success) {
                 storeFailures++;
-                MTR_LOG_INFO("Store failed in _pruneEmptyStoredClusterDataBranches for endpointIndex (%lu) @ node 0x%016llX", static_cast<unsigned long>(endpointIndexCopy.count), nodeID.unsignedLongLongValue);
+                MTR_LOG_ERROR("Store failed in _pruneEmptyStoredClusterDataBranches for endpointIndex (%lu) @ node 0x%016llX", static_cast<unsigned long>(endpointIndexCopy.count), nodeID.unsignedLongLongValue);
             }
         }
     }
@@ -626,7 +626,7 @@ - (void)_pruneEmptyStoredClusterDataBranches
         }
         if (!success) {
             storeFailures++;
-            MTR_LOG_INFO("Store failed in _pruneEmptyStoredClusterDataBranches for nodeIndex (%lu)", static_cast<unsigned long>(nodeIndexCopy.count));
+            MTR_LOG_ERROR("Store failed in _pruneEmptyStoredClusterDataBranches for nodeIndex (%lu)", static_cast<unsigned long>(nodeIndexCopy.count));
         }
     }
 
@@ -656,23 +656,23 @@ - (void)_clearStoredClusterDataForNodeID:(NSNumber *)nodeID
         for (NSNumber * clusterID in clusterIndex) {
             BOOL success = [self _deleteClusterDataForNodeID:nodeID endpointID:endpointID clusterID:clusterID];
             if (!success) {
-                MTR_LOG_INFO("Delete failed for clusterData @ node 0x%016llX endpoint %u cluster 0x%08lX", nodeID.unsignedLongLongValue, endpointID.unsignedShortValue, clusterID.unsignedLongValue);
+                MTR_LOG_ERROR("Delete failed for clusterData @ node 0x%016llX endpoint %u cluster 0x%08lX", nodeID.unsignedLongLongValue, endpointID.unsignedShortValue, clusterID.unsignedLongValue);
             } else {
                 clusterDataCleared++;
             }
         }
 
         BOOL success = [self _deleteClusterIndexForNodeID:nodeID endpointID:endpointID];
         if (!success) {
-            MTR_LOG_INFO("Delete failed for clusterIndex @ node 0x%016llX endpoint %u", nodeID.unsignedLongLongValue, endpointID.unsignedShortValue);
+            MTR_LOG_ERROR("Delete failed for clusterIndex @ node 0x%016llX endpoint %u", nodeID.unsignedLongLongValue, endpointID.unsignedShortValue);
         } else {
             endpointsCleared++;
         }
     }
 
     BOOL success = [self _deleteEndpointIndexForNodeID:nodeID];
     if (!success) {
-        MTR_LOG_INFO("Delete failed for endpointIndex @ node 0x%016llX", nodeID.unsignedLongLongValue);
+        MTR_LOG_ERROR("Delete failed for endpointIndex @ node 0x%016llX", nodeID.unsignedLongLongValue);
     }
 
     MTR_LOG_INFO("clearStoredClusterDataForNodeID: deleted endpoints %lu/%lu clusters %lu/%lu", static_cast<unsigned long>(endpointsCleared), static_cast<unsigned long>(endpointsClearAttempts), static_cast<unsigned long>(clusterDataCleared), static_cast<unsigned long>(clusterDataClearAttempts));
@@ -693,7 +693,7 @@ - (void)clearStoredClusterDataForNodeID:(NSNumber *)nodeID
                 success = [self _deleteNodeIndex];
             }
             if (!success) {
-                MTR_LOG_INFO("Store failed in clearStoredAttributesForNodeID for nodeIndex (%lu)", static_cast<unsigned long>(nodeIndexCopy.count));
+                MTR_LOG_ERROR("Store failed in clearStoredAttributesForNodeID for nodeIndex (%lu)", static_cast<unsigned long>(nodeIndexCopy.count));
             }
         }
     });
@@ -711,7 +711,7 @@ - (void)clearAllStoredClusterData
 
         BOOL success = [self _deleteNodeIndex];
         if (!success) {
-            MTR_LOG_INFO("Delete failed for nodeIndex");
+            MTR_LOG_ERROR("Delete failed for nodeIndex");
         }
     });
 }
@@ -906,7 +906,7 @@ - (void)storeClusterData:(NSDictionary<MTRClusterPath *, MTRDeviceClusterData *>
                 BOOL storeFailed = ![self _storeClusterData:data forNodeID:nodeID endpointID:path.endpoint clusterID:path.cluster];
                 if (storeFailed) {
                     storeFailures++;
-                    MTR_LOG_INFO("Store failed for clusterData @ node 0x%016llX endpoint %u cluster 0x%08lX", nodeID.unsignedLongLongValue, path.endpoint.unsignedShortValue, path.cluster.unsignedLongValue);
+                    MTR_LOG_ERROR("Store failed for clusterData @ node 0x%016llX endpoint %u cluster 0x%08lX", nodeID.unsignedLongLongValue, path.endpoint.unsignedShortValue, path.cluster.unsignedLongValue);
                 }
             }
 
@@ -962,7 +962,7 @@ - (void)storeClusterData:(NSDictionary<MTRClusterPath *, MTRDeviceClusterData *>
                     BOOL storeFailed = ![self _storeClusterIndex:clusterIndexToStore forNodeID:nodeID endpointID:endpointID];
                     if (storeFailed) {
                         storeFailures++;
-                        MTR_LOG_INFO("Store failed for clusterIndex @ node 0x%016llX endpoint %u", nodeID.unsignedLongLongValue, endpointID.unsignedShortValue);
+                        MTR_LOG_ERROR("Store failed for clusterIndex @ node 0x%016llX endpoint %u", nodeID.unsignedLongLongValue, endpointID.unsignedShortValue);
                         continue;
                     }
                 }
@@ -977,7 +977,7 @@ - (void)storeClusterData:(NSDictionary<MTRClusterPath *, MTRDeviceClusterData *>
                 BOOL storeFailed = ![self _storeEndpointIndex:endpointIndexToStore forNodeID:nodeID];
                 if (storeFailed) {
                     storeFailures++;
-                    MTR_LOG_INFO("Store failed for endpointIndex @ node 0x%016llX", nodeID.unsignedLongLongValue);
+                    MTR_LOG_ERROR("Store failed for endpointIndex @ node 0x%016llX", nodeID.unsignedLongLongValue);
                 }
             }
         }
@@ -999,7 +999,7 @@ - (void)storeClusterData:(NSDictionary<MTRClusterPath *, MTRDeviceClusterData *>
                 BOOL storeFailed = ![self _storeNodeIndex:nodeIndexToStore];
                 if (storeFailed) {
                     storeFailures++;
-                    MTR_LOG_INFO("Store failed for nodeIndex");
+                    MTR_LOG_ERROR("Store failed for nodeIndex");
                 }
             }
         }
@@ -1008,7 +1008,7 @@ - (void)storeClusterData:(NSDictionary<MTRClusterPath *, MTRDeviceClusterData *>
             BOOL storeFailed = ![self _bulkStoreAttributeCacheValues:bulkValuesToStore];
             if (storeFailed) {
                 storeFailures++;
-                MTR_LOG_INFO("Store failed for bulk values count %lu", static_cast<unsigned long>(bulkValuesToStore.count));
+                MTR_LOG_ERROR("Store failed for bulk values count %lu", static_cast<unsigned long>(bulkValuesToStore.count));
             }
         }
 
diff --git a/src/darwin/Framework/CHIP/MTRLogging_Internal.h b/src/darwin/Framework/CHIP/MTRLogging_Internal.h
@@ -22,5 +22,5 @@
 
 #define MTR_LOG_ERROR(msg, ...) ChipLogError(NotSpecified, msg, ##__VA_ARGS__)
 #define MTR_LOG_DEFAULT(msg, ...) ChipLogProgress(NotSpecified, msg, ##__VA_ARGS__)
-#define MTR_LOG_INFO(msg, ...) ChipLogDetail(NotSpecified, msg, ##__VA_ARGS__)
+#define MTR_LOG_INFO(msg, ...) ChipLogProgress(NotSpecified, msg, ##__VA_ARGS__)
 #define MTR_LOG_DEBUG(msg, ...) ChipLogDetail(NotSpecified, msg, ##__VA_ARGS__) // same as INFO

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ + (MTRCertificateTLVBytes _Nullable)convertX509Certificate:(MTRCertificateDERByt`
`250`	`250`	`return nil;`
`251`	`251`	`}`
`252`	`252`
`253`		`- MTR_LOG_INFO("convertX509Certificate: Success");`
	`253`	`+ MTR_LOG_DEBUG("convertX509Certificate: Success");`
`254`	`254`
`255`	`255`	`return AsData(chipCertBytes);`
`256`	`256`	`}`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ MTR_AVAILABLE(ios(16.1), macos(13.0), watchos(9.1), tvos(16.1))`
`54`	`54`	`* if it has not already been started.`
`55`	`55`	`* 2) Return nil or a running controller.`
`56`	`56`	`*`
`57`		`- * Once this returns non-nil, it's the caller's resposibility to call shutdown`
	`57`	`+ * Once this returns non-nil, it's the caller's responsibility to call shutdown`
`58`	`58`	`* on the controller to avoid leaking it.`
`59`	`59`	`*/`
`60`	`60`	`- (nullable instancetype)initWithParameters:(MTRDeviceControllerAbstractParameters *)parameters`
Original file line number	Diff line number	Diff line change
`@@ -597,7 +597,7 @@ - (void)_pruneEmptyStoredClusterDataBranches`
`597`	`597`	`}`
`598`	`598`	`if (!success) {`
`599`	`599`	`storeFailures++;`
`600`		`- MTR_LOG_INFO("Store failed in _pruneEmptyStoredClusterDataBranches for clusterIndex (%lu) @ node 0x%016llX endpoint %u", static_cast<unsigned long>(clusterIndexCopy.count), nodeID.unsignedLongLongValue, endpointID.unsignedShortValue);`
	`600`	`+ MTR_LOG_ERROR("Store failed in _pruneEmptyStoredClusterDataBranches for clusterIndex (%lu) @ node 0x%016llX endpoint %u", static_cast<unsigned long>(clusterIndexCopy.count), nodeID.unsignedLongLongValue, endpointID.unsignedShortValue);`
`601`	`601`	`}`
`602`	`602`	`}`
`603`	`603`	`}`
`@@ -612,7 +612,7 @@ - (void)_pruneEmptyStoredClusterDataBranches`
`612`	`612`	`}`
`613`	`613`	`if (!success) {`
`614`	`614`	`storeFailures++;`
`615`		`- MTR_LOG_INFO("Store failed in _pruneEmptyStoredClusterDataBranches for endpointIndex (%lu) @ node 0x%016llX", static_cast<unsigned long>(endpointIndexCopy.count), nodeID.unsignedLongLongValue);`
	`615`	`+ MTR_LOG_ERROR("Store failed in _pruneEmptyStoredClusterDataBranches for endpointIndex (%lu) @ node 0x%016llX", static_cast<unsigned long>(endpointIndexCopy.count), nodeID.unsignedLongLongValue);`
`616`	`616`	`}`
`617`	`617`	`}`
`618`	`618`	`}`
`@@ -626,7 +626,7 @@ - (void)_pruneEmptyStoredClusterDataBranches`
`626`	`626`	`}`
`627`	`627`	`if (!success) {`
`628`	`628`	`storeFailures++;`
`629`		`- MTR_LOG_INFO("Store failed in _pruneEmptyStoredClusterDataBranches for nodeIndex (%lu)", static_cast<unsigned long>(nodeIndexCopy.count));`
	`629`	`+ MTR_LOG_ERROR("Store failed in _pruneEmptyStoredClusterDataBranches for nodeIndex (%lu)", static_cast<unsigned long>(nodeIndexCopy.count));`
`630`	`630`	`}`
`631`	`631`	`}`
`632`	`632`
`@@ -656,23 +656,23 @@ - (void)_clearStoredClusterDataForNodeID:(NSNumber *)nodeID`
`656`	`656`	`for (NSNumber * clusterID in clusterIndex) {`
`657`	`657`	`BOOL success = [self _deleteClusterDataForNodeID:nodeID endpointID:endpointID clusterID:clusterID];`
`658`	`658`	`if (!success) {`
`659`		`- MTR_LOG_INFO("Delete failed for clusterData @ node 0x%016llX endpoint %u cluster 0x%08lX", nodeID.unsignedLongLongValue, endpointID.unsignedShortValue, clusterID.unsignedLongValue);`
	`659`	`+ MTR_LOG_ERROR("Delete failed for clusterData @ node 0x%016llX endpoint %u cluster 0x%08lX", nodeID.unsignedLongLongValue, endpointID.unsignedShortValue, clusterID.unsignedLongValue);`
`660`	`660`	`} else {`
`661`	`661`	`clusterDataCleared++;`
`662`	`662`	`}`
`663`	`663`	`}`
`664`	`664`
`665`	`665`	`BOOL success = [self _deleteClusterIndexForNodeID:nodeID endpointID:endpointID];`
`666`	`666`	`if (!success) {`
`667`		`- MTR_LOG_INFO("Delete failed for clusterIndex @ node 0x%016llX endpoint %u", nodeID.unsignedLongLongValue, endpointID.unsignedShortValue);`
	`667`	`+ MTR_LOG_ERROR("Delete failed for clusterIndex @ node 0x%016llX endpoint %u", nodeID.unsignedLongLongValue, endpointID.unsignedShortValue);`
`668`	`668`	`} else {`
`669`	`669`	`endpointsCleared++;`
`670`	`670`	`}`
`671`	`671`	`}`
`672`	`672`
`673`	`673`	`BOOL success = [self _deleteEndpointIndexForNodeID:nodeID];`
`674`	`674`	`if (!success) {`
`675`		`- MTR_LOG_INFO("Delete failed for endpointIndex @ node 0x%016llX", nodeID.unsignedLongLongValue);`
	`675`	`+ MTR_LOG_ERROR("Delete failed for endpointIndex @ node 0x%016llX", nodeID.unsignedLongLongValue);`
`676`	`676`	`}`
`677`	`677`
`678`	`678`	`MTR_LOG_INFO("clearStoredClusterDataForNodeID: deleted endpoints %lu/%lu clusters %lu/%lu", static_cast<unsigned long>(endpointsCleared), static_cast<unsigned long>(endpointsClearAttempts), static_cast<unsigned long>(clusterDataCleared), static_cast<unsigned long>(clusterDataClearAttempts));`
`@@ -693,7 +693,7 @@ - (void)clearStoredClusterDataForNodeID:(NSNumber *)nodeID`
`693`	`693`	`success = [self _deleteNodeIndex];`
`694`	`694`	`}`
`695`	`695`	`if (!success) {`
`696`		`- MTR_LOG_INFO("Store failed in clearStoredAttributesForNodeID for nodeIndex (%lu)", static_cast<unsigned long>(nodeIndexCopy.count));`
	`696`	`+ MTR_LOG_ERROR("Store failed in clearStoredAttributesForNodeID for nodeIndex (%lu)", static_cast<unsigned long>(nodeIndexCopy.count));`
`697`	`697`	`}`
`698`	`698`	`}`
`699`	`699`	`});`
`@@ -711,7 +711,7 @@ - (void)clearAllStoredClusterData`
`711`	`711`
`712`	`712`	`BOOL success = [self _deleteNodeIndex];`
`713`	`713`	`if (!success) {`
`714`		`- MTR_LOG_INFO("Delete failed for nodeIndex");`
	`714`	`+ MTR_LOG_ERROR("Delete failed for nodeIndex");`
`715`	`715`	`}`
`716`	`716`	`});`
`717`	`717`	`}`
`@@ -906,7 +906,7 @@ - (void)storeClusterData:(NSDictionary<MTRClusterPath , MTRDeviceClusterData >`
`906`	`906`	`BOOL storeFailed = ![self _storeClusterData:data forNodeID:nodeID endpointID:path.endpoint clusterID:path.cluster];`
`907`	`907`	`if (storeFailed) {`
`908`	`908`	`storeFailures++;`
`909`		`- MTR_LOG_INFO("Store failed for clusterData @ node 0x%016llX endpoint %u cluster 0x%08lX", nodeID.unsignedLongLongValue, path.endpoint.unsignedShortValue, path.cluster.unsignedLongValue);`
	`909`	`+ MTR_LOG_ERROR("Store failed for clusterData @ node 0x%016llX endpoint %u cluster 0x%08lX", nodeID.unsignedLongLongValue, path.endpoint.unsignedShortValue, path.cluster.unsignedLongValue);`
`910`	`910`	`}`
`911`	`911`	`}`
`912`	`912`
`@@ -962,7 +962,7 @@ - (void)storeClusterData:(NSDictionary<MTRClusterPath , MTRDeviceClusterData >`
`962`	`962`	`BOOL storeFailed = ![self _storeClusterIndex:clusterIndexToStore forNodeID:nodeID endpointID:endpointID];`
`963`	`963`	`if (storeFailed) {`
`964`	`964`	`storeFailures++;`
`965`		`- MTR_LOG_INFO("Store failed for clusterIndex @ node 0x%016llX endpoint %u", nodeID.unsignedLongLongValue, endpointID.unsignedShortValue);`
	`965`	`+ MTR_LOG_ERROR("Store failed for clusterIndex @ node 0x%016llX endpoint %u", nodeID.unsignedLongLongValue, endpointID.unsignedShortValue);`
`966`	`966`	`continue;`
`967`	`967`	`}`
`968`	`968`	`}`
`@@ -977,7 +977,7 @@ - (void)storeClusterData:(NSDictionary<MTRClusterPath , MTRDeviceClusterData >`
`977`	`977`	`BOOL storeFailed = ![self _storeEndpointIndex:endpointIndexToStore forNodeID:nodeID];`
`978`	`978`	`if (storeFailed) {`
`979`	`979`	`storeFailures++;`
`980`		`- MTR_LOG_INFO("Store failed for endpointIndex @ node 0x%016llX", nodeID.unsignedLongLongValue);`
	`980`	`+ MTR_LOG_ERROR("Store failed for endpointIndex @ node 0x%016llX", nodeID.unsignedLongLongValue);`
`981`	`981`	`}`
`982`	`982`	`}`
`983`	`983`	`}`
`@@ -999,7 +999,7 @@ - (void)storeClusterData:(NSDictionary<MTRClusterPath , MTRDeviceClusterData >`
`999`	`999`	`BOOL storeFailed = ![self _storeNodeIndex:nodeIndexToStore];`
`1000`	`1000`	`if (storeFailed) {`
`1001`	`1001`	`storeFailures++;`
`1002`		`- MTR_LOG_INFO("Store failed for nodeIndex");`
	`1002`	`+ MTR_LOG_ERROR("Store failed for nodeIndex");`
`1003`	`1003`	`}`
`1004`	`1004`	`}`
`1005`	`1005`	`}`
`@@ -1008,7 +1008,7 @@ - (void)storeClusterData:(NSDictionary<MTRClusterPath , MTRDeviceClusterData >`
`1008`	`1008`	`BOOL storeFailed = ![self _bulkStoreAttributeCacheValues:bulkValuesToStore];`
`1009`	`1009`	`if (storeFailed) {`
`1010`	`1010`	`storeFailures++;`
`1011`		`- MTR_LOG_INFO("Store failed for bulk values count %lu", static_cast<unsigned long>(bulkValuesToStore.count));`
	`1011`	`+ MTR_LOG_ERROR("Store failed for bulk values count %lu", static_cast<unsigned long>(bulkValuesToStore.count));`
`1012`	`1012`	`}`
`1013`	`1013`	`}`
`1014`	`1014`