Skip to content

Commit de2cf99

Browse files
authoredSep 17, 2024
Fix for attribute and command id checking
1 parent 32200d1 commit de2cf99

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎src/python_testing/TC_DeviceConformance.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ def record_warning(location, problem):
165165
location = AttributePathLocation(endpoint_id=endpoint_id, cluster_id=cluster_id, attribute_id=attribute_id)
166166
if attribute_id not in self.xml_clusters[cluster_id].attributes.keys():
167167
# TODO: Consolidate the range checks with IDM-10.1 once that lands
168-
if attribute_id <= 0x4FFF:
168+
if (attribute_id & 0xFFFF0000) != 0:
169169
# manufacturer attribute
170170
record_error(location=location, problem='Standard attribute found on device, but not in spec')
171171
continue
@@ -192,7 +192,7 @@ def check_spec_conformance_for_commands(command_type: CommandType):
192192
location = CommandPathLocation(endpoint_id=endpoint_id, cluster_id=cluster_id, command_id=command_id)
193193
if command_id not in xml_commands_dict:
194194
# TODO: Consolidate range checks with IDM-10.1 once that lands
195-
if command_id <= 0xFF:
195+
if (command_id & 0xFFFF0000) != 0:
196196
# manufacturer command
197197
continue
198198
record_error(location=location, problem='Standard command found on device, but not in spec')

0 commit comments

Comments
 (0)