Skip to content

Commit e70c01a

Browse files
committed
add some fixes and clarifications based on feedback from Yinyi
1 parent 08d27df commit e70c01a

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

docs/testing/pics_and_pixit.md

+14-4
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,11 @@ the full set of PICS XML files into the
9292
present for the endpoint being described. Documentation on how to use the PICS
9393
tool can be found in the PICS tool readme in the tool menu.
9494

95-
Many of the full-node MCORE elements really only apply to the root node. For
96-
example, the entire device is commissionable, but commissioning tests only need
97-
to be run against EP0, so MCORE PICS should be set on the EP0 PICS set. TODO:
98-
Rene - does this apply generally or are there some gotchas here?
95+
Some of of the full-node MCORE elements really only apply to the root node,
96+
while others apply across all endpoints. For example, the entire device is
97+
commissionable, but commissioning tests only need to be run against EP0, so
98+
MCORE PICS should be set on the EP0 PICS set. Things like MCORE.IDM apply to
99+
every endpoint.
99100

100101
### Helper scripts
101102

@@ -124,6 +125,11 @@ tool:
124125
- PICS describing whether optionally-writable attributes are writable
125126
- any other non-element PICS
126127

128+
It is important to note that this script is NOT the official tool for PICS
129+
generation, just a helper to assist with this manual process. It is very
130+
important to go back and check that the values are as expected and to fill in
131+
the other PICS.
132+
127133
### Verifying PICS using the IDM-10.4 certification test
128134

129135
While not all PICS are verifiable on the device, we do have tests that verify
@@ -138,6 +144,10 @@ checker test is TC-IDM-10.4, implemented in
138144
These tests run a single set of PICS XML files against an endpoint. The
139145
`--endpoint` and `--PICS` flags are therefore required.
140146

147+
Note that you can run tests locally against the PICS XMLs for an endpoint by
148+
supplying the name of the directory containing the set of PICS XML files for
149+
that endpoint.
150+
141151
## Setting PIXITs for Matter devices
142152

143153
Matter tests do not currently have support to read PIXIT values from the PICS

0 commit comments

Comments
 (0)