Remove NotifyAllAttributesChanged

Author: andreilitvin

src/app/server-cluster/DefaultServerCluster.cpp

@@ -106,15 +106,6 @@ void DefaultServerCluster::NotifyAttributeChanged(AttributeId attributeId)
     mContext->interactionContext->dataModelChangeListener->MarkDirty({ path.mEndpointId, path.mClusterId, attributeId });
 }
 
-void DefaultServerCluster::NotifyAllAttributesChanged()
-{
-    IncreaseDataVersion();
-
-    VerifyOrReturn(mContext != nullptr);
-    const ConcreteClusterPath path = GetPath();
-    mContext->interactionContext->dataModelChangeListener->MarkDirty({ path.mEndpointId, path.mClusterId });
-}
-
 BitFlags<ClusterQualityFlags> DefaultServerCluster::GetClusterFlags() const
 {
     return {};

src/app/server-cluster/DefaultServerCluster.h

@@ -95,12 +95,6 @@ class DefaultServerCluster : public ServerClusterInterface
     /// notify that the attribute has changed.
     void NotifyAttributeChanged(AttributeId attributeId);
 
-    /// A "bulk update" notification, that notifies a wildcard attribute change.
-    ///
-    /// Increases cluster data version and if a cluster context is available, it will notify
-    /// that the cluster has changed.
-    void NotifyAllAttributesChanged();
-
 private:
     DataVersion mDataVersion; // will be random-initialized as per spec
 };

src/app/server-cluster/tests/TestDefaultServerCluster.cpp

@@ -67,7 +67,6 @@ class FakeDefaultServerCluster : public DefaultServerCluster
 
     void TestIncreaseDataVersion() { IncreaseDataVersion(); }
     void TestNotifyAttributeChanged(AttributeId attributeId) { NotifyAttributeChanged(attributeId); }
-    void TestNotifyAllAttributesChanged() { NotifyAllAttributesChanged(); }
 
 private:
     ConcreteClusterPath mPath;
@@ -200,28 +199,3 @@ TEST(TestDefaultServerCluster, NotifyAttributeChanged)
     ASSERT_EQ(context.ChangeListener().DirtyList().size(), 1u);
     ASSERT_EQ(context.ChangeListener().DirtyList()[0], AttributePathParams(kEndpointId, kClusterId, 234));
 }
-
-TEST(TestDefaultServerCluster, NotifyAllAttributesChanged)
-{
-    constexpr EndpointId kEndpointId = 321;
-    constexpr ClusterId kClusterId   = 1122;
-    FakeDefaultServerCluster cluster({ kEndpointId, kClusterId });
-
-    // When no ServerClusterContext is set, only the data version should change.
-    DataVersion oldVersion = cluster.GetDataVersion();
-
-    cluster.TestNotifyAllAttributesChanged();
-    ASSERT_NE(cluster.GetDataVersion(), oldVersion);
-
-    // Create a ServerClusterContext and verify that attribute change notifications are processed.
-    TestServerClusterContext context;
-    ASSERT_EQ(cluster.Startup(context.Get()), CHIP_NO_ERROR);
-
-    oldVersion = cluster.GetDataVersion();
-    cluster.TestNotifyAllAttributesChanged();
-    ASSERT_NE(cluster.GetDataVersion(), oldVersion);
-
-    // When all attributes are changed, a wildcard should be used in the list.
-    ASSERT_EQ(context.ChangeListener().DirtyList().size(), 1u);
-    ASSERT_EQ(context.ChangeListener().DirtyList()[0], AttributePathParams(kEndpointId, kClusterId));
-}