Skip to content

Commit f4e1946

Browse files
committed
Make it clearer what errors we ignore, add more error logic to make this run on more machines
1 parent 4c507c4 commit f4e1946

File tree

1 file changed

+17
-19
lines changed

1 file changed

+17
-19
lines changed

scripts/tests/local.py

+17-19
Original file line numberDiff line numberDiff line change
@@ -582,34 +582,32 @@ def gen_coverage():
582582
cmd.append("--add-tracefile")
583583
cmd.append(t)
584584

585+
errors_to_ignore = [
586+
"inconsistent", "range", "corrupt", "category"
587+
]
588+
585589
cmd.append("--output-file")
586590
cmd.append("out/merged.info")
587-
cmd.append("--ignore-errors")
588-
cmd.append("inconsistent")
589-
cmd.append("--ignore-errors")
590-
cmd.append("range")
591-
cmd.append("--ignore-errors")
592-
cmd.append("corrupt")
591+
for e in errors_to_ignore:
592+
cmd.append("--ignore-errors")
593+
cmd.append(e)
593594

594595
if os.path.exists("out/merged.info"):
595596
os.unlink("out/merged.info")
596597

597598
subprocess.run(cmd, check=True)
598599

599600
logging.info("Generating HTML...")
600-
subprocess.run(
601-
[
602-
"genhtml",
603-
"--ignore-errors",
604-
"inconsistent",
605-
"--ignore-errors",
606-
"range",
607-
"--output-directory",
608-
"out/coverage",
609-
"out/merged.info",
610-
],
611-
check=True,
612-
)
601+
cmd = [ "genhtml" ]
602+
for e in errors_to_ignore:
603+
cmd.append("--ignore-errors")
604+
cmd.append(e)
605+
606+
cmd.append("--output-directory")
607+
cmd.append("out/coverage")
608+
cmd.append("out/merged.info")
609+
610+
subprocess.run(cmd, check=True)
613611
logging.info("Coverage HTML should be available in out/coverage/index.html")
614612

615613

0 commit comments

Comments
 (0)