Modified YAML tests Jan 11 (#31365)

* Modified test as per test-plan:
TC_ACFREMON_2_1
TC_ACL_2_1
TC_ACL_2_3
TC_ACT_1_1
TC_BINFO_1_1
TC_BRBINFO_1_1
TC_CNET_1_3
TC_CNET_4_5
TC_CNET_4_9
TC_DD_3_1
TC_DD_3_2
TC_DGGEN_1_1
TC_DISHM_2_1
TC_DISHM_3_1
TC_DISHM_3_2
TC_DISHM_3_3
TC_DRLK_2_1
TC_DRLK_2_5
TC_DRLK_2_7
TC_FLW_2_2
TC_G_2_4
TC_I_2_3
TC_LCFG_2_1
TC_LVL_1_1
TC_LWM_2_1
TC_LWM_3_1
TC_PSCFG_1_1
TC_PS_1_1
TC_PS_2_2
TC_RVCCLEANM_3_1
TC_RVCCLEANM_3_3
TC_RVCRUNM_3_3
TC_TCCM_2_1
TC_TCCM_3_1
TC_TSTAT_1_1
TC_TSTAT_2_1

* Auto generated files

* Fix the CI falure for test TC-ACFREMON-2.1

* Fix issue 97

* Fixes issue: 102

* Restyled by prettier-yaml

* Fixes issue: 103
TC-TSUIC-1.1

* Modified tests
TC-CNET-4.1
TC-CNET-4.2
TC-TSUIC-1.1
TC-WNCV-3.4
TC-WNCV-3.5

* Remove ICDM-2.3 manual test

* Modified test
TC-OO-1.1 updated cluster revision value to 5.

* BRBINFO clusterRevision issue comment added.

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: raju-apple <84206864+raju-apple@users.noreply.github.com>

Author: 3 people

src/app/tests/suites/certification/PICS.yaml

@@ -844,6 +844,45 @@ PICS:
           "Does the DUT support sending the DisableActionWithDuration command?"
       id: ACT.C.C0b.Tx
 
+    #
+    # server / commandsGenerated
+    #
+    - label: "Does the device implement of InstantAction command?"
+      id: ACT.S.C00.Rsp
+
+    - label: "Does the device implement of InstantActionWithTransition command?"
+      id: ACT.S.C01.Rsp
+
+    - label: "Does the device implement of StartAction command?"
+      id: ACT.S.C02.Rsp
+
+    - label: "Does the device implement of StartActionWithDuration command?"
+      id: ACT.S.C03.Rsp
+
+    - label: "Does the device implement of StopAction command?"
+      id: ACT.S.C04.Rsp
+
+    - label: "Does the device implement of PauseAction command?"
+      id: ACT.S.C05.Rsp
+
+    - label: "Does the device implement of PauseActionWithDuration command?"
+      id: ACT.S.C06.Rsp
+
+    - label: "Does the device implement of ResumeAction command?"
+      id: ACT.S.C07.Rsp
+
+    - label: "Does the device implement of EnableAction command?"
+      id: ACT.S.C08.Rsp
+
+    - label: "Does the device implement of EnableActionWithDuration command?"
+      id: ACT.S.C09.Rsp
+
+    - label: "Does the device implement of DisableAction command?"
+      id: ACT.S.C0a.Rsp
+
+    - label: "Does the device implement of DisableActionWithDuration command?"
+      id: ACT.S.C0b.Rsp
+
     #
     # client / manually
     #
@@ -1813,9 +1852,12 @@ PICS:
     - label: "Does the device implement the DISHM cluster as a server?"
       id: DISHM.S
 
-    - label: "IDoes the DUT support testing the failed ChangeToMode command?"
+    - label: "Does the DUT support testing the failed ChangeToMode command?"
       id: DISHM.S.M.CAN_TEST_MODE_FAILURE
 
+    - label: "Can the mode changed by manually control at the device?"
+      id: DISHM.S.M.CAN_MANUALLY_CONTROLLED
+
     # PIXIT
 
     - label:
@@ -2063,6 +2105,15 @@ PICS:
     - label: "Does the DUT(Server) support LastConnectErrorValue attribute?"
       id: CNET.S.A0007
 
+    - label: "Does the DUT(Server) support SupportedWiFiBands attribute?"
+      id: CNET.S.A0008
+
+    - label: "Does the DUT(Server) support SupportedThreadFeatures attribute?"
+      id: CNET.S.A0009
+
+    - label: "Does the DUT(Server) support ThreadVersion attribute?"
+      id: CNET.S.A000A
+
     #
     # server / commandsReceived
     #
@@ -5380,13 +5431,13 @@ PICS:
     # server / manually
     #
     - label: "Can the DUT be brought into a Wired Fault state?"
-      id: PS.M.ManualWiredFault
+      id: PS.S.M.ManualWiredFault
 
     - label: "Can the DUT be brought into a Battery Fault state?"
-      id: PS.M.ManualBatFault
+      id: PS.S.M.ManualBatFault
 
     - label: "Can the DUT be brought into a Battery Charge Fault state?"
-      id: PS.M.ManualBatChargeFault
+      id: PS.S.M.ManualBatChargeFault
 
     #
     # client / manually
@@ -8899,6 +8950,9 @@ PICS:
     - label: "Does the DUT support testing the failed ChangeToMode command?"
       id: LWM.S.M.CAN_TEST_MODE_FAILURE
 
+    - label: "Can the mode changed by manually control at the device?"
+      id: LWM.S.M.CAN_MANUALLY_CONTROLLED
+
     - label:
           "Id of mode the device will fail to transition to, given its current
           state"
@@ -9055,6 +9109,9 @@ PICS:
           state"
       id: PIXIT.TCCM.MODE_CHANGE_FAIL
 
+    - label: "Can the mode changed by manually control at the device?"
+      id: TCCM.S.M.CAN_MANUALLY_CONTROLLED
+
     #Features
     - label:
           "Does the device support depending on an On/Off cluster implemented on

src/app/tests/suites/certification/Test_TC_ACFREMON_1_1.yaml

@@ -73,7 +73,7 @@ tests:
               hasMasksSet: [0x2]
 
     - label:
-          "Step 3d: Given ACFREMON.S.F01(ReplacementProductList) ensure
+          "Step 3d: Given ACFREMON.S.F02(ReplacementProductList) ensure
           featuremap has the correct bit set"
       command: "readAttribute"
       attribute: "FeatureMap"

src/app/tests/suites/certification/Test_TC_ACFREMON_2_1.yaml

@@ -23,7 +23,9 @@ config:
     endpoint: 1
 
 tests:
-    - label: "Step 1: Wait for the commissioned device to be retrieved"
+    - label:
+          "Step 1: Commission DUT to TH (can be skipped if done in a preceding
+          test)."
       cluster: "DelayCommands"
       command: "WaitForCommissionee"
       arguments:
@@ -52,15 +54,23 @@ tests:
               minValue: 0
               maxValue: 1
 
-    - label: "Step 4: TH reads from the DUT the ChangeIndication attribute."
-      PICS: ACFREMON.S.A0002
+    - label: "Step 4a: TH reads from the DUT the ChangeIndication attribute."
+      PICS: ACFREMON.S.A0002 && !ACFREMON.S.F01
       command: "readAttribute"
       attribute: "ChangeIndication"
       response:
           constraints:
               type: enum8
-              minValue: 0
-              maxValue: 2
+              anyOf: [0, 2]
+
+    - label: "Step 4b: TH reads from the DUT the ChangeIndication attribute."
+      PICS: ACFREMON.S.F01 && ACFREMON.S.A0002
+      command: "readAttribute"
+      attribute: "ChangeIndication"
+      response:
+          value: 1
+          constraints:
+              type: enum8
 
     - label: "Step 5: TH reads from the DUT the InPlaceIndicator attribute"
       PICS: ACFREMON.S.A0003

src/app/tests/suites/certification/Test_TC_ACL_2_1.yaml

@@ -24,15 +24,17 @@ config:
     endpoint: 0
 
 tests:
-    - label: "Step 1: Wait for the commissioned device to be retrieved"
+    - label: "Step 1: TH1 commissions DUT using admin node ID N1"
       cluster: "DelayCommands"
       command: "WaitForCommissionee"
       arguments:
           values:
               - name: "nodeId"
                 value: nodeId
 
-    - label: "Step 2: TH reads SubjectsPerAccessControlEntry attribute from DUT"
+    - label:
+          "Step 2: TH1 reads DUT Endpoint 0 AccessControl cluster
+          SubjectsPerAccessControlEntry attribute"
       PICS: ACL.S.A0002
       command: "readAttribute"
       attribute: "SubjectsPerAccessControlEntry"
@@ -42,7 +44,9 @@ tests:
               minValue: 4
               maxValue: 65535
 
-    - label: "Step 3: TH reads TargetsPerAccessControlEntry attribute from DUT"
+    - label:
+          "Step 3: TH1 reads DUT Endpoint 0 AccessControl cluster
+          TargetsPerAccessControlEntry attribute"
       PICS: ACL.S.A0003
       command: "readAttribute"
       attribute: "TargetsPerAccessControlEntry"
@@ -52,12 +56,14 @@ tests:
               minValue: 3
               maxValue: 65535
 
-    - label: "Step 4: TH reads AccessControlEntriesPerFabric attribute from DUT"
+    - label:
+          "Step 4: TH1 reads DUT Endpoint 0 AccessControl cluster
+          AccessControlEntriesPerFabric attribute"
       PICS: ACL.S.A0004
       command: "readAttribute"
       attribute: "AccessControlEntriesPerFabric"
       response:
           constraints:
               type: int16u
-              minValue: 3
+              minValue: 4
               maxValue: 65535

src/app/tests/suites/certification/Test_TC_ACL_2_3.yaml

@@ -17,6 +17,7 @@ name: 133.2.3. [TC-ACL-2.3] Extension attribute
 
 PICS:
     - ACL.S
+    - ACL.S.A0001
 
 config:
     nodeId: 0x12344321
@@ -54,7 +55,7 @@ config:
         defaultValue: ""
 
 tests:
-    - label: "Step 1: Wait for the commissioned device to be retrieved"
+    - label: "Step 1: TH1 commissions DUT using admin node ID N1"
       cluster: "DelayCommands"
       command: "WaitForCommissionee"
       arguments: