Skip to content

Commit f744451

Browse files
committed
updated script
1 parent 17c8c4d commit f744451

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed

credentials/generate_revocation_set.py

+16-10
Original file line numberDiff line numberDiff line change
@@ -270,12 +270,14 @@ def get_certificate_authority_details(crl_signer_certificate: x509.Certificate,
270270
logging.debug("Using CRL Signer certificate for details")
271271

272272
certificate_authority_name = cert_for_details.subject
273-
certificate_akid = get_skid(cert_for_details)
274-
275-
logging.debug(f"Certificate Authority Name: {certificate_authority_name}")
276-
logging.debug(f"Certificate AKID: {certificate_akid}")
273+
try:
274+
certificate_akid = get_skid(cert_for_details)
275+
logging.debug(f"Certificate Authority Name: {certificate_authority_name}")
276+
logging.debug(f"Certificate AKID: {certificate_akid}")
277277

278-
return certificate_authority_name, certificate_akid
278+
return certificate_authority_name, certificate_akid
279+
except ExtensionNotFound:
280+
logging.warning("Certificate SKID not found in authoarity certificate.")
279281

280282
def get_b64_name(name: x509.name.Name) -> str:
281283
'''
@@ -360,7 +362,7 @@ def get_paa_cert(self, initial_cert: x509.Certificate) -> Optional[x509.Certific
360362
try:
361363
akid = get_akid(initial_cert)
362364
except ExtensionNotFound:
363-
logging.error('Certificate AKID not found.')
365+
logging.warning('Certificate AKID not found.')
364366
return
365367
paa_certificate = None
366368
while not paa_certificate:
@@ -379,7 +381,7 @@ def get_paa_cert(self, initial_cert: x509.Certificate) -> Optional[x509.Certific
379381
try:
380382
akid = get_akid(issuer_certificate)
381383
except ExtensionNotFound:
382-
logging.error('Issuer Certificate AKID not found.')
384+
logging.warning('Issuer Certificate AKID not found.')
383385
logging.debug(f"akid: {akid}")
384386
if paa_certificate is None:
385387
logging.warning("PAA Certificate not found, continue...")
@@ -578,9 +580,13 @@ def __init__(self, crls: [], dcl_certificates: [], revocation_points_response_fi
578580

579581

580582
def get_lookup_key(self, certificate: x509.Certificate) -> str:
581-
base64_name = get_b64_name(certificate.subject)
582-
skid_hex_formatted = self.get_formatted_hex_skid(get_skid(certificate))
583-
return base64_name + skid_hex_formatted
583+
base64_name = get_b64_name(certificate.subject)
584+
try:
585+
skid = get_skid(certificate)
586+
skid_hex_formatted = self.get_formatted_hex_skid(skid)
587+
return base64_name + skid_hex_formatted
588+
except ExtensionNotFound:
589+
logging.warning("CertificateSKID not found, continue...")
584590

585591

586592
def get_crls(self, unread_crls: []) -> list[x509.CertificateRevocationList]:

0 commit comments

Comments
 (0)