Skip to content

Commit fa7bf1e

Browse files
committed
Fixed: Updated CI test arguments and Removed EEVSEM Arguments implemetation (OnMode and StartUpMode).
1 parent c19544d commit fa7bf1e

File tree

1 file changed

+7
-28
lines changed

1 file changed

+7
-28
lines changed

src/python_testing/TC_EEVSEM_1_2.py

+7-28
Original file line numberDiff line numberDiff line change
@@ -15,36 +15,31 @@
1515
# limitations under the License.
1616
#
1717

18-
# See https://github.com/project-chip/connectedhomeip/blob/master/docs/testing/python.md#defining-the-ci-test-arguments
19-
# for details about the block below.
20-
#
21-
# FIXME: https://github.com/project-chip/connectedhomeip/issues/36885
2218
# === BEGIN CI TEST ARGUMENTS ===
2319
# test-runner-runs:
2420
# run1:
25-
# app: ${CHIP_MICROWAVE_OVEN_APP}
26-
# app-args: --discriminator 1234 --KVS kvs1 --trace-to json:${TRACE_APP}.json
21+
# app: ${ALL_CLUSTERS_APP}
22+
# app-args: >
23+
# --discriminator 1234
24+
# --KVS kvs1
25+
# --trace-to json:${TRACE_APP}.json
2726
# script-args: >
2827
# --storage-path admin_storage.json
2928
# --commissioning-method on-network
3029
# --discriminator 1234
3130
# --passcode 20202021
32-
# --PICS src/app/tests/suites/certification/ci-pics-values
3331
# --endpoint 1
3432
# --trace-to json:${TRACE_TEST_JSON}.json
3533
# --trace-to perfetto:${TRACE_TEST_PERFETTO}.perfetto
3634
# factory-reset: true
3735
# quiet: true
3836
# === END CI TEST ARGUMENTS ===
3937

40-
import logging
4138

4239
import chip.clusters as Clusters
4340
from chip.testing.matter_testing import MatterBaseTest, TestStep, async_test_body, default_matter_test_main
4441
from modebase_cluster_check import ModeBaseClusterChecks
4542

46-
logger = logging.getLogger(__name__)
47-
4843
CLUSTER = Clusters.EnergyEvseMode
4944

5045

@@ -63,8 +58,6 @@ def steps_TC_EEVSEM_1_2(self) -> list[TestStep]:
6358
TestStep(1, "Commissioning, already done", is_commissioning=True),
6459
TestStep(2, "TH reads from the DUT the SupportedModes attribute."),
6560
TestStep(3, "TH reads from the DUT the CurrentMode attribute."),
66-
# TestStep(4, "TH reads from the DUT the OnMode attribute."),
67-
# TestStep(5, "TH reads from the DUT the StartUpMode attribute.")
6861
]
6962
return steps
7063

@@ -85,10 +78,9 @@ async def test_TC_EEVSEM_1_2(self):
8578
self.step(2)
8679
# Verify common checks for Mode Base as described in the TC-EEVSEM-1.2
8780
supported_modes = await self.check_supported_modes_and_labels(endpoint=endpoint)
88-
logger.info(f'Step #2: supported_modes({supported_modes})')
8981

90-
# According to the spec, there should be at least one Manual or Time of Use tag in
91-
# the ones supported.
82+
# According to the spec, there should be at least one Manual or Time of Use
83+
# tag in the ones supported.
9284
additional_tags = [CLUSTER.Enums.ModeTag.kManual,
9385
CLUSTER.Enums.ModeTag.kTimeOfUse]
9486
self.check_tags_in_lists(supported_modes=supported_modes, required_tags=additional_tags)
@@ -97,19 +89,6 @@ async def test_TC_EEVSEM_1_2(self):
9789
# Verify that the CurrentMode attribute has a valid value.
9890
mode = self.cluster.Attributes.CurrentMode
9991
await self.read_and_check_mode(endpoint=endpoint, mode=mode, supported_modes=supported_modes)
100-
logger.info(f'Step #4: cluster Attributes({vars(self.cluster.Attributes)})')
101-
102-
# self.step(4)
103-
# # Verify that the OnMode attribute has a valid value or null.
104-
# mode = self.cluster.Attributes.OnMode
105-
# await self.read_and_check_mode(endpoint=endpoint, mode=mode,
106-
# supported_modes=supported_modes, is_nullable=True)
107-
108-
# self.step(5)
109-
# # Verify that the StartUpMode has a valid value or null
110-
# mode = self.cluster.Attributes.StartUpMode
111-
# await self.read_and_check_mode(endpoint=endpoint, mode=mode,
112-
# supported_modes=supported_modes, is_nullable=True)
11392

11493

11594
if __name__ == "__main__":

0 commit comments

Comments
 (0)