Skip to content

Commit fc80056

Browse files
committed
Fix disabling logic
1 parent bff894e commit fc80056

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

.github/workflows/java-tests.yaml

+14-13
Original file line numberDiff line numberDiff line change
@@ -236,19 +236,20 @@ jobs:
236236
--tool-args "onnetwork-long --nodeid 1 --setup-pin-code 20202021 --discriminator 3840 -t 1000" \
237237
--factoryreset \
238238
'
239-
# TODO: test below is disabled because it seems flaky (crashes on pool not being empty on app exit)
240-
# See: https://github.com/project-chip/connectedhomeip/issues/36734
241-
# - name: Run Pairing Onnetwork and get diagnostic log Test
242-
# run: |
243-
# scripts/run_in_python_env.sh out/venv \
244-
# './scripts/tests/run_java_test.py \
245-
# --app out/linux-x64-all-clusters-ipv6only-no-ble-no-wifi-tsan-clang-test/chip-all-clusters-app \
246-
# --app-args "--discriminator 3840 --interface-id -1 --crash_log ./crashLog.log --end_user_support_log ./enduser.log --network_diagnostics_log ./network.log" \
247-
# --tool-path out/linux-x64-java-matter-controller \
248-
# --tool-cluster "bdx" \
249-
# --tool-args "onnetwork-long-downloadLog --nodeid 1 --setup-pin-code 20202021 --discriminator 3840 -t 3000 --logType CrashLogs --fileName ./crashLog.log" \
250-
# --factoryreset \
251-
# '
239+
- name: Run Pairing Onnetwork and get diagnostic log Test
240+
# TODO: test below is disabled because it seems flaky (crashes on pool not being empty on app exit)
241+
# See: https://github.com/project-chip/connectedhomeip/issues/36734
242+
if: false
243+
run: |
244+
scripts/run_in_python_env.sh out/venv \
245+
'./scripts/tests/run_java_test.py \
246+
--app out/linux-x64-all-clusters-ipv6only-no-ble-no-wifi-tsan-clang-test/chip-all-clusters-app \
247+
--app-args "--discriminator 3840 --interface-id -1 --crash_log ./crashLog.log --end_user_support_log ./enduser.log --network_diagnostics_log ./network.log" \
248+
--tool-path out/linux-x64-java-matter-controller \
249+
--tool-cluster "bdx" \
250+
--tool-args "onnetwork-long-downloadLog --nodeid 1 --setup-pin-code 20202021 --discriminator 3840 -t 3000 --logType CrashLogs --fileName ./crashLog.log" \
251+
--factoryreset \
252+
'
252253
- name: Run Pairing Onnetwork Test
253254
run: |
254255
scripts/run_in_python_env.sh out/venv \

0 commit comments

Comments
 (0)