Fix review issues

Author: jlatusek

src/protocols/secure_channel/tests/TestMessageCounterManager.cpp

@@ -102,10 +102,10 @@ TEST_F(TestMessageCounterManager, CheckReceiveMessage)
 
     uint16_t payload_len              = sizeof(PAYLOAD);
     System::PacketBufferHandle msgBuf = MessagePacketBuffer::NewWithData(PAYLOAD, payload_len);
-    EXPECT_FALSE(msgBuf.IsNull());
+    ASSERT_FALSE(msgBuf.IsNull());
 
     Messaging::ExchangeContext * ec = NewExchangeToAlice(nullptr);
-    EXPECT_NE(ec, nullptr);
+    ASSERT_NE(ec, nullptr);
 
     EXPECT_EQ(ec->SendMessage(chip::Protocols::Echo::MsgType::EchoRequest, std::move(msgBuf),
                               Messaging::SendFlags{ Messaging::SendMessageFlags::kNoAutoRequestAck }),

src/protocols/secure_channel/tests/TestStatusReport.cpp

@@ -54,7 +54,7 @@ TEST_F(TestStatusReport, NoData)
     testReport.WriteToBuffer(bbuf);
 
     System::PacketBufferHandle msgBuf = bbuf.Finalize();
-    EXPECT_FALSE(msgBuf.IsNull());
+    ASSERT_FALSE(msgBuf.IsNull());
 
     StatusReport reportToParse;
     EXPECT_EQ(reportToParse.Parse(std::move(msgBuf)), CHIP_NO_ERROR);
@@ -82,7 +82,7 @@ TEST_F(TestStatusReport, WithData)
     testReport.WriteToBuffer(bbuf);
 
     System::PacketBufferHandle msgBuf = bbuf.Finalize();
-    EXPECT_FALSE(msgBuf.IsNull());
+    ASSERT_FALSE(msgBuf.IsNull());
 
     StatusReport reportToParse;
     EXPECT_EQ(reportToParse.Parse(std::move(msgBuf)), CHIP_NO_ERROR);
@@ -91,7 +91,7 @@ TEST_F(TestStatusReport, WithData)
     EXPECT_EQ(reportToParse.GetProtocolCode(), protocolCode);
 
     const System::PacketBufferHandle & rcvData = reportToParse.GetProtocolData();
-    EXPECT_FALSE(rcvData.IsNull());
+    ASSERT_FALSE(rcvData.IsNull());
     EXPECT_EQ(rcvData->DataLength(), dataLen);
     EXPECT_EQ(memcmp(rcvData->Start(), data, dataLen), 0);
 }
@@ -117,7 +117,7 @@ TEST_F(TestStatusReport, TestMakeBusyStatusReport)
     System::Clock::Milliseconds16 minimumWaitTime = System::Clock::Milliseconds16(5000);
 
     System::PacketBufferHandle handle = StatusReport::MakeBusyStatusReportMessage(minimumWaitTime);
-    EXPECT_FALSE(handle.IsNull());
+    ASSERT_FALSE(handle.IsNull());
 
     StatusReport reportToParse;
     EXPECT_EQ(reportToParse.Parse(std::move(handle)), CHIP_NO_ERROR);
@@ -126,7 +126,7 @@ TEST_F(TestStatusReport, TestMakeBusyStatusReport)
     EXPECT_EQ(reportToParse.GetProtocolCode(), protocolCode);
 
     const System::PacketBufferHandle & rcvData = reportToParse.GetProtocolData();
-    EXPECT_FALSE(rcvData.IsNull());
+    ASSERT_FALSE(rcvData.IsNull());
     EXPECT_EQ(rcvData->DataLength(), sizeof(minimumWaitTime));
 
     uint16_t readMinimumWaitTime = 0;