Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface for revocation checks to DeviceAttestationVerifier #26430

Closed
tcarmelveilleux opened this issue May 8, 2023 · 1 comment
Closed

Add interface for revocation checks to DeviceAttestationVerifier #26430

tcarmelveilleux opened this issue May 8, 2023 · 1 comment
Assignees
@vijs
Labels
attestation
Milestone
1.3 Feature Complete

Comments

@tcarmelveilleux
Copy link
Contributor

Need to add an interface to DeviceAttestationVerifier:

RevocationReason IsCertificateRevoked(bool isPaa, ByteSpan issuer, ByteSpan authorityKeyId, ByteSpan serialNumber)

Revocation reasons enum must allow at least:

  • RevocationCheckNotSupported
  • RevokedReasonUnspecifiedOrUnknown
  • NotRevoked

The initial implementation in DefaultDeviceAttestationVerifier should return RevocationCheckNotSupported.
@tcarmelveilleux tcarmelveilleux mentioned this issue May 8, 2023
Closed
@woody-apple woody-apple added this to the 1.3 milestone Jul 25, 2023
@woody-apple woody-apple removed the v1.2 label Oct 24, 2023
@vijs vijs self-assigned this Dec 5, 2023
@vijs vijs mentioned this issue Dec 6, 2023
Closed
@vijs vijs mentioned this issue Jan 3, 2024
Merged
@shubhamdp
Copy link
Contributor

Fixed with #33651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vijs vijs

Labels
attestation
Projects
[1.3] SDK Feature Complete
Archived in project
[Feature] DA PKI Revocation
Archived in project
[Feature] Device Attestation
Archived in project
Milestone
1.3 Feature Complete
Development

No branches or pull requests
4 participants
@tcarmelveilleux @vijs @shubhamdp @woody-apple