Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] RVC Clean Mode Cluster XML has to be updated as per spec #30488

Closed
1 task
Ashwinigrl opened this issue Nov 15, 2023 · 3 comments
Closed
1 task

[1.3] RVC Clean Mode Cluster XML has to be updated as per spec #30488

Ashwinigrl opened this issue Nov 15, 2023 · 3 comments
Assignees
Labels
bug Something isn't working cert blocker needs triage robot vacuums Spec XML align SDK XML does not match the spec (including naming, etc)

Comments

@Ashwinigrl
Copy link
Contributor

Ashwinigrl commented Nov 15, 2023

Description:

  • "OnMode" is OnOff Feature dependent attribute. This feature is marked as X in conformance. (X means - This is disallowed for the cluster derivation), but it is reflecting in XML file.

Screenshot:

image

image

Spec Reference:
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/device_types/RoboticVacuumCleaner.adoc#element-requirements

XML Reference:
https://github.com/project-chip/connectedhomeip/blob/master/src/app/zap-templates/zcl/data-model/chip/rvc-clean-mode-cluster.xml

@hicklin
Copy link
Contributor

hicklin commented Nov 30, 2023

This spec indicates that the RVC device type that uses the RVCCleanMode cluster does not support the OnOff feature. However it doesn't say anything about the RVCCleanMode cluster itself. Technically this cluster can be used again and that feature could be enabled.

I agree that it is unlikely that another device should want to use this cluster. But to remove this attribute from the RVCCleanMode cluster, we should first update the spec for the cluster. Similar to what was done for the StartUpMode attribute here. This might introduce some backwards compatibility concerns.

@hicklin
Copy link
Contributor

hicklin commented Jan 16, 2024

The required change in the spec to address this issue was made in this PR.

The required changes to the SDK following this spec change PR are tracked by this issue.

@hicklin
Copy link
Contributor

hicklin commented Jan 30, 2024

This issue was addressed by PR #31451.

@hicklin hicklin closed this as completed Jan 30, 2024
@github-project-automation github-project-automation bot moved this from Open Cert Blockers to Complete in [Certification] Blockers Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cert blocker needs triage robot vacuums Spec XML align SDK XML does not match the spec (including naming, etc)
Projects
Archived in project
Archived in project
Development

No branches or pull requests

3 participants