Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] ICD management server #32321

Open
lpbeliveau-silabs opened this issue Feb 26, 2024 · 1 comment
Open

[Build] ICD management server #32321

lpbeliveau-silabs opened this issue Feb 26, 2024 · 1 comment

Comments

@lpbeliveau-silabs
Copy link
Contributor

Build issue(s)

The lock app is built including the ICD management cluster by default, but we are not enforcing it to be build as an ICD, meaning that it does not include the ICD manager source set in most of the CI builds. This result in the need to ifdef out GetICDManager calls or other ICDManager dependencies when using it in the icd-management-server.cpp.

An example of idfefing is mentioned in this dicusion: #32247 (comment)

Platform

all

Anything else?

For instance, the following CI fail on building when no ifdefing is present in emberAfIcdManagementClusterStayActiveRequestCallback
Build example - ASR / ASR
Build example - ESP32 / ESP32
Build example - Infineon / Infineon examples building
Build example - Linux ARM / Linux ARM Cross compile
Build example - Mbed OS / Mbed OS examples building
Build example - QPG / QPG
Build example - TI CC26X2X7 / cc26x2x7
Build example - TI CC32XX / cc32xx
Tests / Test Suites - Darwin (no-ble-asan-clang) (pull_request)
Tests / REPL Tests - Linux (pull_request)
Build example - ESP32 / ESP32_1 (pull_request)

@turon
Copy link
Contributor

turon commented Mar 4, 2024

WG: common zap file needs to handle platform differences gracefully. Some platforms don't build ICD and therefore break the build.

@lpbeliveau-silabs lpbeliveau-silabs changed the title [Build] Lock-App ICD management server [Build] ICD management server May 29, 2024
@andy31415 andy31415 removed the linux label Oct 24, 2024
adigie added a commit to adigie/connectedhomeip that referenced this issue Feb 19, 2025
Add ICDConfigurationData to app sources when ICD management server
cluster is included in sample, but ICD support is disabled, e.g.
lock-app on some platforms.

Related to: project-chip#32321

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
adigie added a commit to adigie/connectedhomeip that referenced this issue Feb 19, 2025
Add TODO comments for issue related to ICD management server.

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
mergify bot pushed a commit that referenced this issue Feb 19, 2025
…uster is included (#37653)

* Fix ICD management server cluster dependecies

Add ICDConfigurationData to app sources when ICD management server
cluster is included in sample, but ICD support is disabled, e.g.
lock-app on some platforms.

Related to: #32321

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>

* Add TODO comments for #32321

Add TODO comments for issue related to ICD management server.

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>

---------

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
silabs-olivierb pushed a commit to silabs-olivierb/connectedhomeip that referenced this issue Feb 19, 2025
…uster is included (project-chip#37653)

* Fix ICD management server cluster dependecies

Add ICDConfigurationData to app sources when ICD management server
cluster is included in sample, but ICD support is disabled, e.g.
lock-app on some platforms.

Related to: project-chip#32321

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>

* Add TODO comments for project-chip#32321

Add TODO comments for issue related to ICD management server.

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>

---------

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
ratgr pushed a commit to ratgr/connectedhomeip that referenced this issue Feb 26, 2025
…uster is included (project-chip#37653)

* Fix ICD management server cluster dependecies

Add ICDConfigurationData to app sources when ICD management server
cluster is included in sample, but ICD support is disabled, e.g.
lock-app on some platforms.

Related to: project-chip#32321

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>

* Add TODO comments for project-chip#32321

Add TODO comments for issue related to ICD management server.

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>

---------

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
maciejbaczmanski pushed a commit to maciejbaczmanski/connectedhomeip that referenced this issue Mar 4, 2025
…ement server cluster is included (project-chip#37653)

* Fix ICD management server cluster dependecies

Add ICDConfigurationData to app sources when ICD management server
cluster is included in sample, but ICD support is disabled, e.g.
lock-app on some platforms.

Related to: project-chip#32321

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>

* Add TODO comments for project-chip#32321

Add TODO comments for issue related to ICD management server.

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>

---------

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
(cherry picked from commit 00c6f4e)
gmarcosb pushed a commit to gmarcosb/connectedhomeip that referenced this issue Mar 4, 2025
…uster is included (project-chip#37653)

* Fix ICD management server cluster dependecies

Add ICDConfigurationData to app sources when ICD management server
cluster is included in sample, but ICD support is disabled, e.g.
lock-app on some platforms.

Related to: project-chip#32321

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>

* Add TODO comments for project-chip#32321

Add TODO comments for issue related to ICD management server.

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>

---------

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Status: Todo
Development

No branches or pull requests

3 participants