Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In fact, there is no such file of src/platform/OpenThread/BUILD.gn. Maybe we can add the source set later but not in this PR. #34594

Open
dhrishi opened this issue Jul 29, 2024 · 2 comments · May be fixed by #34662

Comments

@dhrishi
Copy link
Contributor

dhrishi commented Jul 29, 2024

          In fact, there is no such file of `src/platform/OpenThread/BUILD.gn`. Maybe we can add the source set later but not in this PR.

Originally posted by @wqx6 in #33872 (comment)

@dhrishi
Copy link
Contributor Author

dhrishi commented Jul 29, 2024

@wqx6 PTAL

@wqx6
Copy link
Contributor

wqx6 commented Jul 30, 2024

I cannot add a source_set for OpenThreadBorderRouter delegate in src/platform/OpenThread/BUILD.gn. The sources use the headers such as platform/ThreadStackManager.h which are in the static_library ${chip_root}/src/platform:platform. If we make the thread_br source_set depend on the static_library ${chip_root}/src/platform:platform. There will be a dependency cycle error. I guess that is the reason why we didn't create BUILD.gn file in src/platform/OpenThread before.

ERROR Dependency cycle:
  //third_party/connectedhomeip/src/platform:platform ->
  //third_party/connectedhomeip/src/platform/ESP32:ESP32 ->
  //third_party/connectedhomeip/src/platform/OpenThread:border-router-delegate ->
  //third_party/connectedhomeip/src/platform:platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants