Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up comments for ARL PR 34537 #34913

Closed
tleacmcsa opened this issue Aug 9, 2024 · 4 comments
Closed

Follow-up comments for ARL PR 34537 #34913

tleacmcsa opened this issue Aug 9, 2024 · 4 comments
Assignees
Labels
acl Access Control feature spec Mismatch between spec and implementation v1.4

Comments

@tleacmcsa
Copy link
Contributor

tleacmcsa commented Aug 9, 2024

These comments need resolution for 1.4:

kSubscribeEventRequest: why is this needed given subscribe privileges are the same as read? #34537 (comment)

Clarification on request type and how to identify action being performed. I believe it is addressed, but @bzbarsky-apple should verify. #34537 (comment)

Similar to above, I believe I have addressed this comment but would like @andy31415 to confirm. #34537 (comment)

@bzbarsky-apple
Copy link
Contributor

The request type bits are not addressed at least in the following:

  1. There is some sort of asymmetry between "event" and "attribute" in the RequestType values that does not actually exist: you can read attributes and events, and you can subscribe to attributes and events.
  2. The meaning of "wildcard" entityId is not defined. There is nothing like that in the spec in terms of the ARL bits, and it's really not clear what it means for that field to be "wildcard".
  3. There is no clear definition of what entityId means for different request types.

@bzbarsky-apple bzbarsky-apple added spec Mismatch between spec and implementation acl Access Control feature v1.4 labels Aug 20, 2024
@tleacmcsa
Copy link
Contributor Author

@tcarmelveilleux The first piece of this issue came from your comment. Are we good with where it landed now?

@bzbarsky-apple and @andy31415, this should line up with the spec work (https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10211). Is it clear in the spec? The intent is to be able to support restrictions on events separately from attributes.

@bzbarsky-apple
Copy link
Contributor

The spec bits I looked at this morning looked reasonable, yes.

@tcarmelveilleux
Copy link
Contributor

This is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acl Access Control feature spec Mismatch between spec and implementation v1.4
Projects
Development

No branches or pull requests

3 participants