From 9027b33abeaa585392799a26fdf808495f79c856 Mon Sep 17 00:00:00 2001 From: Kwangseob Jeong Date: Mon, 2 Dec 2024 09:04:53 +0900 Subject: [PATCH] Add return value check for avoid interger overflow To avoid overflowed constant(INTEGER_OVERFLOW) occurrence, minus operation is performed only when the value is greater than 0 --- src/lib/dnssd/TxtFields.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/dnssd/TxtFields.h b/src/lib/dnssd/TxtFields.h index 5546493624119d..1f02c48ec97a94 100644 --- a/src/lib/dnssd/TxtFields.h +++ b/src/lib/dnssd/TxtFields.h @@ -130,7 +130,7 @@ constexpr size_t MaxKeyLen(TxtKeyUse use) } } // minus 1 because sizeof includes the null terminator. - return max - 1; + return max > 0 ? max - 1 : 0; } constexpr size_t TotalKeyLen(TxtKeyUse use) { @@ -156,7 +156,7 @@ constexpr size_t MaxValueLen(TxtKeyUse use) } } // minus 1 because sizeof includes the null terminator. - return max - 1; + return max > 0 ? max - 1 : 0; } constexpr size_t TotalValueLen(TxtKeyUse use) {