From ac84610a8995613dd2cfc0be88d8c054cefe0371 Mon Sep 17 00:00:00 2001 From: Terence Hampson Date: Mon, 3 Mar 2025 15:38:37 +0000 Subject: [PATCH 1/3] Address post merge PR comments on MRP transmit analytics --- src/messaging/ReliableMessageAnalyticsDelegate.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/messaging/ReliableMessageAnalyticsDelegate.h b/src/messaging/ReliableMessageAnalyticsDelegate.h index db15c18071db2c..f0eca46e88911d 100644 --- a/src/messaging/ReliableMessageAnalyticsDelegate.h +++ b/src/messaging/ReliableMessageAnalyticsDelegate.h @@ -68,7 +68,8 @@ class ReliableMessageAnalyticsDelegate // this value will be 0. uint32_t messageCounter = 0; // If the eventType is kRetransmission, this value will be populated with the number of the - // retransmission attempt + // retransmission attempt. A value of 1 indicates the first retransmission. This value should never + // be 0. std::optional retransmissionCount; }; From 99bb4e65260592f4211a30bbcfd9ace69600d312 Mon Sep 17 00:00:00 2001 From: Terence Hampson Date: Mon, 3 Mar 2025 11:04:28 -0500 Subject: [PATCH 2/3] Update src/messaging/ReliableMessageAnalyticsDelegate.h Co-authored-by: Boris Zbarsky --- src/messaging/ReliableMessageAnalyticsDelegate.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/messaging/ReliableMessageAnalyticsDelegate.h b/src/messaging/ReliableMessageAnalyticsDelegate.h index f0eca46e88911d..9ac0ab2925f385 100644 --- a/src/messaging/ReliableMessageAnalyticsDelegate.h +++ b/src/messaging/ReliableMessageAnalyticsDelegate.h @@ -68,7 +68,7 @@ class ReliableMessageAnalyticsDelegate // this value will be 0. uint32_t messageCounter = 0; // If the eventType is kRetransmission, this value will be populated with the number of the - // retransmission attempt. A value of 1 indicates the first retransmission. This value should never + // retransmission attempt. A value of 1 indicates the first retransmission (i.e. the second transmission of the message). This value should never // be 0. std::optional retransmissionCount; }; From e08c44fd8a265e2c37e417570e5589a3a165737d Mon Sep 17 00:00:00 2001 From: Terence Hampson Date: Mon, 3 Mar 2025 16:05:20 +0000 Subject: [PATCH 3/3] Formatting --- src/messaging/ReliableMessageAnalyticsDelegate.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/messaging/ReliableMessageAnalyticsDelegate.h b/src/messaging/ReliableMessageAnalyticsDelegate.h index 9ac0ab2925f385..de223050432f88 100644 --- a/src/messaging/ReliableMessageAnalyticsDelegate.h +++ b/src/messaging/ReliableMessageAnalyticsDelegate.h @@ -68,8 +68,8 @@ class ReliableMessageAnalyticsDelegate // this value will be 0. uint32_t messageCounter = 0; // If the eventType is kRetransmission, this value will be populated with the number of the - // retransmission attempt. A value of 1 indicates the first retransmission (i.e. the second transmission of the message). This value should never - // be 0. + // retransmission attempt. A value of 1 indicates the first retransmission (i.e. the second + // transmission of the message). This value should never be 0. std::optional retransmissionCount; };