Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need CI to stop cert tests from using the unit testing cluster #218

Closed
cecille opened this issue Apr 4, 2024 · 2 comments
Closed

Need CI to stop cert tests from using the unit testing cluster #218

cecille opened this issue Apr 4, 2024 · 2 comments
Assignees

Comments

@cecille
Copy link
Contributor

cecille commented Apr 4, 2024

Summary Title:

Arithmetic operations are not supported in yaml, and somehow we're not always hitting these steps in the CI. That's a separate problem. Step 1 - let's lint for it. And also for UnitTesting, which apparently folks are using as a workaround

Description:

Need linter. Can use regex.
grep -E '(minValue|maxValue|value):\s*[a-zA-Z0-9.]+\s*[-+/]+\s[a-zA-Z0-9.]' src/app/tests/suites/certification/.yaml
grep -E 'cluster: "Unit Testing"' src/app/tests/suites/certification/
.yaml

@cecille cecille self-assigned this Apr 4, 2024
@cecille cecille changed the title Need CI to stop tests from include arithmetic operations and unit testing cluster Need CI to stop cert tests from using the unit testing cluster Apr 5, 2024
@cecille
Copy link
Contributor Author

cecille commented Apr 5, 2024

Update - arithmetic operations are supported if you writ them correctly (with a space). Terence is doing an update to support this better in the runner.

@cecille
Copy link
Contributor Author

cecille commented May 31, 2024

@cecille cecille closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant