-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python testing: change input to self.wait_for_user_input to work with TH #243
Comments
@rquidute - would you mind clarifying where the input message and prompt string should show up? Is one only for the TH? |
Hi @cecille, this PR (project-chip/connectedhomeip#32299 )has an example on how to use the self.wait_for_user_input call. The method documentation at """Ask for user input and wait for it.
@cecille please, let me know if more clarification is necessary. |
couple questions
|
Hi @cecille, providing more details as follow:
The
The prompt will be displayed as in the screenshot bellow where ![]() According to this PR project-chip/connectedhomeip#32299 , we are considering just passing the prompt_message in In addition, the |
I have a few questions about this:
|
Hi @austina-csa, I'm sharing some feedback:
Inside
|
@austina-csa - API suggestion - let's remove the input_msg from the API, and use the prompt_msg for the input call (ie, change the function in matter_testing_support.py to be
Then just do a straight-up search and replace for input with wait_for_user_input |
Hello Cecille, thanks for letting me know. I can make the necessary adjustments to the scripts that I have worked on. |
Tests requiring fixes:
The text was updated successfully, but these errors were encountered: